<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Ramon,<br>
<br>
<div class="moz-cite-prefix">On 10/26/2016 04:55 PM, Ramon Medeiros
wrote:<br>
</div>
<blockquote
cite="mid:f816451d-35b8-941e-b6e8-68f003cf2742@linux.vnet.ibm.com"
type="cite">
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
<p>Propose:<br>
<br>
</p>
Do not regenerate logrotate conf at startup of wok.<br>
<br>
Questions:<br>
<br>
1) The wok conf will be generated at make ? And then copied at
make rpm?<br>
<br>
</blockquote>
<br>
There is no need to generate the file on the fly. We can add a
wok.logrotate file to source tree and add it to rpm/deb when
building the package.<br>
<br>
<blockquote
cite="mid:f816451d-35b8-941e-b6e8-68f003cf2742@linux.vnet.ibm.com"
type="cite"> 2) The [logging] configuration at wok.conf will be
removed? letting to the user to change parameters?<br>
<br>
</blockquote>
<br>
You should only remove log_size from [logging]<br>
The other 2 parameter (log_dir and log_level) will still be used by
Wok.<br>
It would be good to add a comment there informing user about the
logrotate file. So when user updates [logging] section he/she will
need to update the logrotate file as well (if they want to keep
using of logrotate)<br>
<br>
<blockquote
cite="mid:f816451d-35b8-941e-b6e8-68f003cf2742@linux.vnet.ibm.com"
type="cite"> 3) This is the template for logrotate file<br>
<br>
LOGROTATE_TEMPLATE = """<br>
${log_dir}/*log {<br>
daily<br>
nomail<br>
maxsize ${log_size}<br>
rotate 10<br>
nomissingok<br>
compress<br>
}<br>
"""<br>
<br>
which vales for log_dir and log_size we will use?<br>
</blockquote>
<br>
Per wok.conf.in file, the default values are<br>
<br>
# Log
directory
<br>
#log_dir =
@localstatedir@/log/wok
<br>
<br>
# Log file size (specify size in K, M or
G) <br>
#log_size = 10M <br>
<br>
we can keep using them IMO.<br>
<br>
<blockquote
cite="mid:f816451d-35b8-941e-b6e8-68f003cf2742@linux.vnet.ibm.com"
type="cite">
<pre class="moz-signature" cols="72">
--
Ramon Nunes Medeiros
Kimchi Developer
Linux Technology Center Brazil
IBM Systems & Technology Group
Phone : +55 19 2132 7878
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:ramonn@br.ibm.com">ramonn@br.ibm.com</a> </pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Kimchi-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<a class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>