<div dir="ltr"><div><div><div><div><div><div>Hi Pavel!<br><br></div>I checked the code and I have some suggestions:<br><br></div>1. The new files added for build do not need to contain the IBM copyright as you did not that for IBM (or did you do?)<br><br></div>2. For the new functionality itself, I'd propose to add a build parameter, something like --with-spice-web-client to build the app with spice-web-client, otherwise, use spice-html5.<br></div>That way, we can have a easier way to move forward with Linux distribution repositories which does not allow third-part JS files into the package.<br></div>What do you think about that?<br><br></div>Regards,<br><div><div><div><div><br></div></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 3, 2018 at 11:46 AM, Pavel Gurenko <span dir="ltr"><<a href="mailto:pgurenko@gmail.com" target="_blank">pgurenko@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">If you mean the ones before installing spice guest tools (two cursors), then no, I guess it's not.<div>I had no issues with spice guest tools installed.<br><br><div class="gmail_quote"><div><div class="h5"><div dir="ltr">On Tue, Apr 3, 2018, 2:13 AM Joni Orponen <<a href="mailto:j.orponen@4teamwork.ch" target="_blank">j.orponen@4teamwork.ch</a>> wrote:<br></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Mar 28, 2018 at 8:57 PM, Pavel Gurenko <span dir="ltr"><<a href="mailto:pgurenko@gmail.com" target="_blank">pgurenko@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>The spice-html5 does not support the qxl drivers for Windows VMs and it looks like qxl has the best performance for now.<br></div><div>While spice-html5 is more like proof-of-concept, a bit slow and in general not really supported right now.</div><div><br></div><div>On the other hand, spice-web-client is performant, production solution and supports almost everything the spice can support.</div><div><br></div><div>The pull request is mostly the drop-in replacement, spice-html5 web client JavaScript gets replaced with spice-web-client JavaScript.</div><div>I used the latest version of spice-web-client from github: <a href="https://github.com/eyeos/spice-web-clien" target="_blank">https://github.com/<wbr>eyeos/spice-web-clien</a>t - unfortunately guys don't have releases in CDN.</div></div></blockquote></div><div><br></div></div></div><div dir="ltr"><div class="gmail_extra"><div>Would this also get rid of mouse acceleration mismatch issues with Windows clients?<br></div></div></div><div dir="ltr"><div class="gmail_extra"><div><br></div>-- <br><div class="m_7068528580415951206m_1328605533727002352gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Joni Orponen</div></div></div></div></div>
</div></div></div></div><span class="">
______________________________<wbr>_________________<br>
Kimchi-devel mailing list<br>
<a href="mailto:Kimchi-devel@ovirt.org" target="_blank">Kimchi-devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/kimchi-devel</a><br>
</span></blockquote></div></div>
<br>______________________________<wbr>_________________<br>
Kimchi-devel mailing list<br>
<a href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/kimchi-devel</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Aline Manera<br></div>
</div>