<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi Aline,<div class=""><br class=""></div><div class="">1. No, just copy-paste:)</div><div class="">2. That is a bit tricky, how to let client know which spice to use? Added comment in PR.</div><div class=""><br class=""></div><div class="">Created new pull without removing spice-html5 and without copyrights:</div><div class=""><a href="https://github.com/kimchi-project/kimchi/pull/1225" class="">https://github.com/kimchi-project/kimchi/pull/1225</a></div><div class=""><br class=""></div><div class="">Pavel<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Apr 22, 2018, at 8:31 PM, <a href="mailto:aline.manera@gmail.com" class="">aline.manera@gmail.com</a> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class=""><div class=""><div class=""><div class=""><div class=""><div class="">Hi Pavel!<br class=""><br class=""></div>I checked the code and I have some suggestions:<br class=""><br class=""></div>1. The new files added for build do not need to contain the IBM copyright as you did not that for IBM (or did you do?)<br class=""><br class=""></div>2. For the new functionality itself, I'd propose to add a build parameter, something like --with-spice-web-client to build the app with spice-web-client, otherwise, use spice-html5.<br class=""></div>That way, we can have a easier way to move forward with Linux distribution repositories which does not allow third-part JS files into the package.<br class=""></div>What do you think about that?<br class=""><br class=""></div>Regards,<br class=""><div class=""><div class=""><div class=""><div class=""><br class=""></div></div></div></div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Apr 3, 2018 at 11:46 AM, Pavel Gurenko <span dir="ltr" class=""><<a href="mailto:pgurenko@gmail.com" target="_blank" class="">pgurenko@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">If you mean the ones before installing spice guest tools (two cursors), then no, I guess it's not.<div class="">I had no issues with spice guest tools installed.<br class=""><br class=""><div class="gmail_quote"><div class=""><div class="h5"><div dir="ltr" class="">On Tue, Apr 3, 2018, 2:13 AM Joni Orponen <<a href="mailto:j.orponen@4teamwork.ch" target="_blank" class="">j.orponen@4teamwork.ch</a>> wrote:<br class=""></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class=""><div class="h5"><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote">On Wed, Mar 28, 2018 at 8:57 PM, Pavel Gurenko <span dir="ltr" class=""><<a href="mailto:pgurenko@gmail.com" target="_blank" class="">pgurenko@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class=""><div class="">The spice-html5 does not support the qxl drivers for Windows VMs and it looks like qxl has the best performance for now.<br class=""></div><div class="">While spice-html5 is more like proof-of-concept, a bit slow and in general not really supported right now.</div><div class=""><br class=""></div><div class="">On the other hand, spice-web-client is performant, production solution and supports almost everything the spice can support.</div><div class=""><br class=""></div><div class="">The pull request is mostly the drop-in replacement, spice-html5 web client JavaScript gets replaced with spice-web-client JavaScript.</div><div class="">I used the latest version of spice-web-client from github: <a href="https://github.com/eyeos/spice-web-clien" target="_blank" class="">https://github.com/<wbr class="">eyeos/spice-web-clien</a>t - unfortunately guys don't have releases in CDN.</div></div></blockquote></div><div class=""><br class=""></div></div></div><div dir="ltr" class=""><div class="gmail_extra"><div class="">Would this also get rid of mouse acceleration mismatch issues with Windows clients?<br class=""></div></div></div><div dir="ltr" class=""><div class="gmail_extra"><div class=""><br class=""></div>-- <br class=""><div class="m_7068528580415951206m_1328605533727002352gmail_signature" data-smartmail="gmail_signature"><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class="">Joni Orponen</div></div></div></div></div>
</div></div></div></div><span class="">
______________________________<wbr class="">_________________<br class="">
Kimchi-devel mailing list<br class="">
<a href="mailto:Kimchi-devel@ovirt.org" target="_blank" class="">Kimchi-devel@ovirt.org</a><br class="">
<a href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel" rel="noreferrer" target="_blank" class="">http://lists.ovirt.org/<wbr class="">mailman/listinfo/kimchi-devel</a><br class="">
</span></blockquote></div></div>
<br class="">______________________________<wbr class="">_________________<br class="">
Kimchi-devel mailing list<br class="">
<a href="mailto:Kimchi-devel@ovirt.org" class="">Kimchi-devel@ovirt.org</a><br class="">
<a href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel" rel="noreferrer" target="_blank" class="">http://lists.ovirt.org/<wbr class="">mailman/listinfo/kimchi-devel</a><br class="">
<br class=""></blockquote></div><br class=""><br clear="all" class=""><br class="">-- <br class=""><div class="gmail_signature" data-smartmail="gmail_signature">Aline Manera<br class=""></div>
</div>
</div></blockquote></div><br class=""></div></body></html>