<div dir="ltr">+1 for syncing CLI with conf values, its good time for cleanups and tidiness before we move forward with major features. </div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Sep 25, 2016 at 10:25 AM, Yaniv Kaul <span dir="ltr"><<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Please make sure all the changes are noted in v0.26 release notes.<span class="HOEnZb"><font color="#888888"><div>Y.</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Sep 25, 2016 at 9:02 AM, Nadav Goldin <span dir="ltr"><<a href="mailto:ngoldin@redhat.com" target="_blank">ngoldin@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all,<br>
As a side-effect of my proposed PR[1], 3 backward-incompatible<br>
changes will be added:<br>
<br>
variables names in lago.conf<br>
------------------------------<wbr>------<br>
1. 'default_ssh_user', changed to: 'ssh_user', value: no change.<br>
2. 'default_ssh_password, changed to: 'ssh_password', value: no change.<br>
3. 'template_default_repo', changed to: 'template_repo_name'(same as<br>
the existing CLI), value: was never set.<br>
The above 3 were hard-coded in config.py's defaults dictionary and<br>
never exposed externally. They had no documents, but, if a user knew<br>
about them he could have added them manually to lago.conf<br>
<br>
The reason for changing is that the PR unifies the configuration files<br>
and CLI parameters. So keeping the 'default' prefix is misleading and<br>
will lead to awkward results, such as:<br>
lago --default-ssh-user root --default-ssh-password ....<br>
instead of:<br>
lago --ssh-user root --ssh-password ...<br>
<br>
<br>
'template_*' section<br>
-------------------------<br>
'template_*' parameters which are used by lago init command, will be<br>
move to [init] section in lago.conf.<br>
<br>
<br>
lago.conf location<br>
-----------------------<br>
1. Drop /etc/lago.d/lago.conf in favour of /etc/lago/lago.conf<br>
2. The installed file from the RPM will be all commented out(i.e.<br>
installed just to use as a reference).<br>
3. /etc/lago/lago.conf will be the least important in the<br>
hierarchy(you can read more details about the hierarchy in the PR)<br>
I'll note that Lago will be fully functional without any configuration<br>
file at all.<br>
<br>
These changes will possibly affect only already-customized<br>
lago.conf files. But, changing to the new configuration format will be<br>
easy, using the 'generate-config' command:<br>
mkdir -p ~/.config/lago && lago generate-config > ~/.config/lago/lago.conf<br>
<br>
<br>
The changes are needed as the the PR mainly deals with standardizing<br>
the configuration loading module, so it is a good time for clean-up,<br>
and dropping misleading variable names(which were probably good at the<br>
time written). Second, I'm not sure how widely these parameters were<br>
used, as some of them didn't have any docs. For instance I couldn't<br>
find any evidence of usage for 'template_default_repo'(the CLI<br>
parameter is the same as it was, 'template_repo_name').<br>
<br>
<br>
<br>
Some possible alternatives:<br>
1. Issue a warning about variables name change, and use both, then in<br>
2-3 versions from now, completely remove them.<br>
2. lago.conf location: Not a major issue, as far as I know, '.d'<br>
suffix was used historically for distinguishing a 'directory' from a<br>
single configuration file, so having '/etc/lago/' is better(and<br>
keeping lago.d if someday we will need to load other user-defined<br>
configurations). But this can be easily changed.<br>
<br>
<br>
If there is no request for the alternatives or objection, I'll try to<br>
get it merged for the next version and add a short summary of this<br>
message to the release email.<br>
<br>
<br>
Thanks,<br>
<br>
Nadav.<br>
<br>
[1] <a href="https://github.com/lago-project/lago/pull/324" rel="noreferrer" target="_blank">https://github.com/lago-projec<wbr>t/lago/pull/324</a><br>
______________________________<wbr>_________________<br>
lago-devel mailing list<br>
<a href="mailto:lago-devel@ovirt.org" target="_blank">lago-devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/lago-devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/lago-devel</a><br>
</blockquote></div><br></div>
</div></div><br>______________________________<wbr>_________________<br>
lago-devel mailing list<br>
<a href="mailto:lago-devel@ovirt.org">lago-devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/lago-devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/lago-devel</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</div>