<div dir="ltr">Seems again like a new issue with flake8 version, I'm working on it.<br><br><br><br><br><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 22, 2016 at 9:45 AM, Yaniv Kaul <span dir="ltr"><<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Seems like there's a disagreement between yapf and flake on styling.<div>See <a href="http://jenkins.ovirt.org/job/lago_master_check-patch-el7-x86_64/362/console" target="_blank">http://jenkins.ovirt.org/<wbr>job/lago_master_check-patch-<wbr>el7-x86_64/362/console</a> and </div><div><a href="http://jenkins.ovirt.org/job/lago_master_check-patch-el7-x86_64/361/console" target="_blank">http://jenkins.ovirt.org/job/<wbr>lago_master_check-patch-el7-<wbr>x86_64/361/console</a> :<br></div><div><br></div><div><br></div><div><pre class="m_2803088233738836796gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px"><span class="m_2803088233738836796gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">7:24:57</b> </span>scripts/check_style.sh
<span class="m_2803088233738836796gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">07:24:57</b> </span>yapf 0.7.1
<span class="m_2803088233738836796gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">07:25:59</b> </span>--- lago/templates.py (original)
<span class="m_2803088233738836796gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">07:25:59</b> </span>+++ lago/templates.py (reformatted)
<span class="m_2803088233738836796gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">07:25:59</b> </span>@@ -260,7 +260,6 @@
<span class="m_2803088233738836796gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">07:25:59</b> </span> finally:
<span class="m_2803088233738836796gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">07:25:59</b> </span> response.close()
<span class="m_2803088233738836796gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">07:25:59</b> </span>
<span class="m_2803088233738836796gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">07:25:59</b> </span>-
<span class="m_2803088233738836796gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">07:25:59</b> </span> #: Registry for template providers
<span class="m_2803088233738836796gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">07:25:59</b> </span> _PROVIDERS = {
<span class="m_2803088233738836796gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">07:25:59</b> </span> 'file': FileSystemTemplateProvider,
<span class="m_2803088233738836796gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">07:25:59</b> </span>Yapf failed, make sure to run:
<span class="m_2803088233738836796gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">07:25:59</b> </span> yapf --style .style.yapf --in-place --recursive .</pre><pre class="m_2803088233738836796gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px"><br></pre><pre class="m_2803088233738836796gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px">vs.</pre><pre class="m_2803088233738836796gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px"><br></pre><pre class="m_2803088233738836796gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px"><pre class="m_2803088233738836796gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px"><span class="m_2803088233738836796gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">07:13:48</b> </span>PYTHONPATH=/home/jenkins/<wbr>workspace/lago_master_check-<wbr>patch-el7-x86_64/lago python /home/jenkins/workspace/lago_<wbr>master_check-patch-el7-x86_64/<wbr>lago/tests/venv/bin/flake8
<span class="m_2803088233738836796gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">07:13:52</b> </span>./lago/templates.py:264:1: E305 expected 2 blank lines after class or function definition, found 1
<span class="m_2803088233738836796gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">07:13:52</b> </span>make: *** [check-local] Error 1</pre><pre class="m_2803088233738836796gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px"><br></pre><pre class="m_2803088233738836796gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px"><br></pre><pre class="m_2803088233738836796gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px">Come on... I just want my patch in, it has nothing to do with this supposed breakage.</pre><span class="HOEnZb"><font color="#888888"><pre class="m_2803088233738836796gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px">Y.</pre></font></span></pre></div></div>
<br>______________________________<wbr>_________________<br>
lago-devel mailing list<br>
<a href="mailto:lago-devel@ovirt.org">lago-devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/lago-devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/lago-devel</a><br>
<br></blockquote></div><br></div>