[node-devel] Problem about modify admin's password on security page

Fabian Deutsch fabiand at redhat.com
Mon Jun 24 07:44:07 UTC 2013


Am Samstag, den 22.06.2013, 09:07 +0000 schrieb Bohai (ricky):
> Hi,
> 
> I found that ovirt-node doesn't support modifying admin account's password in security page and there were some discussion about it in https://bugzilla.redhat.com/show_bug.cgi?id=966354. 
> 
> I applied the patch and tested it again, but an error is thrown probably like this "list but not string". 
> 
> I found that the code "passwd.set_password("admin", pw)" in security_page.py caught this problem . Because pw was a list but not a string.
> 
> So i suggest the following modification to solve this problem:
> Before:
> pw = effective_model.values_for(passwd_keys)
> After:
> pws = effective_model.values_for(passwd_keys)
> pw=pwTmp[0]

Hey Ricky,

thanks - a good catch. I squashed this fix into the latest patchset of
http://gerrit.ovirt.org/#/c/15079/

Greetings
fabian




More information about the node-devel mailing list