<div dir="ltr">Crap, didn't realize I just had to restart vdsm for the new API.py to take effect.<div>Anyway I edited fencing.py and added back the compatibility code, and its all working for now.</div><div><br></div><div>
I'm going to work on touch up changes on fence_raritan so that we can get it submitted into the next release hopefully, all of these other hacks will become moot at that time.</div></div><div class="gmail_extra"><br><br>
<div class="gmail_quote">On Tue, Mar 25, 2014 at 2:08 PM, Dan Kenigsberg <span dir="ltr"><<a href="mailto:danken@redhat.com" target="_blank">danken@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="">On Tue, Mar 25, 2014 at 11:37:13AM -0700, David Smith wrote:<br>
> I created fence_raritan.<br>
><br>
> Unfortunately it looks like fencing.py is where the legacy --option was<br>
> translated to --action. I believe ovirt calls fencing.py as a proxy to<br>
> execute fence_raritan?<br>
><br>
> The version of fence-agents I pulled from git has the backwards<br>
> compatibility removed;<br>
> <a href="https://lists.fedorahosted.org/pipermail/cluster-commits/2013-February/003090.html" target="_blank">https://lists.fedorahosted.org/pipermail/cluster-commits/2013-February/003090.html</a><br>
><br>
><br>
> So if I added support for it in fence_raritan I'm not sure it would work (I<br>
> can try) but also the fence-agents guys probably wouldn't take the<br>
> submission to have it added to future code.<br>
<br>
</div>Indeed - I do not expect upstream fence-agents to accept the legacy<br>
option. However, you could backport your own code to el6, and create a<br>
"fence-agents-raritan" rpm from it.<br>
<div class=""><br>
><br>
> I edited API.py as in <a href="http://gerrit.ovirt.org/#/c/26075/" target="_blank">http://gerrit.ovirt.org/#/c/26075/</a> and re-compiled<br>
> API.py to pyc and pyo files and copied to all my hosts, yet I'm still<br>
> getting an error, so I'm wondering if that change is incomplete or I missed<br>
> some other step to make this actually work. It's really a bummer<br>
> especially since the default behavior with no action is reboot ;)<br>
<br>
</div>I suppose that you have missed something. My don't you place API.py<br>
under /usr/share/vdsm ? And make sure you restart vdsmd, to make the new<br>
code take effect?<br>
<br>
><br>
><br>
> *Thread-199071::DEBUG::2014-03-25 10:28:10,587::API::1110::vds::(fenceNode)<br>
> fenceNode(addr=10.105.128.25,port=,agent=raritan,user=admin,passwd=XXXX,action=status,secure=,options=port=/system1/outlet6)*<br>
><br>
><br>
> *Thread-199071::DEBUG::2014-03-25 10:28:13,104::API::1136::vds::(fenceNode)<br>
> rc 0 in agent=fence_raritan*<br>
> *ipaddr=10.105.128.25*<br>
> *login=admin*<br>
> *option=status*<br>
> *passwd=XXXX*<br>
> *port=/system1/outlet6 out Success: Rebooted*<br>
> * err Parse error: Ignoring unknown option 'option=status'*<br>
<div class="HOEnZb"><div class="h5">><br>
><br>
> On Tue, Mar 25, 2014 at 6:28 AM, Dan Kenigsberg <<a href="mailto:danken@redhat.com">danken@redhat.com</a>> wrote:<br>
><br>
> > On Tue, Mar 25, 2014 at 05:46:58AM -0400, Eli Mesika wrote:<br>
> > > AFAIK this is related to <a href="http://gerrit.ovirt.org/#/c/24343/" target="_blank">http://gerrit.ovirt.org/#/c/24343/</a> which<br>
> > changed --option to --action<br>
> > > danken ?<br>
> ><br>
> > I smells very much related.<br>
> > Where is fence_raritan comming from? Could you have the el6 version of<br>
> > it support the legacy --option name?<br>
> ><br>
> > If not, we could consider taking <a href="http://gerrit.ovirt.org/#/c/26075/" target="_blank">http://gerrit.ovirt.org/#/c/26075/</a>.<br>
> ><br>
> > Dan.<br>
> ><br>
</div></div></blockquote></div><br></div>