<div dir="ltr">Hi!<div><br></div><div><span style="font-size:13px">> I believe that this was fixed by </span><a href="http://gerrit.ovirt.org/35317" target="_blank" style="font-size:13px">http://gerrit.ovirt.org/35317</a><br style="font-size:13px"><span style="font-size:13px">> which would be in the long-delayed ovirt-3.5.1.</span><br style="font-size:13px">> <br style="font-size:13px"><span style="font-size:13px">> I'd apreciate if you try it out!</span><br></div><div><span style="font-size:13px"><br></span></div><div><span style="font-size:13px">I can't really try it out, since I had to move forward and can't do the tests now :-/ But according to the diff, this should do the same as what I did (prefix seems to be ignored in this function anyway). </span></div><div><span style="font-size:13px"><br></span></div><div><span style="font-size:13px">Nevertheless, people shouldn't use a SCOPE="peer ..." configuration (as mine was before), but should stick to a regular addr/subnet/gateway config. At least this fixed my issues....</span></div><div><span style="font-size:13px"><br></span></div><div><span style="font-size:13px">Regards,</span></div><div><span style="font-size:13px"><br></span></div><div><span style="font-size:13px">Andreas</span></div><div class="gmail_extra">
<br><div class="gmail_quote">On Fri, Jan 2, 2015 at 7:08 PM, Dan Kenigsberg <span dir="ltr"><<a href="mailto:danken@redhat.com" target="_blank">danken@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Wed, Dec 31, 2014 at 05:40:29AM -0500, Yedidyah Bar David wrote:<br>
> ----- Original Message -----<br>
> > From: "Andreas Mather" <<a href="mailto:andreas@allaboutapps.at">andreas@allaboutapps.at</a>><br>
> > To: <a href="mailto:users@ovirt.org">users@ovirt.org</a><br>
> > Sent: Wednesday, December 24, 2014 11:29:58 PM<br>
> > Subject: Re: [ovirt-users] hosted-engine --deploy fails<br>
> ><br>
> > Hi All!<br>
> ><br>
> > Just did more research on this and it seems as if the reason was related to<br>
> > my interface configuration. Disclaimer upfront: I've a public IP configured<br>
> > on this server (since it's a hosted root server), but changed the IP addr<br>
> > here to 192.168.0.99<br>
> ><br>
> > I started with the output from ´vdsm-tool restore-nets':<br>
> > ipv4addr, prefix = addr['address'].split('/')<br>
> > ValueError: need more than 1 value to unpack<br>
<br>
</span>Thanks for this report.<br>
<br>
I believe that this was fixed by <a href="http://gerrit.ovirt.org/35317" target="_blank">http://gerrit.ovirt.org/35317</a><br>
which would be in the long-delayed ovirt-3.5.1.<br>
<br>
Unfortunately, the official build of vdsm-4.16.10 for el6 is being<br>
delayed<br>
<a href="http://lists.ovirt.org/pipermail/devel/2014-December/009566.html" target="_blank">http://lists.ovirt.org/pipermail/devel/2014-December/009566.html</a><br>
but for other platforms it is already testable.<br>
<br>
I'd apreciate if you try it out!<br>
<div class="HOEnZb"><div class="h5"><br>
> ><br>
> > So I dumped the addr dictionary:<br>
> > {'address': '192.168.0.99',<br>
> > 'family': 'inet',<br>
> > 'flags': frozenset(['permanent']),<br>
> > 'index': 2,<br>
> > 'label': 'eth0',<br>
> > 'prefixlen': 32,<br>
> > 'scope': 'universe'}<br>
> ><br>
> > I've no clue why there's no "/32" at the end, but that's what my netmask<br>
> > actually is due to the special configuration I got from my hosting provider:<br>
> ><br>
> > [root@vhost1 ~]# cat /etc/sysconfig/network-scripts/ifcfg-eth0<br>
> > DEVICE=eth0<br>
> > BOOTPROTO=none<br>
> > ONBOOT=yes<br>
> > HWADDR=00:52:9F:A8:AA:BB<br>
> > IPADDR=192.168.0.99<br>
> > NETMASK=255.255.255.255<br>
> > SCOPE="peer 192.168.0.1"<br>
> ><br>
> > (again, public IPs changed to private one, if that matters. And I skipped the<br>
> > IPv6 config above...)<br>
> ><br>
> > So what I did next, was to patch the netinfo.py:<br>
> > [root@vhost1 vdsm]# diff -u netinfo_orig.py netinfo.py<br>
> > --- netinfo_orig.py 2014-12-24 22:16:23.362198715 +0100<br>
> > +++ netinfo.py 2014-12-24 22:16:02.567625247 +0100<br>
> > @@ -368,7 +368,12 @@<br>
> > if addr['family'] == 'inet':<br>
> > ipv4addrs.append(addr['address'])<br>
> > if 'secondary' not in addr['flags']:<br>
> > - ipv4addr, prefix = addr['address'].split('/')<br>
> > + """Assume /32 if no prefix was found"""<br>
> > + if addr['address'].find('/') == -1:<br>
> > + ipv4addr = addr['address']<br>
> > + prefix = "32"<br>
> > + else:<br>
> > + ipv4addr, prefix = addr['address'].split('/')<br>
> > ipv4netmask = prefix2netmask(addr['prefixlen'])<br>
> > else:<br>
> > ipv6addrs.append(addr['address'])<br>
> ><br>
> ><br>
> > and recompiled it:<br>
> > [root@vhost1 vdsm]# python -m py_compile netinfo.py<br>
> ><br>
> ><br>
> ><br>
> > Et voilà:<br>
> > vdsm-tool ran fine:<br>
> > `hosted-engine --deploy' passed the previous failing stage!<br>
><br>
> Thanks for great analysis, report and patch!<br>
> Would you like to push it to gerrit? See [1] and [2]<br>
><br>
> Adding Dan in case you do not want to, so that your patch isn't lost...<br>
><br>
> ><br>
> > Hope this helps to find the root cause....<br>
><br>
> Not sure what you mean - did you have any other problem after<br>
> applying your patch? Seems to me that the root cause is some<br>
> code (the part you patched or something earlier) did not expect<br>
> a prefix of /32, which is indeed quite rare. Not even certain<br>
> how it works - did you also get a default gateway? How can you<br>
> access it, if it's not in your subnet?<br>
><br>
> [1] <a href="http://www.ovirt.org/Develop" target="_blank">http://www.ovirt.org/Develop</a><br>
> [2] <a href="http://www.ovirt.org/Working_with_oVirt_Gerrit" target="_blank">http://www.ovirt.org/Working_with_oVirt_Gerrit</a><br>
><br>
> Best regards,<br>
> --<br>
> Didi<br>
</div></div></blockquote></div><br></div></div>