<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 16 Sep 2016, at 14:36, Michal Skrivanek <<a href="mailto:michal.skrivanek@redhat.com" class="">michal.skrivanek@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On 15 Sep 2016, at 21:46, Edward Haas <<a href="mailto:ehaas@redhat.com" class="">ehaas@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, Sep 15, 2016 at 1:30 PM, Michal Skrivanek <span dir="ltr" class=""><<a href="mailto:michal.skrivanek@redhat.com" target="_blank" class="">michal.skrivanek@redhat.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><br class="">
> On 15 Sep 2016, at 10:11, Dan Kenigsberg <<a href="mailto:danken@redhat.com" class="">danken@redhat.com</a>> wrote:<br class="">
><br class="">
> On Wed, Sep 14, 2016 at 03:04:14PM +0200, Michal Skrivanek wrote:<br class="">
>><br class="">
>>> On 09 Sep 2016, at 13:09, Edward Haas <<a href="mailto:ehaas@redhat.com" class="">ehaas@redhat.com</a>> wrote:<br class="">
>>><br class="">
>>><br class="">
>>><br class="">
>>> On Thu, Sep 8, 2016 at 11:27 AM, Pavel Levshin <<a href="mailto:lpk@581.spb.su" class="">lpk@581.spb.su</a> <mailto:<a href="mailto:lpk@581.spb.su" class="">lpk@581.spb.su</a>>> wrote:<br class="">
>>> Hi.<br class="">
>>><br class="">
>>> I'm trying to learn Ovirt 4 and have a problem with it.<br class="">
>>><br class="">
>>> My cluster consists of 3 nodes. I use Openvswitch for network connectivity. I have a HostedEngine and one additional VM in the cluster.<br class="">
>>><br class="">
>>> When I try to migrate the VM to another node, it fails. From vdsm and libvirtd logs I see that proper network interface on destination node cannot be found. Libvirt tries to find Openvswitch bridge with name like "vdsmbr_AOYiPtcT". It exists on source node, but it is unique on every node, because it contains random part. Additionally, it changes on every reboot.<br class="">
>>><br class="">
>>> How this is supposed to work?<br class="">
>>><br class="">
>>> --<br class="">
>>> Pavel Levshin<br class="">
>>><br class="">
>>><br class="">
>>><br class="">
>>> Hi Pavel,<br class="">
>>><br class="">
>>> VM migration is supported on the master branch, however it has not been ported to 4.0 yet.<br class="">
>><br class="">
>>> You can either build VDSM from source (from master branch) or try to apply this patch on what you have:<br class="">
>>> <a href="https://gerrit.ovirt.org/#/c/59645" rel="noreferrer" target="_blank" class="">https://gerrit.ovirt.org/#/c/<wbr class="">59645</a> <<a href="https://gerrit.ovirt.org/#/c/59645" rel="noreferrer" target="_blank" class="">https://gerrit.ovirt.org/#/c/<wbr class="">59645</a>><br class="">
>><br class="">
>> That’s quite a horrible solution right now. I certainly would not like to see it in 4.0 (given the hacks around display).<br class=""></div></div></blockquote><div class=""><br class=""></div><div class="">What is horrible exactly?<br class=""></div><div class="">It's not too late to propose other solutions.<br class=""></div></div></div></div></div></blockquote><div class=""><br class=""></div>if OVS is the next great feature it should fit into the code accordingly. I.e. using hooks only when it’s absolutely necessary and as a temporary measure only until the respective proper RFEs are implemented and available. E.g. when there is a libvirt support missing we can add a qemu command line parameter ourselves bypassing libvirt but we always should have a clear plan (i.e. a bug) to move away from there as soon as the support is there(requested back then when we went with the hack)</div><div class=""><br class=""></div><div class="">Such things should be reviewed as soon as we get to a similar area, so while modifying libvirt-hook.sh we can see the original reason for the hook is not valid anymore as everything is addressed and the hacky code should have been removed</div><div class="">It was easy to see that because there is a clear comment about dependent bugs and issues (though missed by all the reviewers, unfortunately!)</div><div class="">Your new code doesn’t have anything like that and I have no idea what kind of API or behavior we actually need, whether appropriate requests has been filed on e.g. libvirt. That makes it very hard to revisit in the future by the next random person.</div><div class=""><br class=""></div><div class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""><br class=""></div><div class="">Display uses libvirt to resolve a network name to an IP address for it to bound to. But that works only for linux bridges.<br class=""></div><div class="">That is limiting, especially now that we do not have a Linux bridge, but something else.<br class=""></div></div></div></div></div></blockquote><div class=""><br class=""></div>that’s ok, whatever needs to be done. But then please make sure you’re not breaking existing features, at least again not without a plan(==bug) to fix it.</div><div class=""><br class=""></div><div class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""><br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
>> Do we have a bug/plan to improve it?<br class="">
><br class="">
> We have Bug 1362495 - [OVS] - Add support for live migration<br class="">
> to track that.<br class=""></div></div></blockquote></div></div></div></div></blockquote></div></div></div></blockquote><div><br class=""></div>oh, and yes, that’s exactly the tracking I wanted to make sure exists. There’s just no link in the gerrit commit itself so I didn’t find it (but I wasn’t really looking hard either;-)</div><div><br class=""></div><div>Thanks,</div><div>michal</div><div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
><br class="">
> I'm afraid that we are not yet ready to backport it to 4.0 - we found<br class="">
> out that as it is, it break migration for vmfex and external network<br class="">
> providers; it also breaks when a buggy Engine db does not send a<br class="">
> displayNetwork. But we plan to fix these issues quite soon.<br class=""></div></div></blockquote></div></div></div></div></blockquote><div class=""><br class=""></div>which “buggy” engine? There were changes in parameters, most of these issues are not relevant anymore since we ditched <3.6 though.</div><div class="">Again it’s ok as long as it is clearly mentioned like "3.6 engine sends it in such and such parameter, we can drop it once we support 4.0+"</div><div class=""><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
><br class="">
> The hacks arround display are an actual imporovement. For "legacy"<br class="">
> switchType, we maintain an on-host libvirt-side database of all networks<br class="">
> only to keep libvirt happy. Having a database copy has all the known<br class="">
> troubles of mismatches and being out of sync. For "ovs" switchType, we<br class="">
> do not (we don't use a bridge, but a port group so there's no natural<br class="">
> way to define our network in libvirt). Modifying the listening address<br class="">
> on destination is the flexible and quick way to do it - I wish we had<br class="">
> the libvirt migrate hook years ago.<br class="">
<br class="">
</div></div>doesn’t it prevent seamless virti-viewer console connection?<br class=""></blockquote><div class=""><br class=""></div><div class="">The end result is the same, we listen on the address of a specific network.<br class=""></div><div class="">Previously it contained a network name and libvirt converted it to the correct IP it should bind to, now vdsm resolves it.<br class=""></div></div></div></div></div></blockquote><div class=""><br class=""></div>so did we request libvirt to be able to do that itself or requested an API to do that cleanly without mangling xml on the fly?</div><div class=""><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""><br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
also the “TODO” in the code about multiple graphics is worrying (we fully support it and are considering to make it a default)<br class=""></blockquote><div class=""><br class=""></div><div class="">Supported where? virt networking code in VDSM which creates an interface for domxml does not support it at the moment.<br class=""></div><div class="">Or am I missing something?<br class=""></div></div></div></div></div></blockquote><div class=""><br class=""></div><div class="">supported in oVirt. Multiple graphics VM is a regular oVirt feature. The hook doesn’t handle it correctly hence I suppose the migration would not really work correctly for these VMs.</div><div class="">Again, that might be ok temporarily with a clear documentation and a plan to fix it.</div></div><div class=""><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""><br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
If we have an idea of what API would work well? we should raise or contribute that to libvirt. Surely it takes time but it is the only way how to improve the code eventually.<br class=""></blockquote><div class=""><br class=""></div><div class="">If using libvirt can allow us to drop some persisted data and logic from vdsm, then it makes sense, but I do not think this is the case.<br class=""></div><div class="">As it stands today, depending on libvirt persisted data is limiting us, at least in the networking area. I also do not see the advantage of using it as a DB.<br class=""></div></div></div></div></div></blockquote><div class=""><br class=""></div>I’m not saying you should depend on libvirt data. But you should let libvirt community know if it is a useless feature, use a clean way how not to use that feature(if it gets in your way), ideally discuss and propose how such a feature can be improved so oVirt and all other virtualization projects can benefit from that. If it’s a truly useless feature I’m sure libvirt would be happy to drop maintaining it</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">michal</div><div class=""><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""><br class=""></div><div class="">Thaks,<br class=""></div><div class="">Edy.<br class=""></div><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="">
Thanks,<br class="">
michal<br class="">
<br class="">
</blockquote></div><br class=""></div></div>
_______________________________________________<br class="">Users mailing list<br class=""><a href="mailto:Users@ovirt.org" class="">Users@ovirt.org</a><br class=""><a href="http://lists.ovirt.org/mailman/listinfo/users" class="">http://lists.ovirt.org/mailman/listinfo/users</a><br class=""></div></blockquote></div><br class=""></div>_______________________________________________<br class="">Users mailing list<br class=""><a href="mailto:Users@ovirt.org" class="">Users@ovirt.org</a><br class="">http://lists.ovirt.org/mailman/listinfo/users<br class=""></div></blockquote></div><br class=""></body></html>