<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div></div><div><br></div><div><br>On 07 Oct 2016, at 16:10, Simone Tiraboschi <<a href="mailto:stirabos@redhat.com">stirabos@redhat.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 7, 2016 at 4:02 PM, Michal Skrivanek <span dir="ltr"><<a href="mailto:michal.skrivanek@redhat.com" target="_blank">michal.skrivanek@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><br><div><span class="gmail-"><blockquote type="cite"><div>On 7 Oct 2016, at 15:28, Simone Tiraboschi <<a href="mailto:stirabos@redhat.com" target="_blank">stirabos@redhat.com</a>> wrote:</div><br><div><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 7, 2016 at 3:25 PM, Michal Skrivanek <span dir="ltr"><<a href="mailto:michal.skrivanek@redhat.com" target="_blank">michal.skrivanek@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><br><div><span><blockquote type="cite"><div>On 7 Oct 2016, at 14:59, Nir Soffer <<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>> wrote:</div><br><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Oct 7, 2016 at 3:52 PM, Michal Skrivanek <span dir="ltr"><<a href="mailto:michal.skrivanek@redhat.com" target="_blank">michal.skrivanek@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><br><div><span><blockquote type="cite"><div>On 7 Oct 2016, at 14:42, Nir Soffer <<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>> wrote:</div><br><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Oct 5, 2016 at 1:33 PM, Simone Tiraboschi <span dir="ltr"><<a href="mailto:stirabos@redhat.com" target="_blank">stirabos@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Wed, Oct 5, 2016 at 10:34 AM, Nir Soffer <span dir="ltr"><<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span>On Wed, Oct 5, 2016 at 10:24 AM, Simone Tiraboschi <span dir="ltr"><<a href="mailto:stirabos@redhat.com" target="_blank">stirabos@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Wed, Oct 5, 2016 at 9:17 AM, gregor <span dir="ltr"><<a href="mailto:gregor_forum@catrix.at" target="_blank">gregor_forum@catrix.at</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
did you found a solution or cause for this high CPU usage?<br>
I have installed the self hosted engine on another server and there is<br>
no VM running but ovirt-ha-agent uses heavily the CPU.<br></blockquote><div><br></div></span>Yes, it's due to the fact that ovirt-ha-agent periodically reconnects over json rpc and this is CPU intensive since the client has to parse the yaml API specification each time it connects.<br></div></div></div></blockquote></span></div></div></div></blockquote></span></div></div></div></blockquote></div></div></div></div></blockquote><div><br></div></span>wasn’t it suppose to be fixed to reuse the connection? Like all the other clients (vdsm migration code:-) </div></div></blockquote><div><br></div><div>This is orthogonal issue.</div></div></div></div></div></blockquote><div><br></div></span>Yes it is. And that’s the issue;-)</div><div>Both are wrong, but by “fixing” the schema validation only you lose the motivation to fix the meaningless wasteful reconnect</div></div></blockquote><div><br></div><div>Yes, we are going to fix that too ( <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1349829" target="_blank">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=1349829</a> ) </div></div></div></div></div></blockquote><div><br></div></span>that’s great! Also al the other vdsClient uses?:-)</div></div></blockquote><div><br></div><div><a href="https://gerrit.ovirt.org/#/c/62729/">https://gerrit.ovirt.org/#/c/62729/</a><br></div></div></div></div></div></blockquote><div><br></div>Cool. It's not so important for one time actions but we need it to be able to drop xmlrpc finally, so it is important:)<div><br><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div>What is that periodic one call anyway? Is there only one? Maybe we don’t need it so much.</div></div></blockquote><div><br></div><div>Currently ovirt-ha-agent is periodically reconnecting the hosted-engine storage domain and checking its status. This is already on jsonrpc.</div></div></div></div></div></blockquote><div><br></div>Ok. As long as it is low frequency it's ok. Just bear in mind for future that some of the vdsm calls may be heavy and impact performance, regardless the communication layer. </div><div><br></div><div>Thanks and have a nice weekend,</div><div>michal</div><div><br><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>In 4.1 all the monitoring will be moved to jsonrpc.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div><span class="gmail-"><br><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>but it would require also <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1376843" target="_blank">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=1376843</a> to be fixed.</div></div></div></div></div></blockquote><div><br></div></span>This is less good. Well, worst case you can reconnect yourself, all you need is a notification when the existing connection breaks</div><div><span class="gmail-"><br><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div><span><br><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div>Does schema validation matter then if there would be only one connection at the start up?</div></div></blockquote><div><br></div><div>Loading once does not help command line tools like vdsClient, hosted-engine and</div><div>vdsm-tool. </div></div></div></div></div></blockquote><div><br></div></span>none of the other tools is using json-rpc.</div></div></blockquote><div><br></div><div>hosted-engine-setup is, and sooner or later we'll have to migrate also the remaining tools since xmlrpc has been deprecated with 4.0</div></div></div></div></div></blockquote><div><br></div></span>ok. though setup is a one-time action so it’s not an issue there</div><div><div class="gmail-h5"><div><br><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><span><div><br><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>Nir</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div><br><blockquote type="cite"><div><span><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span><div><br></div></span><div>Simone, reusing the connection is good idea anyway, but what you describe is </div><div>a bug in the client library. The library does *not* need to load and parse the</div><div>schema at all for sending requests to vdsm.</div><div><br></div><div>The schema is only needed if you want to verify request parameters,</div><div>or provide online help, these are not needed in a client library.</div><div><br></div><div>Please file an infra bug about it.</div></div></div></div></blockquote><div><br></div></span><div>Done, <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1381899" target="_blank">https://bugzilla.redhat.com/sh<wbr>ow_bug.cgi?id=1381899</a></div></div></div></div></blockquote><div><br></div><div>Here is a patch that should eliminate most most of the problem:</div><div><a href="https://gerrit.ovirt.org/65230" target="_blank">https://gerrit.ovirt.org/65230</a><br></div><div><br></div><div>Would be nice if it can be tested on the system showing this problem.</div><div><br></div><div>Cheers,</div><div>Nir</div></div></div></div></span><span>
______________________________<wbr>_________________<br>Users mailing list<br><a href="mailto:Users@ovirt.org" target="_blank">Users@ovirt.org</a><br><a href="http://lists.ovirt.org/mailman/listinfo/users" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/users</a><br></span></div></blockquote></div><br></div></blockquote></div><br></div></div>
______________________________<wbr>_________________<br>Users mailing list<br><a href="mailto:Users@ovirt.org" target="_blank">Users@ovirt.org</a><br><a href="http://lists.ovirt.org/mailman/listinfo/users" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/users</a><br></div></blockquote></div><br></span></div><br>______________________________<wbr>_________________<br>
Users mailing list<br>
<a href="mailto:Users@ovirt.org" target="_blank">Users@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/users" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/users</a><br>
<br></blockquote></div><br></div></div>
______________________________<wbr>_________________<br>Users mailing list<br><a href="mailto:Users@ovirt.org" target="_blank">Users@ovirt.org</a><br><a href="http://lists.ovirt.org/mailman/listinfo/users" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/users</a><br></div></blockquote></div><br></div></div></div></blockquote></div><br></div></div>
</div></blockquote></div></body></html>