<div dir="ltr">Good News.<div><br></div><div>I installed the fedora 24 version of <span style="font-size:12.8px">python-dmidecode and was able to successfully add the host to my cluster...</span></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">Thanks you to everyone who looked at this. I owe you a beer or at least some reward points :-)</span></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px"><br></span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 13, 2016 at 7:28 PM, Martin Polednik <span dir="ltr"><<a href="mailto:mpolednik@redhat.com" target="_blank">mpolednik@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 13/10/16 09:01 +0300, Dan Kenigsberg wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Thu, Oct 13, 2016 at 11:52:17AM +1100, David Pinkerton wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Nir,<br>
<br>
Looks like its crashing on the dmidecode system call.<br>
<br>
I've attached the output from gbd as well as a dmidecode text dump,<br>
dmidecode binary dump and each keywords run individually.<br>
<br>
>From the keywords it look like my dmi info is corrupted. I have download a<br>
AMI dmi editor but this only allows access to limited fields. Do you know<br>
another tools to rewrite the dmi info?<br>
</blockquote>
<br>
I don't. But whatever is inside your dmi, dmidecode must not crash.<br>
Which version of python-dmidecode do you have installed?<br>
Would you open a bug against it?<br>
</blockquote>
<br>
This is really unfortunate - I've reproduced the issue with the<br>
attached dump and it's python-dmidecode that crashes. The issue is<br>
actually fixed upstream, but the version at least in RHEL does not<br>
contain the fix.<br>
<br>
RHEL version:<br>
python-dmidecode-<a href="tel:3.10.13-11" value="+13101311" target="_blank">3.10.13-11</a>.<wbr>el7.x86_64<br>
<br>
works with (actual upstream):<br>
python-dmidecode-3.12.2-1.el7.<wbr>x86_64<br>
(actually it's ~6 line change in dmioem.c)<br>
<br>
VDSM output:<br>
# vdsClient 0 getVdsHardwareInfo<br>
systemFamily = 'To Be Filled By O.E.M.'<br>
systemManufacturer = 'Supermicro'<br>
systemProductName = 'H8DM8-2'<br>
systemSerialNumber = '1234567890'<br>
systemUUID = '00020003-0004-0005-0006-00070<wbr>0080009'<br>
systemVersion = '1234567890'<br>
<br>
Although the upstream version of python-dmidecode is able to deal with<br>
improper DMI tables, I can't say what else will/will not behave correctly.<br>
<br>
mpolednik<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I believe that its maintainers would appriace a simple reproducer, that<br>
does not involve ovirt or Vdsm. See if you can simplify the code in<br>
<br>
def __leafDict(d):<br>
ret = {}<br>
for k, v in d.iteritems():<br>
if isinstance(v, dict):<br>
ret.update(__leafDict(v))<br>
else:<br>
ret[k] = v<br>
return ret<br>
<br>
<br>
def getAllDmidecodeInfo():<br>
import dmidecode<br>
<br>
myLeafDict = {}<br>
for k in ('system', 'bios', 'cache', 'processor', 'chassis', 'memory'):<br>
myLeafDict[k] = __leafDict(getattr(dmidecode, k)())<br>
return myLeafDict<br>
______________________________<wbr>_________________<br>
Users mailing list<br>
<a href="mailto:Users@ovirt.org" target="_blank">Users@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/users" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/users</a><br>
</blockquote>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><pre cols="72">David Pinkerton
Consultant
Red Hat Asia Pacific Pty. Ltd.
Level 11, Canberra House
40 Marcus Clarke Street
Canberra 2600 ACT
Mobile: +61-488-904-232
Email: <a href="mailto:david.pinkerton@redhat.com" target="_blank">david.pinkerton@redhat.com</a>
Web: <a href="http://apac.redhat.com/" target="_blank">http://apac.redhat.com/</a>
<a href="http://apac.redhat.com/" target="_blank"></a></pre>
</div></div></div></div></div></div></div></div></div></div>
</div>