<div dir="ltr">done: <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1422959">https://bugzilla.redhat.com/show_bug.cgi?id=1422959</a><br><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 16, 2017 at 5:00 PM, Nir Soffer <span dir="ltr"><<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Thu, Feb 16, 2017 at 5:55 PM, Arman Khalatyan <<a href="mailto:arm2arm@gmail.com">arm2arm@gmail.com</a>> wrote:<br>
> The test disks are not attached to any virtual machine. nothing done on the<br>
> hosts.<br>
> I just saw that the all test LUNs are still logged into target side so I<br>
> went to the host(it was in the maintenance ) all disks are still there.<br>
><br>
> I just managing everything over the web gui:<br>
> Select host as SPM, then disks->new->directLUN-><wbr>discovertargets->login->ok<br>
> on the host the disks are visible.<br>
> iscsiadm -m session -o show<br>
> tcp: [6] <a href="http://10.10.10.35:3260" rel="noreferrer" target="_blank">10.10.10.35:3260</a>,1<br>
> iqn.2003-01.org.linux-iscsi.<wbr>c1701.x8664:sn.5b791971cd78 (non-flash)<br>
><br>
> Putting host to maintenance:<br>
> the disks are still there:<br>
> lsscsi<br>
> [0:0:0:0] disk ATA ST3500630NS K /dev/sda<br>
> [11:0:0:0] disk LIO-ORG c1701iser 4.0 /dev/sdb<br>
> [11:0:0:1] disk LIO-ORG c1701iser32k 4.0 /dev/sdc<br>
><br>
> activating deactivating the host does not change situation.<br>
> I dont see any attempt of vdsm to logout the disks. I can see in the<br>
> vdsmd.logs that "[storage.Mount] unmounting /rhev/data-center/mnt/......"<br>
> unmounting the nfs part but nothing from [storage.ISCSI]<br>
<br>
</span>Sounds like a bug in target discovery flow. We add nodes and sessions and<br>
do not clean them.<br>
<br>
Would you file a bug?<br>
<span class="HOEnZb"><font color="#888888"><br>
Nir<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
><br>
><br>
><br>
> On Thu, Feb 16, 2017 at 4:25 PM, Nir Soffer <<a href="mailto:nsoffer@redhat.com">nsoffer@redhat.com</a>> wrote:<br>
>><br>
>> On Thu, Feb 16, 2017 at 5:13 PM, Arman Khalatyan <<a href="mailto:arm2arm@gmail.com">arm2arm@gmail.com</a>><br>
>> wrote:<br>
>> > Hi,<br>
>> > In ovirt 4.1 when I put the host into maintenance mode then the nfs<br>
>> > mounts<br>
>> > are unmounted as expected.<br>
>> > but the hosts are still logged into the targets.<br>
>> ><br>
>> > Is it expected behavior?? If yes what is the use of it?<br>
>><br>
>> No, if ovirt connected to the target, it should disconnect from the<br>
>> target.<br>
>><br>
>> Maybe you connected manually to the target before that?<br>
>><br>
>> A good test to verify this would be to do this in maintenance mode:<br>
>><br>
>> iscsiadm -m node -o delete<br>
>><br>
>> Then activate and deactivate the host several times, and check that<br>
>> no iscsi session are active when host enter maintenance.<br>
>><br>
>> > Another thing concerning to the permanently removed direct LUNs.<br>
>> > They are still in the /var/lib/iscsi/nodes and<br>
>> > /var/lib/iscsi/send_targets/*<br>
>> > Would be good to cleanup the folders if users are removing permanently<br>
>> > the<br>
>> > LUNs.<br>
>><br>
>> We don't manage the LUNs - if you are removing the LUNs manually, and<br>
>> the target providing this LUNs is not needed any more, you are responsible<br>
>> for removing the nodes from iscsi database.<br>
>><br>
>> I don't think we are removing nodes and targets from a host, only updating<br>
>> them when you connect to a server. We also don't have a way to remove<br>
>> a target from engine database, so engine cannot ask vdsm to remove<br>
>> targets.<br>
>><br>
>> Nir<br>
><br>
><br>
</div></div></blockquote></div><br></div>