<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Mar 9, 2017 at 11:23 AM, Juan Hernández <span dir="ltr"><<a href="mailto:jhernand@redhat.com" target="_blank">jhernand@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
> Very good point Gialuca, you are right, the 'persist_memorystate' flag<br>
> is 'true' by default, and that makes the pause longer. Would you be so<br>
> kind to add it to the 'vm_backup.py' example that is part of version 4<br>
> of the SDK?<br>
><br>
><br>
> <a href="https://github.com/oVirt/ovirt-engine-sdk/blob/master/sdk/examples/vm_backup.py#L143-L151" rel="noreferrer" target="_blank">https://github.com/oVirt/<wbr>ovirt-engine-sdk/blob/master/<wbr>sdk/examples/vm_backup.py#<wbr>L143-L151</a><br>
> <<a href="https://github.com/oVirt/ovirt-engine-sdk/blob/master/sdk/examples/vm_backup.py#L143-L151" rel="noreferrer" target="_blank">https://github.com/oVirt/<wbr>ovirt-engine-sdk/blob/master/<wbr>sdk/examples/vm_backup.py#<wbr>L143-L151</a>><br>
><br>
> (Note that that Gibhub is just a mirror, the change needs to be submited<br>
</span>> using <a href="http://gerrit.ovirt.org" rel="noreferrer" target="_blank">gerrit.ovirt.org</a> <<a href="http://gerrit.ovirt.org" rel="noreferrer" target="_blank">http://gerrit.ovirt.org</a>>).<br>
<div><div class="h5">><br>
><br>
><br>
> I already verified (on a 4.1 infra) that changing vm_backup.py<br>
> downloaded yesterday from master this way (apart connection paramters):<br>
><br>
> $ diff vm_backup.py vm_backup.py.orig<br>
> 150d149<br>
> < persist_memorystate=False,<br>
><br>
> I get the backup result and snapshot is correctly without memory saved<br>
> (and no pause at VM side)<br>
><br><br></div></div></blockquote><div>[snip] </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
<br>
</div></div>I see that you already have a <a href="http://gerrit.ovirt.org" rel="noreferrer" target="_blank">gerrit.ovirt.org</a>, so it shouldn't be<br>
difficult. The initial setup should be like this:<br>
<br>
$ git config --global <a href="http://user.name" rel="noreferrer" target="_blank">user.name</a> youruser<br>
$ git config --global user.email your@email<br>
$ git clone ssh://<a href="http://youruser@gerrit.ovirt.org:29418/ovirt-engine-sdk" rel="noreferrer" target="_blank">youruser@gerrit.ovirt.<wbr>org:29418/ovirt-engine-sdk</a><br>
$ gitdir=$(git rev-parse --git-dir); scp -p -P 29418<br>
youruser@gerrit.ovirt.org:hook<wbr>s/commit-msg ${gitdir}/hooks/<br>
<br>
Then, to submit the patch:<br>
<br>
$ cd ovirt-engine-sdk<br>
$ Edit the vm_backup.py file, and make your changes.<br>
$ git commit -a -s<br>
$ git push origin HEAD:refs/for/master<br><br></blockquote><div><br></div><div>Ok. I found the time to try and apparently it worked as expected.</div><div>The master (you? jenkins CI? ;-) should see my change...</div><div>Just learnt (a little...) another thing</div><div><br></div><div>sys admins often try to put an eye inside devs field but the reverse seldom happens ;-)</div></div><br></div></div>