From Richard.Hopper at netapp.com Mon Jun 17 14:16:13 2013 Content-Type: multipart/mixed; boundary="===============7413934508664845241==" MIME-Version: 1.0 From: Hopper, Richard To: devel at ovirt.org Subject: [Engine-devel] IE9 Issue with UI Plugin Date: Mon, 17 Jun 2013 18:16:03 +0000 Message-ID: --===============7413934508664845241== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable --_000_CDE4CAA25617rickyhnetappcom_ Content-Type: text/plain; charset=3D"us-ascii" Content-Transfer-Encoding: quoted-printable Hi Vojtech, I had previously sent you an email about IE9 compatibility where the proble= =3D m we were having was solved by omitting console logging when a console was = =3D unavailable (i.e. IE). However, it is looking like IE9 may have a bigger is= =3D sue with regards to the plugin framework. Now that we have gotten dialogs to open via dynamically inserted buttons wi= =3D thin RHEV tabs (for example, a NetApp button in the Storage tab), we can go= =3D through our whole process with the exception of closing the window. In all= =3D other browsers, our dialog will close as expected, but in IE the window re= =3D mains open. It can be closed by hitting the red "x" in the corner, but it a= =3D ppears the code in the frame itself cannot close the window, with a console= =3D message in the dev tools of IE9 showing an error of "'Math' is undefined".= =3D I've read up on this, and it seems like this is a very widespread error in= =3D Internet Explorer concerning the manner/order in which iframes are dynamic= =3D ally inserted. I've copied engine-devel in case anyone has similar issues/solutions, but i= =3D t seems as though we need some sort of clause in the plugin framework for I= =3D E when it comes to dynamic insertion of new windows. - Ricky Hopper --_000_CDE4CAA25617rickyhnetappcom_ Content-Type: text/html; charset=3D"us-ascii" Content-ID: <6646E7BF4E36D34C8F6BD9BF13E47974(a)hq.netapp.com> Content-Transfer-Encoding: quoted-printable

Hi Vojtech,

I had previously sent you an email about IE9 compatibility where the p= =3D roblem we were having was solved by omitting console logging when a console= =3D was unavailable (i.e. IE). However, it is looking like IE9 may have a bigg= =3D er issue with regards to the plugin framework.

Now that we have gotten dialogs to open via dynamically inserted butto= =3D ns within RHEV tabs (for example, a NetApp button in the Storage tab), we c= =3D an go through our whole process with the exception of closing the window. I= =3D n all other browsers, our dialog will close as expected, but in IE the window remains open. It can be close= =3D d by hitting the red "x" in the corner, but it appears the code i= =3D n the frame itself cannot close the window, with a console message in the d= =3D ev tools of IE9 showing an error of "'Math' is undefined". I've read up on this, and it seems like this is a very= =3D widespread error in Internet Explorer concerning the manner/order in which= =3D iframes are dynamically inserted.

I've copied engine-devel in case anyone has similar issues/solutions, = =3D but it seems as though we need some sort of clause in the plugin framework = =3D for IE when it comes to dynamic insertion of new windows.

- Ricky Hopper

--_000_CDE4CAA25617rickyhnetappcom_-- --===============7413934508664845241== Content-Type: multipart/alternative MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.bin" LS1fMDAwX0NERTRDQUEyNTYxN3JpY2t5aG5ldGFwcGNvbV8KQ29udGVudC1UeXBlOiB0ZXh0L3Bs YWluOyBjaGFyc2V0PSJ1cy1hc2NpaSIKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogcXVvdGVk LXByaW50YWJsZQoKSGkgVm9qdGVjaCwKCkkgaGFkIHByZXZpb3VzbHkgc2VudCB5b3UgYW4gZW1h aWwgYWJvdXQgSUU5IGNvbXBhdGliaWxpdHkgd2hlcmUgdGhlIHByb2JsZT0KbSB3ZSB3ZXJlIGhh dmluZyB3YXMgc29sdmVkIGJ5IG9taXR0aW5nIGNvbnNvbGUgbG9nZ2luZyB3aGVuIGEgY29uc29s ZSB3YXMgPQp1bmF2YWlsYWJsZSAoaS5lLiBJRSkuIEhvd2V2ZXIsIGl0IGlzIGxvb2tpbmcgbGlr ZSBJRTkgbWF5IGhhdmUgYSBiaWdnZXIgaXM9CnN1ZSB3aXRoIHJlZ2FyZHMgdG8gdGhlIHBsdWdp biBmcmFtZXdvcmsuCgpOb3cgdGhhdCB3ZSBoYXZlIGdvdHRlbiBkaWFsb2dzIHRvIG9wZW4gdmlh IGR5bmFtaWNhbGx5IGluc2VydGVkIGJ1dHRvbnMgd2k9CnRoaW4gUkhFViB0YWJzIChmb3IgZXhh bXBsZSwgYSBOZXRBcHAgYnV0dG9uIGluIHRoZSBTdG9yYWdlIHRhYiksIHdlIGNhbiBnbz0KIHRo cm91Z2ggb3VyIHdob2xlIHByb2Nlc3Mgd2l0aCB0aGUgZXhjZXB0aW9uIG9mIGNsb3NpbmcgdGhl IHdpbmRvdy4gSW4gYWxsPQogb3RoZXIgYnJvd3NlcnMsIG91ciBkaWFsb2cgd2lsbCBjbG9zZSBh cyBleHBlY3RlZCwgYnV0IGluIElFIHRoZSB3aW5kb3cgcmU9Cm1haW5zIG9wZW4uIEl0IGNhbiBi ZSBjbG9zZWQgYnkgaGl0dGluZyB0aGUgcmVkICJ4IiBpbiB0aGUgY29ybmVyLCBidXQgaXQgYT0K cHBlYXJzIHRoZSBjb2RlIGluIHRoZSBmcmFtZSBpdHNlbGYgY2Fubm90IGNsb3NlIHRoZSB3aW5k b3csIHdpdGggYSBjb25zb2xlPQogbWVzc2FnZSBpbiB0aGUgZGV2IHRvb2xzIG9mIElFOSBzaG93 aW5nIGFuIGVycm9yIG9mICInTWF0aCcgaXMgdW5kZWZpbmVkIi49CiBJJ3ZlIHJlYWQgdXAgb24g dGhpcywgYW5kIGl0IHNlZW1zIGxpa2UgdGhpcyBpcyBhIHZlcnkgd2lkZXNwcmVhZCBlcnJvciBp bj0KIEludGVybmV0IEV4cGxvcmVyIGNvbmNlcm5pbmcgdGhlIG1hbm5lci9vcmRlciBpbiB3aGlj aCBpZnJhbWVzIGFyZSBkeW5hbWljPQphbGx5IGluc2VydGVkLgoKSSd2ZSBjb3BpZWQgZW5naW5l LWRldmVsIGluIGNhc2UgYW55b25lIGhhcyBzaW1pbGFyIGlzc3Vlcy9zb2x1dGlvbnMsIGJ1dCBp PQp0IHNlZW1zIGFzIHRob3VnaCB3ZSBuZWVkIHNvbWUgc29ydCBvZiBjbGF1c2UgaW4gdGhlIHBs dWdpbiBmcmFtZXdvcmsgZm9yIEk9CkUgd2hlbiBpdCBjb21lcyB0byBkeW5hbWljIGluc2VydGlv biBvZiBuZXcgd2luZG93cy4KCi0gUmlja3kgSG9wcGVyCgotLV8wMDBfQ0RFNENBQTI1NjE3cmlj a3lobmV0YXBwY29tXwpDb250ZW50LVR5cGU6IHRleHQvaHRtbDsgY2hhcnNldD0idXMtYXNjaWki CkNvbnRlbnQtSUQ6IDw2NjQ2RTdCRjRFMzZEMzRDOEY2QkQ5QkYxM0U0Nzk3NEBocS5uZXRhcHAu Y29tPgpDb250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiBxdW90ZWQtcHJpbnRhYmxlCgo8aHRtbD4K PGhlYWQ+CjxtZXRhIGh0dHAtZXF1aXY9M0QiQ29udGVudC1UeXBlIiBjb250ZW50PTNEInRleHQv aHRtbDsgY2hhcnNldD0zRHVzLWFzY2lpIj0KPgo8L2hlYWQ+Cjxib2R5IHN0eWxlPTNEIndvcmQt d3JhcDogYnJlYWstd29yZDsgLXdlYmtpdC1uYnNwLW1vZGU6IHNwYWNlOyAtd2Via2l0LWxpbj0K ZS1icmVhazogYWZ0ZXItd2hpdGUtc3BhY2U7IGNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtc2l6 ZTogMTRweDsgZm9udC1mYW1pPQpseTogQ2FsaWJyaSwgc2Fucy1zZXJpZjsgIj4KPGRpdj5IaSBW b2p0ZWNoLDwvZGl2Pgo8ZGl2Pjxicj4KPC9kaXY+CjxkaXY+SSBoYWQgcHJldmlvdXNseSBzZW50 IHlvdSBhbiBlbWFpbCBhYm91dCBJRTkgY29tcGF0aWJpbGl0eSB3aGVyZSB0aGUgcD0Kcm9ibGVt IHdlIHdlcmUgaGF2aW5nIHdhcyBzb2x2ZWQgYnkgb21pdHRpbmcgY29uc29sZSBsb2dnaW5nIHdo ZW4gYSBjb25zb2xlPQogd2FzIHVuYXZhaWxhYmxlIChpLmUuIElFKS4gSG93ZXZlciwgaXQgaXMg bG9va2luZyBsaWtlIElFOSBtYXkgaGF2ZSBhIGJpZ2c9CmVyIGlzc3VlIHdpdGggcmVnYXJkcyB0 byB0aGUgcGx1Z2luCiBmcmFtZXdvcmsuPC9kaXY+CjxkaXY+PGJyPgo8L2Rpdj4KPGRpdj5Ob3cg dGhhdCB3ZSBoYXZlIGdvdHRlbiBkaWFsb2dzIHRvIG9wZW4gdmlhIGR5bmFtaWNhbGx5IGluc2Vy dGVkIGJ1dHRvPQpucyB3aXRoaW4gUkhFViB0YWJzIChmb3IgZXhhbXBsZSwgYSBOZXRBcHAgYnV0 dG9uIGluIHRoZSBTdG9yYWdlIHRhYiksIHdlIGM9CmFuIGdvIHRocm91Z2ggb3VyIHdob2xlIHBy b2Nlc3Mgd2l0aCB0aGUgZXhjZXB0aW9uIG9mIGNsb3NpbmcgdGhlIHdpbmRvdy4gST0KbiBhbGwg b3RoZXIgYnJvd3NlcnMsIG91ciBkaWFsb2cKIHdpbGwgY2xvc2UgYXMgZXhwZWN0ZWQsIGJ1dCBp biBJRSB0aGUgd2luZG93IHJlbWFpbnMgb3Blbi4gSXQgY2FuIGJlIGNsb3NlPQpkIGJ5IGhpdHRp bmcgdGhlIHJlZCAmcXVvdDt4JnF1b3Q7IGluIHRoZSBjb3JuZXIsIGJ1dCBpdCBhcHBlYXJzIHRo ZSBjb2RlIGk9Cm4gdGhlIGZyYW1lIGl0c2VsZiBjYW5ub3QgY2xvc2UgdGhlIHdpbmRvdywgd2l0 aCBhIGNvbnNvbGUgbWVzc2FnZSBpbiB0aGUgZD0KZXYgdG9vbHMgb2YgSUU5IHNob3dpbmcgYW4g ZXJyb3Igb2YgJnF1b3Q7J01hdGgnCiBpcyB1bmRlZmluZWQmcXVvdDsuIEkndmUgcmVhZCB1cCBv biB0aGlzLCBhbmQgaXQgc2VlbXMgbGlrZSB0aGlzIGlzIGEgdmVyeT0KIHdpZGVzcHJlYWQgZXJy b3IgaW4gSW50ZXJuZXQgRXhwbG9yZXIgY29uY2VybmluZyB0aGUgbWFubmVyL29yZGVyIGluIHdo aWNoPQogaWZyYW1lcyBhcmUgZHluYW1pY2FsbHkgaW5zZXJ0ZWQuJm5ic3A7PC9kaXY+CjxkaXY+ PGJyPgo8L2Rpdj4KPGRpdj5JJ3ZlIGNvcGllZCBlbmdpbmUtZGV2ZWwgaW4gY2FzZSBhbnlvbmUg aGFzIHNpbWlsYXIgaXNzdWVzL3NvbHV0aW9ucywgPQpidXQgaXQgc2VlbXMgYXMgdGhvdWdoIHdl IG5lZWQgc29tZSBzb3J0IG9mIGNsYXVzZSBpbiB0aGUgcGx1Z2luIGZyYW1ld29yayA9CmZvciBJ RSB3aGVuIGl0IGNvbWVzIHRvIGR5bmFtaWMgaW5zZXJ0aW9uIG9mIG5ldyB3aW5kb3dzLjwvZGl2 Pgo8ZGl2Pjxicj4KPC9kaXY+CjxkaXY+LSBSaWNreSBIb3BwZXI8L2Rpdj4KPC9ib2R5Pgo8L2h0 bWw+CgotLV8wMDBfQ0RFNENBQTI1NjE3cmlja3lobmV0YXBwY29tXy0tCg== --===============7413934508664845241==-- From vszocs at redhat.com Wed Jun 19 05:54:19 2013 Content-Type: multipart/mixed; boundary="===============1916131653562793524==" MIME-Version: 1.0 From: Vojtech Szocs To: devel at ovirt.org Subject: Re: [Engine-devel] IE9 Issue with UI Plugin Date: Wed, 19 Jun 2013 05:54:16 -0400 Message-ID: <1796208617.20183450.1371635656569.JavaMail.root@redhat.com> In-Reply-To: CDE4CAA2.5617%rickyh@netapp.com --===============1916131653562793524== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Ricky, code running in the iframe (custom dialog content) can close the dialog in = the following way: 1, send message to your plugin to indicate the dialog needs to be closed: parent.postMessage('CloseMyDialog', '*'); 2, your plugin intercepts the message via MessageReceived function and clos= es the dialog: MessageReceived: function(data, sourceWindow) { switch (data) { case 'CloseMyDialog': window.alert('About to close dialog'); api.closeDialog('my-dialog'); break; } } If the above doesn't work for you, it could mean that: - MessageReceived function isn't invoked - make sure to have [*] before api= .register() call - api.closeDialog() function isn't working - in this case I need to fix it = for IE9 [*] accept message events from iframe (custom dialog content) origin api.options({ allowedMessageOrigins: 'http://nicedomain:8080' /* OR */ allowedMessageOrigins: ['http://nicedomain1:123', 'https://nicedoma= in2:345'] }); I'm going to investigate this issue on IE9 myself to see if the above code = is really working there. Vojtech ----- Original Message ----- > From: "Richard Hopper" > To: "Vojtech Szocs" > Cc: engine-devel(a)ovirt.org, "Christopher Morrissey" > Sent: Monday, June 17, 2013 8:16:03 PM > Subject: IE9 Issue with UI Plugin > = > Hi Vojtech, > = > I had previously sent you an email about IE9 compatibility where the prob= lem > we were having was solved by omitting console logging when a console was > unavailable (i.e. IE). However, it is looking like IE9 may have a bigger > issue with regards to the plugin framework. > = > Now that we have gotten dialogs to open via dynamically inserted buttons > within RHEV tabs (for example, a NetApp button in the Storage tab), we can > go through our whole process with the exception of closing the window. In > all other browsers, our dialog will close as expected, but in IE the wind= ow > remains open. It can be closed by hitting the red "x" in the corner, but = it > appears the code in the frame itself cannot close the window, with a cons= ole > message in the dev tools of IE9 showing an error of "'Math' is undefined". > I've read up on this, and it seems like this is a very widespread error in > Internet Explorer concerning the manner/order in which iframes are > dynamically inserted. > = > I've copied engine-devel in case anyone has similar issues/solutions, but= it > seems as though we need some sort of clause in the plugin framework for IE > when it comes to dynamic insertion of new windows. > = > - Ricky Hopper >=20 --===============1916131653562793524==-- From vszocs at redhat.com Wed Jun 19 09:19:45 2013 Content-Type: multipart/mixed; boundary="===============3836397454775346360==" MIME-Version: 1.0 From: Vojtech Szocs To: devel at ovirt.org Subject: Re: [Engine-devel] IE9 Issue with UI Plugin Date: Wed, 19 Jun 2013 09:19:44 -0400 Message-ID: <505179704.20246859.1371647984316.JavaMail.root@redhat.com> In-Reply-To: 1796208617.20183450.1371635656569.JavaMail.root@redhat.com --===============3836397454775346360== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ------=3D_Part_20246857_85949410.1371647984315 Content-Type: text/plain; charset=3Dutf-8 Content-Transfer-Encoding: 7bit Hi Ricky, you were right, in IE9, postMessage listener (WebAdmin) didn't work properl= y, so I simplified it and verified that it now works in IE9, too: http://ge= rrit.ovirt.org/#/c/15888/ After applying above mentioned patch, everything should work as expected in= IE9. I've also attached "test-plugin" which I used for verification in IE9. Regards, Vojtech ----- Original Message ----- > From: "Vojtech Szocs" > To: "Richard Hopper" > Cc: engine-devel(a)ovirt.org, "Christopher Morrissey" > Sent: Wednesday, June 19, 2013 11:54:16 AM > Subject: Re: [Engine-devel] IE9 Issue with UI Plugin > = > Hi Ricky, > = > code running in the iframe (custom dialog content) can close the dialog in > the following way: > = > 1, send message to your plugin to indicate the dialog needs to be closed: > = > parent.postMessage('CloseMyDialog', '*'); > = > 2, your plugin intercepts the message via MessageReceived function and cl= oses > the dialog: > = > MessageReceived: function(data, sourceWindow) { > switch (data) { > case 'CloseMyDialog': > window.alert('About to close dialog'); > api.closeDialog('my-dialog'); > break; > } > } > = > If the above doesn't work for you, it could mean that: > - MessageReceived function isn't invoked - make sure to have [*] before > api.register() call > - api.closeDialog() function isn't working - in this case I need to fix it > for IE9 > = > [*] accept message events from iframe (custom dialog content) origin > = > api.options({ > allowedMessageOrigins: 'http://nicedomain:8080' > /* OR */ > allowedMessageOrigins: ['http://nicedomain1:123', > 'https://nicedomain2:345'] > }); > = > I'm going to investigate this issue on IE9 myself to see if the above cod= e is > really working there. > = > Vojtech > = > = > ----- Original Message ----- > > From: "Richard Hopper" > > To: "Vojtech Szocs" > > Cc: engine-devel(a)ovirt.org, "Christopher Morrissey" > > > > Sent: Monday, June 17, 2013 8:16:03 PM > > Subject: IE9 Issue with UI Plugin > > = > > Hi Vojtech, > > = > > I had previously sent you an email about IE9 compatibility where the > > problem > > we were having was solved by omitting console logging when a console was > > unavailable (i.e. IE). However, it is looking like IE9 may have a bigger > > issue with regards to the plugin framework. > > = > > Now that we have gotten dialogs to open via dynamically inserted buttons > > within RHEV tabs (for example, a NetApp button in the Storage tab), we = can > > go through our whole process with the exception of closing the window. = In > > all other browsers, our dialog will close as expected, but in IE the wi= ndow > > remains open. It can be closed by hitting the red "x" in the corner, bu= t it > > appears the code in the frame itself cannot close the window, with a > > console > > message in the dev tools of IE9 showing an error of "'Math' is undefine= d". > > I've read up on this, and it seems like this is a very widespread error= in > > Internet Explorer concerning the manner/order in which iframes are > > dynamically inserted. > > = > > I've copied engine-devel in case anyone has similar issues/solutions, b= ut > > it > > seems as though we need some sort of clause in the plugin framework for= IE > > when it comes to dynamic insertion of new windows. > > = > > - Ricky Hopper > > = > _______________________________________________ > Engine-devel mailing list > Engine-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > = ------=3D_Part_20246857_85949410.1371647984315 Content-Type: application/x-compressed-tar; name=3Dtest-plugin.tar.gz Content-Disposition: attachment; filename=3Dtest-plugin.tar.gz Content-Transfer-Encoding: base64 H4sIAF2uwVEAA+2XXW/aMBSGuU1+hZeb0AnIN0gsRZraXeyiajV1mnZpEg/chjiKHSib+O+zE6cF tI5JK91Hz3PjOD62j318XieCcNEvCWdVmRDudI6BKxmNoqYchjulpuP53tAN/OEo8DuuF0S+10HR UbzZo+IClwh1lvwrS/jjdofa/1HEbvzVZojBXCyyJ5xDBXgYho/F33OD4X38/ZEn4x9FodtB7hP6 8CgvPP7xq/PLs+vPV++QCvrEjNuC4HQSO3VhxlOWrmXBk5IWAol1QU5tQe6Ec4OXuHlrT0zTWMqt xAVFp6jAJcnFoMiqGc3fFrRrq5Nmn7yRVtJiwApBWc6730zDwFnGViS9IJzjGbksqezCx8h+bZvG 5r5HSWaUC1LKLrLPR/o+p2KMvlR5okbqniA1VG3J52x1TnHGZl37Ws6KmordQ7UT/VRXlb1hOysy xemC5g8PjdeOMnYa437CcqEWpLan7Rm6bnGnRg3qB+mpYWx6yju9lA8kIXRJ0i03UyxwDzXp9onm KVtpx/mKimSOagP9ykgwJ8g+yxgnF2u9iHHdUq8zUQ3tQrdXVnsimZYE39bPG+WaubudOF13VTV2 mghO1KOOtNMcgz99OoFjs6f/Pzjtvz/HAf13w3C0pf+B1H/5FeCB/j8HP9X/X1D8VtjQthg1+rWq 5W3Q3gSMCy2L3T1J6ympV5q12RajvcvHjIuJWat5c0aRPqPSrtCtMc2LSjtrTSshWG6hJc4qWa1n 1BeBhVieZDS5PbV2vLaQM2mHeylCqPJ/cMNZfsQ5DuW/F4U6/10/8kYy//1A/i5A/j8DMlGtHC+I NUaWOguW/LaxqjJT9QNfRg//CnWn9hK5wmLejvZws1jm5v9NIgAAAAAAAAAAAAAAAAAAAAAAgL+I 733qUgIAKAAA ------=3D_Part_20246857_85949410.1371647984315-- --===============3836397454775346360== Content-Type: multipart/mixed MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.bin" LS0tLS0tPV9QYXJ0XzIwMjQ2ODU3Xzg1OTQ5NDEwLjEzNzE2NDc5ODQzMTUKQ29udGVudC1UeXBl OiB0ZXh0L3BsYWluOyBjaGFyc2V0PXV0Zi04CkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IDdi aXQKCkhpIFJpY2t5LAoKeW91IHdlcmUgcmlnaHQsIGluIElFOSwgcG9zdE1lc3NhZ2UgbGlzdGVu ZXIgKFdlYkFkbWluKSBkaWRuJ3Qgd29yayBwcm9wZXJseSwgc28gSSBzaW1wbGlmaWVkIGl0IGFu ZCB2ZXJpZmllZCB0aGF0IGl0IG5vdyB3b3JrcyBpbiBJRTksIHRvbzogaHR0cDovL2dlcnJpdC5v dmlydC5vcmcvIy9jLzE1ODg4LwoKQWZ0ZXIgYXBwbHlpbmcgYWJvdmUgbWVudGlvbmVkIHBhdGNo LCBldmVyeXRoaW5nIHNob3VsZCB3b3JrIGFzIGV4cGVjdGVkIGluIElFOS4gSSd2ZSBhbHNvIGF0 dGFjaGVkICJ0ZXN0LXBsdWdpbiIgd2hpY2ggSSB1c2VkIGZvciB2ZXJpZmljYXRpb24gaW4gSUU5 LgoKUmVnYXJkcywKVm9qdGVjaAoKCi0tLS0tIE9yaWdpbmFsIE1lc3NhZ2UgLS0tLS0KPiBGcm9t OiAiVm9qdGVjaCBTem9jcyIgPHZzem9jc0ByZWRoYXQuY29tPgo+IFRvOiAiUmljaGFyZCBIb3Bw ZXIiIDxSaWNoYXJkLkhvcHBlckBuZXRhcHAuY29tPgo+IENjOiBlbmdpbmUtZGV2ZWxAb3ZpcnQu b3JnLCAiQ2hyaXN0b3BoZXIgTW9ycmlzc2V5IiA8Q2hyaXN0b3BoZXIuTW9ycmlzc2V5QG5ldGFw cC5jb20+Cj4gU2VudDogV2VkbmVzZGF5LCBKdW5lIDE5LCAyMDEzIDExOjU0OjE2IEFNCj4gU3Vi amVjdDogUmU6IFtFbmdpbmUtZGV2ZWxdIElFOSBJc3N1ZSB3aXRoIFVJIFBsdWdpbgo+IAo+IEhp IFJpY2t5LAo+IAo+IGNvZGUgcnVubmluZyBpbiB0aGUgaWZyYW1lIChjdXN0b20gZGlhbG9nIGNv bnRlbnQpIGNhbiBjbG9zZSB0aGUgZGlhbG9nIGluCj4gdGhlIGZvbGxvd2luZyB3YXk6Cj4gCj4g MSwgc2VuZCBtZXNzYWdlIHRvIHlvdXIgcGx1Z2luIHRvIGluZGljYXRlIHRoZSBkaWFsb2cgbmVl ZHMgdG8gYmUgY2xvc2VkOgo+IAo+ICAgICBwYXJlbnQucG9zdE1lc3NhZ2UoJ0Nsb3NlTXlEaWFs b2cnLCAnKicpOwo+IAo+IDIsIHlvdXIgcGx1Z2luIGludGVyY2VwdHMgdGhlIG1lc3NhZ2Ugdmlh IE1lc3NhZ2VSZWNlaXZlZCBmdW5jdGlvbiBhbmQgY2xvc2VzCj4gdGhlIGRpYWxvZzoKPiAKPiAg ICAgTWVzc2FnZVJlY2VpdmVkOiBmdW5jdGlvbihkYXRhLCBzb3VyY2VXaW5kb3cpIHsKPiAgICAg ICAgIHN3aXRjaCAoZGF0YSkgewo+ICAgICAgICAgICAgIGNhc2UgJ0Nsb3NlTXlEaWFsb2cnOgo+ ICAgICAgICAgICAgICAgICB3aW5kb3cuYWxlcnQoJ0Fib3V0IHRvIGNsb3NlIGRpYWxvZycpOwo+ ICAgICAgICAgICAgICAgICBhcGkuY2xvc2VEaWFsb2coJ215LWRpYWxvZycpOwo+ICAgICAgICAg ICAgICAgICBicmVhazsKPiAgICAgICAgIH0KPiAgICAgfQo+IAo+IElmIHRoZSBhYm92ZSBkb2Vz bid0IHdvcmsgZm9yIHlvdSwgaXQgY291bGQgbWVhbiB0aGF0Ogo+IC0gTWVzc2FnZVJlY2VpdmVk IGZ1bmN0aW9uIGlzbid0IGludm9rZWQgLSBtYWtlIHN1cmUgdG8gaGF2ZSBbKl0gYmVmb3JlCj4g YXBpLnJlZ2lzdGVyKCkgY2FsbAo+IC0gYXBpLmNsb3NlRGlhbG9nKCkgZnVuY3Rpb24gaXNuJ3Qg d29ya2luZyAtIGluIHRoaXMgY2FzZSBJIG5lZWQgdG8gZml4IGl0Cj4gZm9yIElFOQo+IAo+IFsq XSBhY2NlcHQgbWVzc2FnZSBldmVudHMgZnJvbSBpZnJhbWUgKGN1c3RvbSBkaWFsb2cgY29udGVu dCkgb3JpZ2luCj4gCj4gICAgIGFwaS5vcHRpb25zKHsKPiAgICAgICAgIGFsbG93ZWRNZXNzYWdl T3JpZ2luczogJ2h0dHA6Ly9uaWNlZG9tYWluOjgwODAnCj4gICAgICAgICAvKiBPUiAqLwo+ICAg ICAgICAgYWxsb3dlZE1lc3NhZ2VPcmlnaW5zOiBbJ2h0dHA6Ly9uaWNlZG9tYWluMToxMjMnLAo+ ICAgICAgICAgJ2h0dHBzOi8vbmljZWRvbWFpbjI6MzQ1J10KPiAgICAgfSk7Cj4gCj4gSSdtIGdv aW5nIHRvIGludmVzdGlnYXRlIHRoaXMgaXNzdWUgb24gSUU5IG15c2VsZiB0byBzZWUgaWYgdGhl IGFib3ZlIGNvZGUgaXMKPiByZWFsbHkgd29ya2luZyB0aGVyZS4KPiAKPiBWb2p0ZWNoCj4gCj4g Cj4gLS0tLS0gT3JpZ2luYWwgTWVzc2FnZSAtLS0tLQo+ID4gRnJvbTogIlJpY2hhcmQgSG9wcGVy IiA8UmljaGFyZC5Ib3BwZXJAbmV0YXBwLmNvbT4KPiA+IFRvOiAiVm9qdGVjaCBTem9jcyIgPHZz em9jc0ByZWRoYXQuY29tPgo+ID4gQ2M6IGVuZ2luZS1kZXZlbEBvdmlydC5vcmcsICJDaHJpc3Rv cGhlciBNb3JyaXNzZXkiCj4gPiA8Q2hyaXN0b3BoZXIuTW9ycmlzc2V5QG5ldGFwcC5jb20+Cj4g PiBTZW50OiBNb25kYXksIEp1bmUgMTcsIDIwMTMgODoxNjowMyBQTQo+ID4gU3ViamVjdDogSUU5 IElzc3VlIHdpdGggVUkgUGx1Z2luCj4gPiAKPiA+IEhpIFZvanRlY2gsCj4gPiAKPiA+IEkgaGFk IHByZXZpb3VzbHkgc2VudCB5b3UgYW4gZW1haWwgYWJvdXQgSUU5IGNvbXBhdGliaWxpdHkgd2hl cmUgdGhlCj4gPiBwcm9ibGVtCj4gPiB3ZSB3ZXJlIGhhdmluZyB3YXMgc29sdmVkIGJ5IG9taXR0 aW5nIGNvbnNvbGUgbG9nZ2luZyB3aGVuIGEgY29uc29sZSB3YXMKPiA+IHVuYXZhaWxhYmxlIChp LmUuIElFKS4gSG93ZXZlciwgaXQgaXMgbG9va2luZyBsaWtlIElFOSBtYXkgaGF2ZSBhIGJpZ2dl cgo+ID4gaXNzdWUgd2l0aCByZWdhcmRzIHRvIHRoZSBwbHVnaW4gZnJhbWV3b3JrLgo+ID4gCj4g PiBOb3cgdGhhdCB3ZSBoYXZlIGdvdHRlbiBkaWFsb2dzIHRvIG9wZW4gdmlhIGR5bmFtaWNhbGx5 IGluc2VydGVkIGJ1dHRvbnMKPiA+IHdpdGhpbiBSSEVWIHRhYnMgKGZvciBleGFtcGxlLCBhIE5l dEFwcCBidXR0b24gaW4gdGhlIFN0b3JhZ2UgdGFiKSwgd2UgY2FuCj4gPiBnbyB0aHJvdWdoIG91 ciB3aG9sZSBwcm9jZXNzIHdpdGggdGhlIGV4Y2VwdGlvbiBvZiBjbG9zaW5nIHRoZSB3aW5kb3cu IEluCj4gPiBhbGwgb3RoZXIgYnJvd3NlcnMsIG91ciBkaWFsb2cgd2lsbCBjbG9zZSBhcyBleHBl Y3RlZCwgYnV0IGluIElFIHRoZSB3aW5kb3cKPiA+IHJlbWFpbnMgb3Blbi4gSXQgY2FuIGJlIGNs b3NlZCBieSBoaXR0aW5nIHRoZSByZWQgIngiIGluIHRoZSBjb3JuZXIsIGJ1dCBpdAo+ID4gYXBw ZWFycyB0aGUgY29kZSBpbiB0aGUgZnJhbWUgaXRzZWxmIGNhbm5vdCBjbG9zZSB0aGUgd2luZG93 LCB3aXRoIGEKPiA+IGNvbnNvbGUKPiA+IG1lc3NhZ2UgaW4gdGhlIGRldiB0b29scyBvZiBJRTkg c2hvd2luZyBhbiBlcnJvciBvZiAiJ01hdGgnIGlzIHVuZGVmaW5lZCIuCj4gPiBJJ3ZlIHJlYWQg dXAgb24gdGhpcywgYW5kIGl0IHNlZW1zIGxpa2UgdGhpcyBpcyBhIHZlcnkgd2lkZXNwcmVhZCBl cnJvciBpbgo+ID4gSW50ZXJuZXQgRXhwbG9yZXIgY29uY2VybmluZyB0aGUgbWFubmVyL29yZGVy IGluIHdoaWNoIGlmcmFtZXMgYXJlCj4gPiBkeW5hbWljYWxseSBpbnNlcnRlZC4KPiA+IAo+ID4g SSd2ZSBjb3BpZWQgZW5naW5lLWRldmVsIGluIGNhc2UgYW55b25lIGhhcyBzaW1pbGFyIGlzc3Vl cy9zb2x1dGlvbnMsIGJ1dAo+ID4gaXQKPiA+IHNlZW1zIGFzIHRob3VnaCB3ZSBuZWVkIHNvbWUg c29ydCBvZiBjbGF1c2UgaW4gdGhlIHBsdWdpbiBmcmFtZXdvcmsgZm9yIElFCj4gPiB3aGVuIGl0 IGNvbWVzIHRvIGR5bmFtaWMgaW5zZXJ0aW9uIG9mIG5ldyB3aW5kb3dzLgo+ID4gCj4gPiAtIFJp Y2t5IEhvcHBlcgo+ID4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KPiBFbmdpbmUtZGV2ZWwgbWFpbGluZyBsaXN0Cj4gRW5naW5lLWRldmVsQG92aXJ0 Lm9yZwo+IGh0dHA6Ly9saXN0cy5vdmlydC5vcmcvbWFpbG1hbi9saXN0aW5mby9lbmdpbmUtZGV2 ZWwKPiAKCi0tLS0tLT1fUGFydF8yMDI0Njg1N184NTk0OTQxMC4xMzcxNjQ3OTg0MzE1CkNvbnRl bnQtVHlwZTogYXBwbGljYXRpb24veC1jb21wcmVzc2VkLXRhcjsgbmFtZT10ZXN0LXBsdWdpbi50 YXIuZ3oKQ29udGVudC1EaXNwb3NpdGlvbjogYXR0YWNobWVudDsgZmlsZW5hbWU9dGVzdC1wbHVn aW4udGFyLmd6CkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IGJhc2U2NAoKSDRzSUFGMnV3VkVB QSsyWFhXL2FNQlNHdVUxK2haZWIwQW5JTjBnc1JacmFYZXlpYWpWMW1uWnBFZy9jaGppS0hTaWIr Tyt6RTZjRgp0STVKSzkxSHozUGpPRDYyajMxOFhpZUNjTkV2Q1dkVm1SRHVkSTZCS3htTm9xWWNo anVscHVQNTN0QU4vT0VvOER1dUYwUysxMEhSClVielpvK0lDbHdoMWx2d3JTL2pqZG9mYS8xSEVi dnpWWm9qQlhDeXlKNXhEQlhnWWhvL0YzM09ENFgzOC9aRW40eDlGb2R0QjdoUDYKOENndlBQN3hx L1BMcyt2UFYrK1FDdnJFak51QzRIUVNPM1ZoeGxPV3JtWEJrNUlXQW9sMVFVNXRRZTZFYzRPWHVI bHJUMHpUV01xdAp4QVZGcDZqQUpjbkZvTWlxR2MzZkZyUnJxNU5tbjd5UlZ0Sml3QXBCV2M2NzMw ekR3Rm5HVmlTOUlKempHYmtzcWV6Q3g4aCtiWnZHCjVyNUhTV2FVQzFMS0xyTFBSL28rcDJLTXZs UjVva2JxbmlBMVZHM0o1MngxVG5IR1psMzdXczZLbW9yZFE3VVQvVlJYbGIxaE95c3kKeGVtQzVn OFBqZGVPTW5ZYTQzN0NjcUVXcExhbjdSbTZibkduUmczcUIrbXBZV3g2eWp1OWxBOGtJWFJKMGkw M1V5eHdEelhwOW9ubQpLVnRweC9tS2ltU09hZ1A5eWtnd0o4Zyt5eGduRjJ1OWlISGRVcTh6VVEz dFFyZFhWbnNpbVpZRTM5YlBHK1dhdWJ1ZE9GMTNWVFYyCm1naE8xS09PdE5NY2d6OTlPb0ZqczZm L1B6anR2ei9IQWYxM3czQzBwZitCMUgvNUZlQ0IvajhIUDlYL1gxRDhWdGpRdGhnMStyV3EKNVcz UTNnU01DeTJMM1QxSjZ5bXBWNXExMlJhanZjdkhqSXVKV2F0NWMwYVJQcVBTcnRDdE1jMkxTanRy VFNzaFdHNmhKYzRxV2ExbgoxQmVCaFZpZVpEUzVQYlYydkxhUU0ybUhleWxDcVBKL2NNTlpmc1E1 RHVXL0Y0VTYvMTAvOGtZeS8vMUEvaTVBL2o4RE1sR3RIQytJCk5VYVdPZ3VXL0xheHFqSlQ5UU5m UmcvL0NuV245aEs1d21MZWp2WndzMWptNXY5TklnQUFBQUFBQUFBQUFBQUFBQUFBQUFBQWdMK0kK NzMzcVVnSUFLQUFBCi0tLS0tLT1fUGFydF8yMDI0Njg1N184NTk0OTQxMC4xMzcxNjQ3OTg0MzE1 LS0K --===============3836397454775346360==-- From Christopher.Morrissey at netapp.com Wed Jun 19 10:44:09 2013 Content-Type: multipart/mixed; boundary="===============7960304558541719054==" MIME-Version: 1.0 From: Morrissey, Christopher To: devel at ovirt.org Subject: Re: [Engine-devel] IE9 Issue with UI Plugin Date: Wed, 19 Jun 2013 14:44:08 +0000 Message-ID: In-Reply-To: 1796208617.20183450.1371635656569.JavaMail.root@redhat.com --===============7960304558541719054== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Thanks for the patch, Vojtech. I'm testing it out now. -Chris > -----Original Message----- > From: Vojtech Szocs [mailto:vszocs(a)redhat.com] > Sent: Wednesday, June 19, 2013 5:54 AM > To: Hopper, Richard > Cc: engine-devel(a)ovirt.org; Morrissey, Christopher > Subject: Re: IE9 Issue with UI Plugin > = > Hi Ricky, > = > code running in the iframe (custom dialog content) can close the dialog i= n the > following way: > = > 1, send message to your plugin to indicate the dialog needs to be closed: > = > parent.postMessage('CloseMyDialog', '*'); > = > 2, your plugin intercepts the message via MessageReceived function and > closes the dialog: > = > MessageReceived: function(data, sourceWindow) { > switch (data) { > case 'CloseMyDialog': > window.alert('About to close dialog'); > api.closeDialog('my-dialog'); > break; > } > } > = > If the above doesn't work for you, it could mean that: > - MessageReceived function isn't invoked - make sure to have [*] before > api.register() call > - api.closeDialog() function isn't working - in this case I need to fix i= t for IE9 > = > [*] accept message events from iframe (custom dialog content) origin > = > api.options({ > allowedMessageOrigins: 'http://nicedomain:8080' > /* OR */ > allowedMessageOrigins: ['http://nicedomain1:123', > 'https://nicedomain2:345'] > }); > = > I'm going to investigate this issue on IE9 myself to see if the above cod= e is > really working there. > = > Vojtech > = > = > ----- Original Message ----- > > From: "Richard Hopper" > > To: "Vojtech Szocs" > > Cc: engine-devel(a)ovirt.org, "Christopher Morrissey" > > > > Sent: Monday, June 17, 2013 8:16:03 PM > > Subject: IE9 Issue with UI Plugin > > > > Hi Vojtech, > > > > I had previously sent you an email about IE9 compatibility where the > > problem we were having was solved by omitting console logging when a > > console was unavailable (i.e. IE). However, it is looking like IE9 may > > have a bigger issue with regards to the plugin framework. > > > > Now that we have gotten dialogs to open via dynamically inserted > > buttons within RHEV tabs (for example, a NetApp button in the Storage > > tab), we can go through our whole process with the exception of > > closing the window. In all other browsers, our dialog will close as > > expected, but in IE the window remains open. It can be closed by > > hitting the red "x" in the corner, but it appears the code in the > > frame itself cannot close the window, with a console message in the dev > tools of IE9 showing an error of "'Math' is undefined". > > I've read up on this, and it seems like this is a very widespread > > error in Internet Explorer concerning the manner/order in which > > iframes are dynamically inserted. > > > > I've copied engine-devel in case anyone has similar issues/solutions, > > but it seems as though we need some sort of clause in the plugin > > framework for IE when it comes to dynamic insertion of new windows. > > > > - Ricky Hopper > > --===============7960304558541719054==-- From Richard.Hopper at netapp.com Wed Jun 19 15:39:52 2013 Content-Type: multipart/mixed; boundary="===============2186063389511366060==" MIME-Version: 1.0 From: Hopper, Richard To: devel at ovirt.org Subject: Re: [Engine-devel] IE9 Issue with UI Plugin Date: Wed, 19 Jun 2013 19:39:50 +0000 Message-ID: In-Reply-To: 505179704.20246859.1371647984316.JavaMail.root@redhat.com --===============2186063389511366060== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Vojtech, I've tested the new patch and for some reason am still running into problems, though there are different exceptions now. I'll let you know if we figure out what specifically is going on. It does work if dev tools are up, but if there are no developer tools available the window will still not close. - Ricky On 6/19/13 9:19 AM, "Vojtech Szocs" wrote: >Hi Ricky, > >you were right, in IE9, postMessage listener (WebAdmin) didn't work >properly, so I simplified it and verified that it now works in IE9, too: >http://gerrit.ovirt.org/#/c/15888/ > >After applying above mentioned patch, everything should work as expected >in IE9. I've also attached "test-plugin" which I used for verification in >IE9. > >Regards, >Vojtech > > >----- Original Message ----- >> From: "Vojtech Szocs" >> To: "Richard Hopper" >> Cc: engine-devel(a)ovirt.org, "Christopher Morrissey" >> >> Sent: Wednesday, June 19, 2013 11:54:16 AM >> Subject: Re: [Engine-devel] IE9 Issue with UI Plugin >> = >> Hi Ricky, >> = >> code running in the iframe (custom dialog content) can close the dialog >>in >> the following way: >> = >> 1, send message to your plugin to indicate the dialog needs to be >>closed: >> = >> parent.postMessage('CloseMyDialog', '*'); >> = >> 2, your plugin intercepts the message via MessageReceived function and >>closes >> the dialog: >> = >> MessageReceived: function(data, sourceWindow) { >> switch (data) { >> case 'CloseMyDialog': >> window.alert('About to close dialog'); >> api.closeDialog('my-dialog'); >> break; >> } >> } >> = >> If the above doesn't work for you, it could mean that: >> - MessageReceived function isn't invoked - make sure to have [*] before >> api.register() call >> - api.closeDialog() function isn't working - in this case I need to fix >>it >> for IE9 >> = >> [*] accept message events from iframe (custom dialog content) origin >> = >> api.options({ >> allowedMessageOrigins: 'http://nicedomain:8080' >> /* OR */ >> allowedMessageOrigins: ['http://nicedomain1:123', >> 'https://nicedomain2:345'] >> }); >> = >> I'm going to investigate this issue on IE9 myself to see if the above >>code is >> really working there. >> = >> Vojtech >> = >> = >> ----- Original Message ----- >> > From: "Richard Hopper" >> > To: "Vojtech Szocs" >> > Cc: engine-devel(a)ovirt.org, "Christopher Morrissey" >> > >> > Sent: Monday, June 17, 2013 8:16:03 PM >> > Subject: IE9 Issue with UI Plugin >> > = >> > Hi Vojtech, >> > = >> > I had previously sent you an email about IE9 compatibility where the >> > problem >> > we were having was solved by omitting console logging when a console >>was >> > unavailable (i.e. IE). However, it is looking like IE9 may have a >>bigger >> > issue with regards to the plugin framework. >> > = >> > Now that we have gotten dialogs to open via dynamically inserted >>buttons >> > within RHEV tabs (for example, a NetApp button in the Storage tab), >>we can >> > go through our whole process with the exception of closing the >>window. In >> > all other browsers, our dialog will close as expected, but in IE the >>window >> > remains open. It can be closed by hitting the red "x" in the corner, >>but it >> > appears the code in the frame itself cannot close the window, with a >> > console >> > message in the dev tools of IE9 showing an error of "'Math' is >>undefined". >> > I've read up on this, and it seems like this is a very widespread >>error in >> > Internet Explorer concerning the manner/order in which iframes are >> > dynamically inserted. >> > = >> > I've copied engine-devel in case anyone has similar issues/solutions, >>but >> > it >> > seems as though we need some sort of clause in the plugin framework >>for IE >> > when it comes to dynamic insertion of new windows. >> > = >> > - Ricky Hopper >> > = >> _______________________________________________ >> Engine-devel mailing list >> Engine-devel(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/engine-devel >> = --===============2186063389511366060==-- From vszocs at redhat.com Fri Jun 28 11:10:36 2013 Content-Type: multipart/mixed; boundary="===============4134363356890735083==" MIME-Version: 1.0 From: Vojtech Szocs To: devel at ovirt.org Subject: Re: [Engine-devel] IE9 Issue with UI Plugin Date: Fri, 28 Jun 2013 11:10:34 -0400 Message-ID: <1386820619.3136967.1372432234517.JavaMail.root@redhat.com> In-Reply-To: CDE780A4.56D4%rickyh@netapp.com --===============4134363356890735083== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Ricky, did you manage to solve the issue related with IE dev tools? If there are s= till issues pointing to UI plugin infrastructure, please let me know. Regards, Vojtech ----- Original Message ----- > From: "Richard Hopper" > To: "Vojtech Szocs" > Cc: engine-devel(a)ovirt.org, "Christopher Morrissey" > Sent: Wednesday, June 19, 2013 9:39:50 PM > Subject: Re: [Engine-devel] IE9 Issue with UI Plugin > = > Hi Vojtech, > = > I've tested the new patch and for some reason am still running into > problems, though there are different exceptions now. I'll let you know if > we figure out what specifically is going on. It does work if dev tools are > up, but if there are no developer tools available the window will still > not close. > = > - Ricky > = > On 6/19/13 9:19 AM, "Vojtech Szocs" wrote: > = > >Hi Ricky, > > > >you were right, in IE9, postMessage listener (WebAdmin) didn't work > >properly, so I simplified it and verified that it now works in IE9, too: > >http://gerrit.ovirt.org/#/c/15888/ > > > >After applying above mentioned patch, everything should work as expected > >in IE9. I've also attached "test-plugin" which I used for verification in > >IE9. > > > >Regards, > >Vojtech > > > > > >----- Original Message ----- > >> From: "Vojtech Szocs" > >> To: "Richard Hopper" > >> Cc: engine-devel(a)ovirt.org, "Christopher Morrissey" > >> > >> Sent: Wednesday, June 19, 2013 11:54:16 AM > >> Subject: Re: [Engine-devel] IE9 Issue with UI Plugin > >> = > >> Hi Ricky, > >> = > >> code running in the iframe (custom dialog content) can close the dialog > >>in > >> the following way: > >> = > >> 1, send message to your plugin to indicate the dialog needs to be > >>closed: > >> = > >> parent.postMessage('CloseMyDialog', '*'); > >> = > >> 2, your plugin intercepts the message via MessageReceived function and > >>closes > >> the dialog: > >> = > >> MessageReceived: function(data, sourceWindow) { > >> switch (data) { > >> case 'CloseMyDialog': > >> window.alert('About to close dialog'); > >> api.closeDialog('my-dialog'); > >> break; > >> } > >> } > >> = > >> If the above doesn't work for you, it could mean that: > >> - MessageReceived function isn't invoked - make sure to have [*] before > >> api.register() call > >> - api.closeDialog() function isn't working - in this case I need to fix > >>it > >> for IE9 > >> = > >> [*] accept message events from iframe (custom dialog content) origin > >> = > >> api.options({ > >> allowedMessageOrigins: 'http://nicedomain:8080' > >> /* OR */ > >> allowedMessageOrigins: ['http://nicedomain1:123', > >> 'https://nicedomain2:345'] > >> }); > >> = > >> I'm going to investigate this issue on IE9 myself to see if the above > >>code is > >> really working there. > >> = > >> Vojtech > >> = > >> = > >> ----- Original Message ----- > >> > From: "Richard Hopper" > >> > To: "Vojtech Szocs" > >> > Cc: engine-devel(a)ovirt.org, "Christopher Morrissey" > >> > > >> > Sent: Monday, June 17, 2013 8:16:03 PM > >> > Subject: IE9 Issue with UI Plugin > >> > = > >> > Hi Vojtech, > >> > = > >> > I had previously sent you an email about IE9 compatibility where the > >> > problem > >> > we were having was solved by omitting console logging when a console > >>was > >> > unavailable (i.e. IE). However, it is looking like IE9 may have a > >>bigger > >> > issue with regards to the plugin framework. > >> > = > >> > Now that we have gotten dialogs to open via dynamically inserted > >>buttons > >> > within RHEV tabs (for example, a NetApp button in the Storage tab), > >>we can > >> > go through our whole process with the exception of closing the > >>window. In > >> > all other browsers, our dialog will close as expected, but in IE the > >>window > >> > remains open. It can be closed by hitting the red "x" in the corner, > >>but it > >> > appears the code in the frame itself cannot close the window, with a > >> > console > >> > message in the dev tools of IE9 showing an error of "'Math' is > >>undefined". > >> > I've read up on this, and it seems like this is a very widespread > >>error in > >> > Internet Explorer concerning the manner/order in which iframes are > >> > dynamically inserted. > >> > = > >> > I've copied engine-devel in case anyone has similar issues/solutions, > >>but > >> > it > >> > seems as though we need some sort of clause in the plugin framework > >>for IE > >> > when it comes to dynamic insertion of new windows. > >> > = > >> > - Ricky Hopper > >> > = > >> _______________________________________________ > >> Engine-devel mailing list > >> Engine-devel(a)ovirt.org > >> http://lists.ovirt.org/mailman/listinfo/engine-devel > >> = > = >=20 --===============4134363356890735083==-- From Richard.Hopper at netapp.com Fri Jun 28 13:24:59 2013 Content-Type: multipart/mixed; boundary="===============7611555711654144447==" MIME-Version: 1.0 From: Hopper, Richard To: devel at ovirt.org Subject: Re: [Engine-devel] IE9 Issue with UI Plugin Date: Fri, 28 Jun 2013 17:24:57 +0000 Message-ID: In-Reply-To: 1386820619.3136967.1372432234517.JavaMail.root@redhat.com --===============7611555711654144447== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Vojtech, It actually turned out that our particular problem was hidden within our code, so once we found it, the plugin worked fine with IE9. It was actually related to the lack of console in the browser as well, I just didn't realize we called native javascript in multiple places. It seems that the plugin architecture's compatibility with IE9 is quite solid. Thank you once again! - Ricky On 6/28/13 11:10 AM, "Vojtech Szocs" wrote: >Hi Ricky, > >did you manage to solve the issue related with IE dev tools? If there are >still issues pointing to UI plugin infrastructure, please let me know. > >Regards, >Vojtech > > >----- Original Message ----- >> From: "Richard Hopper" >> To: "Vojtech Szocs" >> Cc: engine-devel(a)ovirt.org, "Christopher Morrissey" >> >> Sent: Wednesday, June 19, 2013 9:39:50 PM >> Subject: Re: [Engine-devel] IE9 Issue with UI Plugin >> = >> Hi Vojtech, >> = >> I've tested the new patch and for some reason am still running into >> problems, though there are different exceptions now. I'll let you know >>if >> we figure out what specifically is going on. It does work if dev tools >>are >> up, but if there are no developer tools available the window will still >> not close. >> = >> - Ricky >> = >> On 6/19/13 9:19 AM, "Vojtech Szocs" wrote: >> = >> >Hi Ricky, >> > >> >you were right, in IE9, postMessage listener (WebAdmin) didn't work >> >properly, so I simplified it and verified that it now works in IE9, >>too: >> >http://gerrit.ovirt.org/#/c/15888/ >> > >> >After applying above mentioned patch, everything should work as >>expected >> >in IE9. I've also attached "test-plugin" which I used for verification >>in >> >IE9. >> > >> >Regards, >> >Vojtech >> > >> > >> >----- Original Message ----- >> >> From: "Vojtech Szocs" >> >> To: "Richard Hopper" >> >> Cc: engine-devel(a)ovirt.org, "Christopher Morrissey" >> >> >> >> Sent: Wednesday, June 19, 2013 11:54:16 AM >> >> Subject: Re: [Engine-devel] IE9 Issue with UI Plugin >> >> = >> >> Hi Ricky, >> >> = >> >> code running in the iframe (custom dialog content) can close the >>dialog >> >>in >> >> the following way: >> >> = >> >> 1, send message to your plugin to indicate the dialog needs to be >> >>closed: >> >> = >> >> parent.postMessage('CloseMyDialog', '*'); >> >> = >> >> 2, your plugin intercepts the message via MessageReceived function >>and >> >>closes >> >> the dialog: >> >> = >> >> MessageReceived: function(data, sourceWindow) { >> >> switch (data) { >> >> case 'CloseMyDialog': >> >> window.alert('About to close dialog'); >> >> api.closeDialog('my-dialog'); >> >> break; >> >> } >> >> } >> >> = >> >> If the above doesn't work for you, it could mean that: >> >> - MessageReceived function isn't invoked - make sure to have [*] >>before >> >> api.register() call >> >> - api.closeDialog() function isn't working - in this case I need to >>fix >> >>it >> >> for IE9 >> >> = >> >> [*] accept message events from iframe (custom dialog content) origin >> >> = >> >> api.options({ >> >> allowedMessageOrigins: 'http://nicedomain:8080' >> >> /* OR */ >> >> allowedMessageOrigins: ['http://nicedomain1:123', >> >> 'https://nicedomain2:345'] >> >> }); >> >> = >> >> I'm going to investigate this issue on IE9 myself to see if the above >> >>code is >> >> really working there. >> >> = >> >> Vojtech >> >> = >> >> = >> >> ----- Original Message ----- >> >> > From: "Richard Hopper" >> >> > To: "Vojtech Szocs" >> >> > Cc: engine-devel(a)ovirt.org, "Christopher Morrissey" >> >> > >> >> > Sent: Monday, June 17, 2013 8:16:03 PM >> >> > Subject: IE9 Issue with UI Plugin >> >> > = >> >> > Hi Vojtech, >> >> > = >> >> > I had previously sent you an email about IE9 compatibility where >>the >> >> > problem >> >> > we were having was solved by omitting console logging when a >>console >> >>was >> >> > unavailable (i.e. IE). However, it is looking like IE9 may have a >> >>bigger >> >> > issue with regards to the plugin framework. >> >> > = >> >> > Now that we have gotten dialogs to open via dynamically inserted >> >>buttons >> >> > within RHEV tabs (for example, a NetApp button in the Storage tab), >> >>we can >> >> > go through our whole process with the exception of closing the >> >>window. In >> >> > all other browsers, our dialog will close as expected, but in IE >>the >> >>window >> >> > remains open. It can be closed by hitting the red "x" in the >>corner, >> >>but it >> >> > appears the code in the frame itself cannot close the window, with >>a >> >> > console >> >> > message in the dev tools of IE9 showing an error of "'Math' is >> >>undefined". >> >> > I've read up on this, and it seems like this is a very widespread >> >>error in >> >> > Internet Explorer concerning the manner/order in which iframes are >> >> > dynamically inserted. >> >> > = >> >> > I've copied engine-devel in case anyone has similar >>issues/solutions, >> >>but >> >> > it >> >> > seems as though we need some sort of clause in the plugin framework >> >>for IE >> >> > when it comes to dynamic insertion of new windows. >> >> > = >> >> > - Ricky Hopper >> >> > = >> >> _______________________________________________ >> >> Engine-devel mailing list >> >> Engine-devel(a)ovirt.org >> >> http://lists.ovirt.org/mailman/listinfo/engine-devel >> >> = >> = >> = >_______________________________________________ >Engine-devel mailing list >Engine-devel(a)ovirt.org >http://lists.ovirt.org/mailman/listinfo/engine-devel --===============7611555711654144447==--