From fromani at redhat.com Wed Feb 22 15:59:09 2017 Content-Type: multipart/mixed; boundary="===============6050603790128189705==" MIME-Version: 1.0 From: Francesco Romani To: devel at ovirt.org Subject: Re: [ovirt-devel] [monitoring][collectd] the collectd virt plugin is now on par with Vdsm needs Date: Wed, 22 Feb 2017 16:59:06 +0100 Message-ID: In-Reply-To: CAJgorsZGMc7n6h9PGH5YK__1WoA1g7mVv1X1EjtNWphn4y+=hA@mail.gmail.com --===============6050603790128189705== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable This is a multi-part message in MIME format. --------------0BFADDC735FF94D5E8A0931A Content-Type: text/plain; charset=3Dutf-8 Content-Transfer-Encoding: 7bit On 02/21/2017 02:44 PM, Yaniv Kaul wrote: > > > On Tue, Feb 21, 2017 at 1:06 PM Francesco Romani > wrote: > > Hello everyone, > > > in the last weeks I've been submitting PRs to collectd upstream, to > bring the virt plugin up to date with Vdsm and oVirt needs. > > Previously, the collectd virt plugin reported only a subset of metrics > oVirt uses. > > In current collectd master, the collectd virt plugin provides all the > data Vdsm (thus Engine) needs. This means that it is now > > possible for Vdsm or Engine to query collectd, not Vdsm/libvirt, and > have the same data. > > > Do we wish to ship the unixsock collectd plugin? I'm not sure we do > these days (4.1). > We can do that later, of course, when we ship this. > Y. > AFAIR the collectd unixsock plugin it's built and shipped by default by the collectd (even RPMs). It is the way the command line `collectdctl` too uses to talk with the daemon. Our client module is still work in progress. I'd be happy to just use a third party client module, the (semi-)official one is not shipped by default last time I checked; perhaps just file one RFE about that? -- = Francesco Romani Red Hat Engineering Virtualization R & D IRC: fromani --------------0BFADDC735FF94D5E8A0931A Content-Type: text/html; charset=3Dutf-8 Content-Transfer-Encoding: 7bit On 02/21/2017 02:44 PM, Yaniv Kaul wrote:


On Tue, Feb 21, 2017 at 1:06 PM Francesco Romani <fromani(a)redhat.com= > wrote:
Hello everyone,


in the last weeks I've been submitting PRs to collectd upstream, to
bring the virt plugin up to date with Vdsm and oVirt needs.

Previously, the collectd virt plugin reported only a subset of metrics
oVirt uses.

In current collectd master, the collectd virt plugin provides all the
data Vdsm (thus Engine) needs. This means that it is now

possible for Vdsm or Engine to query collectd, not Vdsm/libvirt, and
have the same data.

Do we wish to ship the unixsock collectd plugin? I'm not sure we do these days (4.1).
We can do that later, of course, when we ship this.
Y.


AFAIR the collectd unixsock plugin it's built and shipped by default by the collectd (even RPMs). It is the way the command line `collectdctl` too uses to talk with the daemon.

Our client module is still work in progress.

I'd be happy to just use a third party client module, the (semi-)official one is not shipped by default last time I checked; perhaps just file one RFE about that?

-- =

Francesco Romani
Red Hat Engineering Virtualization R & D
IRC: fromani
--------------0BFADDC735FF94D5E8A0931A-- --===============6050603790128189705== Content-Type: multipart/alternative MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.bin" VGhpcyBpcyBhIG11bHRpLXBhcnQgbWVzc2FnZSBpbiBNSU1FIGZvcm1hdC4KLS0tLS0tLS0tLS0t LS0wQkZBRERDNzM1RkY5NEQ1RThBMDkzMUEKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFy c2V0PXV0Zi04CkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IDdiaXQKCk9uIDAyLzIxLzIwMTcg MDI6NDQgUE0sIFlhbml2IEthdWwgd3JvdGU6Cj4KPgo+IE9uIFR1ZSwgRmViIDIxLCAyMDE3IGF0 IDE6MDYgUE0gRnJhbmNlc2NvIFJvbWFuaSA8ZnJvbWFuaUByZWRoYXQuY29tCj4gPG1haWx0bzpm cm9tYW5pQHJlZGhhdC5jb20+PiB3cm90ZToKPgo+ICAgICBIZWxsbyBldmVyeW9uZSwKPgo+Cj4g ICAgIGluIHRoZSBsYXN0IHdlZWtzIEkndmUgYmVlbiBzdWJtaXR0aW5nIFBScyB0byBjb2xsZWN0 ZCB1cHN0cmVhbSwgdG8KPiAgICAgYnJpbmcgdGhlIHZpcnQgcGx1Z2luIHVwIHRvIGRhdGUgd2l0 aCBWZHNtIGFuZCBvVmlydCBuZWVkcy4KPgo+ICAgICBQcmV2aW91c2x5LCB0aGUgY29sbGVjdGQg dmlydCBwbHVnaW4gcmVwb3J0ZWQgb25seSBhIHN1YnNldCBvZiBtZXRyaWNzCj4gICAgIG9WaXJ0 IHVzZXMuCj4KPiAgICAgSW4gY3VycmVudCBjb2xsZWN0ZCBtYXN0ZXIsIHRoZSBjb2xsZWN0ZCB2 aXJ0IHBsdWdpbiBwcm92aWRlcyBhbGwgdGhlCj4gICAgIGRhdGEgVmRzbSAodGh1cyBFbmdpbmUp IG5lZWRzLiBUaGlzIG1lYW5zIHRoYXQgaXQgaXMgbm93Cj4KPiAgICAgcG9zc2libGUgZm9yIFZk c20gb3IgRW5naW5lIHRvIHF1ZXJ5IGNvbGxlY3RkLCBub3QgVmRzbS9saWJ2aXJ0LCBhbmQKPiAg ICAgaGF2ZSB0aGUgc2FtZSBkYXRhLgo+Cj4KPiBEbyB3ZSB3aXNoIHRvIHNoaXAgdGhlIHVuaXhz b2NrIGNvbGxlY3RkIHBsdWdpbj8gSSdtIG5vdCBzdXJlIHdlIGRvCj4gdGhlc2UgZGF5cyAoNC4x KS4KPiBXZSBjYW4gZG8gdGhhdCBsYXRlciwgb2YgY291cnNlLCB3aGVuIHdlIHNoaXAgdGhpcy4K PiBZLgo+CgpBRkFJUiB0aGUgY29sbGVjdGQgdW5peHNvY2sgcGx1Z2luIGl0J3MgYnVpbHQgYW5k IHNoaXBwZWQgYnkgZGVmYXVsdCBieQp0aGUgY29sbGVjdGQgKGV2ZW4gUlBNcykuIEl0IGlzIHRo ZSB3YXkgdGhlIGNvbW1hbmQgbGluZSBgY29sbGVjdGRjdGxgCnRvbyB1c2VzIHRvIHRhbGsgd2l0 aCB0aGUgZGFlbW9uLgoKT3VyIGNsaWVudCBtb2R1bGUgaXMgc3RpbGwgd29yayBpbiBwcm9ncmVz cy4KCkknZCBiZSBoYXBweSB0byBqdXN0IHVzZSBhIHRoaXJkIHBhcnR5IGNsaWVudCBtb2R1bGUs IHRoZQooc2VtaS0pb2ZmaWNpYWwgb25lIGlzIG5vdCBzaGlwcGVkIGJ5IGRlZmF1bHQgbGFzdCB0 aW1lIEkgY2hlY2tlZDsKcGVyaGFwcyBqdXN0IGZpbGUgb25lIFJGRSBhYm91dCB0aGF0PwoKLS0g CkZyYW5jZXNjbyBSb21hbmkKUmVkIEhhdCBFbmdpbmVlcmluZyBWaXJ0dWFsaXphdGlvbiBSICYg RApJUkM6IGZyb21hbmkKCgotLS0tLS0tLS0tLS0tLTBCRkFEREM3MzVGRjk0RDVFOEEwOTMxQQpD b250ZW50LVR5cGU6IHRleHQvaHRtbDsgY2hhcnNldD11dGYtOApDb250ZW50LVRyYW5zZmVyLUVu Y29kaW5nOiA3Yml0Cgo8aHRtbD4KICA8aGVhZD4KICAgIDxtZXRhIGNvbnRlbnQ9InRleHQvaHRt bDsgY2hhcnNldD11dGYtOCIgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIj4KICA8L2hlYWQ+CiAg PGJvZHkgYmdjb2xvcj0iI0ZGRkZGRiIgdGV4dD0iIzAwMDAwMCI+CiAgICBPbiAwMi8yMS8yMDE3 IDAyOjQ0IFBNLCBZYW5pdiBLYXVsIHdyb3RlOjxicj4KICAgIDxibG9ja3F1b3RlCmNpdGU9Im1p ZDpDQUpnb3JzWkdNYzduNmg5UEdINVlLX18xV29BMWc3bVZ2MVgxRWp0TldwaG40eSs9aEFAbWFp bC5nbWFpbC5jb20iCiAgICAgIHR5cGU9ImNpdGUiPgogICAgICA8ZGl2IGRpcj0ibHRyIj48YnI+ CiAgICAgICAgPGJyPgogICAgICAgIDxkaXYgY2xhc3M9ImdtYWlsX3F1b3RlIj4KICAgICAgICAg IDxkaXYgZGlyPSJsdHIiPk9uIFR1ZSwgRmViIDIxLCAyMDE3IGF0IDE6MDYgUE0gRnJhbmNlc2Nv CiAgICAgICAgICAgIFJvbWFuaSAmbHQ7PGEgbW96LWRvLW5vdC1zZW5kPSJ0cnVlIgogICAgICAg ICAgICAgIGhyZWY9Im1haWx0bzpmcm9tYW5pQHJlZGhhdC5jb20iPmZyb21hbmlAcmVkaGF0LmNv bTwvYT4mZ3Q7CiAgICAgICAgICAgIHdyb3RlOjxicj4KICAgICAgICAgIDwvZGl2PgogICAgICAg ICAgPGJsb2NrcXVvdGUgY2xhc3M9ImdtYWlsX3F1b3RlIiBzdHlsZT0ibWFyZ2luOjAgMCAwCiAg ICAgICAgICAgIC44ZXg7Ym9yZGVyLWxlZnQ6MXB4ICNjY2Mgc29saWQ7cGFkZGluZy1sZWZ0OjFl eCI+SGVsbG8KICAgICAgICAgICAgZXZlcnlvbmUsPGJyIGNsYXNzPSJnbWFpbF9tc2ciPgogICAg ICAgICAgICA8YnIgY2xhc3M9ImdtYWlsX21zZyI+CiAgICAgICAgICAgIDxiciBjbGFzcz0iZ21h aWxfbXNnIj4KICAgICAgICAgICAgaW4gdGhlIGxhc3Qgd2Vla3MgSSd2ZSBiZWVuIHN1Ym1pdHRp bmcgUFJzIHRvIGNvbGxlY3RkCiAgICAgICAgICAgIHVwc3RyZWFtLCB0bzxiciBjbGFzcz0iZ21h aWxfbXNnIj4KICAgICAgICAgICAgYnJpbmcgdGhlIHZpcnQgcGx1Z2luIHVwIHRvIGRhdGUgd2l0 aCBWZHNtIGFuZCBvVmlydCBuZWVkcy48YnIKICAgICAgICAgICAgICBjbGFzcz0iZ21haWxfbXNn Ij4KICAgICAgICAgICAgPGJyIGNsYXNzPSJnbWFpbF9tc2ciPgogICAgICAgICAgICBQcmV2aW91 c2x5LCB0aGUgY29sbGVjdGQgdmlydCBwbHVnaW4gcmVwb3J0ZWQgb25seSBhIHN1YnNldAogICAg ICAgICAgICBvZiBtZXRyaWNzPGJyIGNsYXNzPSJnbWFpbF9tc2ciPgogICAgICAgICAgICBvVmly dCB1c2VzLjxiciBjbGFzcz0iZ21haWxfbXNnIj4KICAgICAgICAgICAgPGJyIGNsYXNzPSJnbWFp bF9tc2ciPgogICAgICAgICAgICBJbiBjdXJyZW50IGNvbGxlY3RkIG1hc3RlciwgdGhlIGNvbGxl Y3RkIHZpcnQgcGx1Z2luCiAgICAgICAgICAgIHByb3ZpZGVzIGFsbCB0aGU8YnIgY2xhc3M9Imdt YWlsX21zZyI+CiAgICAgICAgICAgIGRhdGEgVmRzbSAodGh1cyBFbmdpbmUpIG5lZWRzLiBUaGlz IG1lYW5zIHRoYXQgaXQgaXMgbm93PGJyCiAgICAgICAgICAgICAgY2xhc3M9ImdtYWlsX21zZyI+ CiAgICAgICAgICAgIDxiciBjbGFzcz0iZ21haWxfbXNnIj4KICAgICAgICAgICAgcG9zc2libGUg Zm9yIFZkc20gb3IgRW5naW5lIHRvIHF1ZXJ5IGNvbGxlY3RkLCBub3QKICAgICAgICAgICAgVmRz bS9saWJ2aXJ0LCBhbmQ8YnIgY2xhc3M9ImdtYWlsX21zZyI+CiAgICAgICAgICAgIGhhdmUgdGhl IHNhbWUgZGF0YS48YnIgY2xhc3M9ImdtYWlsX21zZyI+CiAgICAgICAgICA8L2Jsb2NrcXVvdGU+ CiAgICAgICAgICA8ZGl2Pjxicj4KICAgICAgICAgIDwvZGl2PgogICAgICAgICAgPGRpdj5EbyB3 ZSB3aXNoIHRvIHNoaXAgdGhlIHVuaXhzb2NrIGNvbGxlY3RkIHBsdWdpbj8gSSdtIG5vdAogICAg ICAgICAgICBzdXJlIHdlIGRvIHRoZXNlIGRheXMgKDQuMSkuPC9kaXY+CiAgICAgICAgICA8ZGl2 PldlIGNhbiBkbyB0aGF0IGxhdGVyLCBvZiBjb3Vyc2UsIHdoZW4gd2Ugc2hpcCB0aGlzLjwvZGl2 PgogICAgICAgICAgPGRpdj5ZLjwvZGl2PgogICAgICAgICAgPGJyPgogICAgICAgIDwvZGl2Pgog ICAgICA8L2Rpdj4KICAgIDwvYmxvY2txdW90ZT4KICAgIDxicj4KICAgIEFGQUlSIHRoZSBjb2xs ZWN0ZCB1bml4c29jayBwbHVnaW4gaXQncyBidWlsdCBhbmQgc2hpcHBlZCBieSBkZWZhdWx0CiAg ICBieSB0aGUgY29sbGVjdGQgKGV2ZW4gUlBNcykuIEl0IGlzIHRoZSB3YXkgdGhlIGNvbW1hbmQg bGluZQogICAgYGNvbGxlY3RkY3RsYCB0b28gdXNlcyB0byB0YWxrIHdpdGggdGhlIGRhZW1vbi48 YnI+CiAgICA8YnI+CiAgICBPdXIgY2xpZW50IG1vZHVsZSBpcyBzdGlsbCB3b3JrIGluIHByb2dy ZXNzLjxicj4KICAgIDxicj4KICAgIEknZCBiZSBoYXBweSB0byBqdXN0IHVzZSBhIHRoaXJkIHBh cnR5IGNsaWVudCBtb2R1bGUsIHRoZQogICAgKHNlbWktKW9mZmljaWFsIG9uZSBpcyBub3Qgc2hp cHBlZCBieSBkZWZhdWx0IGxhc3QgdGltZSBJIGNoZWNrZWQ7CiAgICBwZXJoYXBzIGp1c3QgZmls ZSBvbmUgUkZFIGFib3V0IHRoYXQ/PGJyPgogICAgPGJyPgogICAgPHByZSBjbGFzcz0ibW96LXNp Z25hdHVyZSIgY29scz0iNzIiPi0tIApGcmFuY2VzY28gUm9tYW5pClJlZCBIYXQgRW5naW5lZXJp bmcgVmlydHVhbGl6YXRpb24gUiAmYW1wOyBECklSQzogZnJvbWFuaTwvcHJlPgogIDwvYm9keT4K PC9odG1sPgoKLS0tLS0tLS0tLS0tLS0wQkZBRERDNzM1RkY5NEQ1RThBMDkzMUEtLQo= --===============6050603790128189705==--