From dpati at redhat.com Fri Nov 29 06:41:57 2013 Content-Type: multipart/mixed; boundary="===============9026436894380994739==" MIME-Version: 1.0 From: Dusmant Kumar Pati To: devel at ovirt.org Subject: Re: [Engine-devel] Using config values Date: Fri, 29 Nov 2013 17:10:09 +0530 Message-ID: <52987D19.9000203@redhat.com> In-Reply-To: 52984D48.1070009@redhat.com --===============9026436894380994739== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable This is a multi-part message in MIME format. --------------010309070708090904000001 Content-Type: text/plain; charset=3DISO-8859-1; format=3Dflowed Content-Transfer-Encoding: 7bit On 11/29/2013 01:46 PM, Kanagaraj wrote: > Hi All, > > The are some issues arising in configurations whenever we move up on = > the versions(3.3 =3D> 3.4), because of the way we store and interpret the= m. > > Whenever there is a new cluster level, you will need to add a new = > entry for all(most) of the configuration. Mostly a copy paste if you = > see from 3.2 to 3.3, except some CPU/PM type related configurations. > Better option would be to have the defaul config value in = > ConfigValues.java and the overrides will go to config.sql. In this = > approach you don't need a new entries to config.sql when there is a = > new cluster level. > > Lets take an exmaple, "SupportForceCreateVG" - This is supported from = > 3.1 onwards, > > If you look at config.sql, you will see following entries > select fn_db_add_config_value('SupportForceCreateVG','false','3.0'); > select fn_db_add_config_value('SupportForceCreateVG','true','3.1'); > select fn_db_add_config_value('SupportForceCreateVG','true','3.2'); > select fn_db_add_config_value('SupportForceCreateVG','true','3.3'); > > And in ConfigValues.java > > @TypeConverterAttribute(Boolean.class) > @DefaultValueAttribute("false") > SupportForceCreateVG, > > Now if there is 3.4 and 3.5, the user needs to add 2 more entries, = > which i feel is redundant. > > Instead we can make > > @TypeConverterAttribute(Boolean.class) > @DefaultValueAttribute("true") > SupportForceCreateVG, > > and have only the following in config.sql > select fn_db_add_config_value('SupportForceCreateVG','false','3.0'); > > if a particular value(for a specific cluster level) is not found in = > Config.sql, the fallback is to use the value available in = > ConfigValues.java. > > Please share your thoughts on this. > > Thanks, > Kanagaraj > > > > _______________________________________________ > Engine-devel mailing list > Engine-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel I think, this is a good suggestion... --------------010309070708090904000001 Content-Type: text/html; charset=3DISO-8859-1 Content-Transfer-Encoding: 7bit

On 11/29/2013 01:46 PM, Kanagaraj wrote:

Hi All,

The are some issues arising in configurations whenever we move up on the versions(3.3 =3D> 3.4), because of the way we store and interpret them.

Whenever there is a new cluster level, you will need to add a new entry for all(most) of the configuration. Mostly a copy paste if you see from 3.2 to 3.3, except some CPU/PM type related configurations.
Better option would be to have the defaul config value in ConfigValues.java and the overrides will go to config.sql. In this approach you don't need a new entries to config.sql when there is a new cluster level.

Lets take an exmaple, "SupportForceCreateVG" - This is supported from 3.1 onwards,

If you look at config.sql, you will see following entries
select fn_db_add_config_value('SupportForceCreateVG','false','3.0');
select fn_db_add_config_value('SupportForceCreateVG','true','3.1');
select fn_db_add_config_value('SupportForceCreateVG','true','3.2');
select fn_db_add_config_value('SupportForceCreateVG','true','3.3');

And in ConfigValues.java

    @TypeConverterAttribute(Boolean.class)
    @DefaultValueAttribute("false")
    SupportForceCreateVG,

Now if there is 3.4 and 3.5, the user needs to add 2 more entries, which i feel is redundant.

Instead we can make

    @TypeConverterAttribute(Boolean.class)
    @DefaultValueAttribute("true")
    SupportForceCreateVG,

and have only the following in config.sql
select fn_db_add_config_value('SupportForceCreateVG','false','3.0');

if a particular value(for a specific cluster level) is not found in Config.sql, the fallback is to use the value available in ConfigValues.java.

Please share your thoughts on this.

Thanks,
Kanagaraj
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel<=
/a>

I think, this is a good suggestion...

--------------010309070708090904000001-- --===============9026436894380994739== Content-Type: multipart/alternative MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.bin" VGhpcyBpcyBhIG11bHRpLXBhcnQgbWVzc2FnZSBpbiBNSU1FIGZvcm1hdC4KLS0tLS0tLS0tLS0t LS0wMTAzMDkwNzA3MDgwOTA5MDQwMDAwMDEKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFy c2V0PUlTTy04ODU5LTE7IGZvcm1hdD1mbG93ZWQKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzog N2JpdAoKT24gMTEvMjkvMjAxMyAwMTo0NiBQTSwgS2FuYWdhcmFqIHdyb3RlOgo+IEhpIEFsbCwK Pgo+IFRoZSBhcmUgc29tZSBpc3N1ZXMgYXJpc2luZyBpbiBjb25maWd1cmF0aW9ucyB3aGVuZXZl ciB3ZSBtb3ZlIHVwIG9uIAo+IHRoZSB2ZXJzaW9ucygzLjMgPT4gMy40KSwgYmVjYXVzZSBvZiB0 aGUgd2F5IHdlIHN0b3JlIGFuZCBpbnRlcnByZXQgdGhlbS4KPgo+IFdoZW5ldmVyIHRoZXJlIGlz IGEgbmV3IGNsdXN0ZXIgbGV2ZWwsIHlvdSB3aWxsIG5lZWQgdG8gYWRkIGEgbmV3IAo+IGVudHJ5 IGZvciBhbGwobW9zdCkgb2YgdGhlIGNvbmZpZ3VyYXRpb24uIE1vc3RseSBhIGNvcHkgcGFzdGUg aWYgeW91IAo+IHNlZSBmcm9tIDMuMiB0byAzLjMsIGV4Y2VwdCBzb21lIENQVS9QTSB0eXBlIHJl bGF0ZWQgY29uZmlndXJhdGlvbnMuCj4gQmV0dGVyIG9wdGlvbiB3b3VsZCBiZSB0byBoYXZlIHRo ZSBkZWZhdWwgY29uZmlnIHZhbHVlIGluIAo+IENvbmZpZ1ZhbHVlcy5qYXZhIGFuZCB0aGUgb3Zl cnJpZGVzIHdpbGwgZ28gdG8gY29uZmlnLnNxbC4gSW4gdGhpcyAKPiBhcHByb2FjaCB5b3UgZG9u J3QgbmVlZCBhIG5ldyBlbnRyaWVzIHRvIGNvbmZpZy5zcWwgd2hlbiB0aGVyZSBpcyBhIAo+IG5l dyBjbHVzdGVyIGxldmVsLgo+Cj4gTGV0cyB0YWtlIGFuIGV4bWFwbGUsICJTdXBwb3J0Rm9yY2VD cmVhdGVWRyIgLSBUaGlzIGlzIHN1cHBvcnRlZCBmcm9tIAo+IDMuMSBvbndhcmRzLAo+Cj4gSWYg eW91IGxvb2sgYXQgY29uZmlnLnNxbCwgeW91IHdpbGwgc2VlIGZvbGxvd2luZyBlbnRyaWVzCj4g c2VsZWN0IGZuX2RiX2FkZF9jb25maWdfdmFsdWUoJ1N1cHBvcnRGb3JjZUNyZWF0ZVZHJywnZmFs c2UnLCczLjAnKTsKPiBzZWxlY3QgZm5fZGJfYWRkX2NvbmZpZ192YWx1ZSgnU3VwcG9ydEZvcmNl Q3JlYXRlVkcnLCd0cnVlJywnMy4xJyk7Cj4gc2VsZWN0IGZuX2RiX2FkZF9jb25maWdfdmFsdWUo J1N1cHBvcnRGb3JjZUNyZWF0ZVZHJywndHJ1ZScsJzMuMicpOwo+IHNlbGVjdCBmbl9kYl9hZGRf Y29uZmlnX3ZhbHVlKCdTdXBwb3J0Rm9yY2VDcmVhdGVWRycsJ3RydWUnLCczLjMnKTsKPgo+IEFu ZCBpbiBDb25maWdWYWx1ZXMuamF2YQo+Cj4gICAgIEBUeXBlQ29udmVydGVyQXR0cmlidXRlKEJv b2xlYW4uY2xhc3MpCj4gICAgIEBEZWZhdWx0VmFsdWVBdHRyaWJ1dGUoImZhbHNlIikKPiAgICAg U3VwcG9ydEZvcmNlQ3JlYXRlVkcsCj4KPiBOb3cgaWYgdGhlcmUgaXMgMy40IGFuZCAzLjUsIHRo ZSB1c2VyIG5lZWRzIHRvIGFkZCAyIG1vcmUgZW50cmllcywgCj4gd2hpY2ggaSBmZWVsIGlzIHJl ZHVuZGFudC4KPgo+IEluc3RlYWQgd2UgY2FuIG1ha2UKPgo+ICAgICBAVHlwZUNvbnZlcnRlckF0 dHJpYnV0ZShCb29sZWFuLmNsYXNzKQo+ICAgICBARGVmYXVsdFZhbHVlQXR0cmlidXRlKCJ0cnVl IikKPiAgICAgU3VwcG9ydEZvcmNlQ3JlYXRlVkcsCj4KPiBhbmQgaGF2ZSBvbmx5IHRoZSBmb2xs b3dpbmcgaW4gY29uZmlnLnNxbAo+IHNlbGVjdCBmbl9kYl9hZGRfY29uZmlnX3ZhbHVlKCdTdXBw b3J0Rm9yY2VDcmVhdGVWRycsJ2ZhbHNlJywnMy4wJyk7Cj4KPiBpZiBhIHBhcnRpY3VsYXIgdmFs dWUoZm9yIGEgc3BlY2lmaWMgY2x1c3RlciBsZXZlbCkgaXMgbm90IGZvdW5kIGluIAo+IENvbmZp Zy5zcWwsIHRoZSBmYWxsYmFjayBpcyB0byB1c2UgdGhlIHZhbHVlIGF2YWlsYWJsZSBpbiAKPiBD b25maWdWYWx1ZXMuamF2YS4KPgo+IFBsZWFzZSBzaGFyZSB5b3VyIHRob3VnaHRzIG9uIHRoaXMu Cj4KPiBUaGFua3MsCj4gS2FuYWdhcmFqCj4KPgo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPiBFbmdpbmUtZGV2ZWwgbWFpbGluZyBsaXN0Cj4gRW5n aW5lLWRldmVsQG92aXJ0Lm9yZwo+IGh0dHA6Ly9saXN0cy5vdmlydC5vcmcvbWFpbG1hbi9saXN0 aW5mby9lbmdpbmUtZGV2ZWwKSSB0aGluaywgdGhpcyBpcyBhIGdvb2Qgc3VnZ2VzdGlvbi4uLgoK Ci0tLS0tLS0tLS0tLS0tMDEwMzA5MDcwNzA4MDkwOTA0MDAwMDAxCkNvbnRlbnQtVHlwZTogdGV4 dC9odG1sOyBjaGFyc2V0PUlTTy04ODU5LTEKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogN2Jp dAoKPGh0bWw+CiAgPGhlYWQ+CiAgICA8bWV0YSBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9 SVNPLTg4NTktMSIKICAgICAgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIj4KICA8L2hlYWQ+CiAg PGJvZHkgYmdjb2xvcj0iI0ZGRkZGRiIgdGV4dD0iIzAwMDAwMCI+CiAgICA8ZGl2IGNsYXNzPSJt b3otY2l0ZS1wcmVmaXgiPk9uIDExLzI5LzIwMTMgMDE6NDYgUE0sIEthbmFnYXJhagogICAgICB3 cm90ZTo8YnI+CiAgICA8L2Rpdj4KICAgIDxibG9ja3F1b3RlIGNpdGU9Im1pZDo1Mjk4NEQ0OC4x MDcwMDA5QHJlZGhhdC5jb20iIHR5cGU9ImNpdGUiPgogICAgICA8bWV0YSBodHRwLWVxdWl2PSJj b250ZW50LXR5cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsKICAgICAgICBjaGFyc2V0PUlTTy04ODU5 LTEiPgogICAgICBIaSBBbGwsPGJyPgogICAgICA8YnI+CiAgICAgIFRoZSBhcmUgc29tZSBpc3N1 ZXMgYXJpc2luZyBpbiBjb25maWd1cmF0aW9ucyB3aGVuZXZlciB3ZSBtb3ZlIHVwCiAgICAgIG9u IHRoZSB2ZXJzaW9ucygzLjMgPSZndDsgMy40KSwgYmVjYXVzZSBvZiB0aGUgd2F5IHdlIHN0b3Jl IGFuZAogICAgICBpbnRlcnByZXQgdGhlbS48YnI+CiAgICAgIDxicj4KICAgICAgV2hlbmV2ZXIg dGhlcmUgaXMgYSBuZXcgY2x1c3RlciBsZXZlbCwgeW91IHdpbGwgbmVlZCB0byBhZGQgYSBuZXcK ICAgICAgZW50cnkgZm9yIGFsbChtb3N0KSBvZiB0aGUgY29uZmlndXJhdGlvbi4gTW9zdGx5IGEg Y29weSBwYXN0ZSBpZgogICAgICB5b3Ugc2VlIGZyb20gMy4yIHRvIDMuMywgZXhjZXB0IHNvbWUg Q1BVL1BNIHR5cGUgcmVsYXRlZAogICAgICBjb25maWd1cmF0aW9ucy48YnI+CiAgICAgIEJldHRl ciBvcHRpb24gd291bGQgYmUgdG8gaGF2ZSB0aGUgZGVmYXVsIGNvbmZpZyB2YWx1ZSBpbgogICAg ICBDb25maWdWYWx1ZXMuamF2YSBhbmQgdGhlIG92ZXJyaWRlcyB3aWxsIGdvIHRvIGNvbmZpZy5z cWwuIEluIHRoaXMKICAgICAgYXBwcm9hY2ggeW91IGRvbid0IG5lZWQgYSBuZXcgZW50cmllcyB0 byBjb25maWcuc3FsIHdoZW4gdGhlcmUgaXMKICAgICAgYSBuZXcgY2x1c3RlciBsZXZlbC48YnI+ CiAgICAgIDxicj4KICAgICAgTGV0cyB0YWtlIGFuIGV4bWFwbGUsICJTdXBwb3J0Rm9yY2VDcmVh dGVWRyIgLSBUaGlzIGlzIHN1cHBvcnRlZAogICAgICBmcm9tIDMuMSBvbndhcmRzLDxicj4KICAg ICAgPGJyPgogICAgICBJZiB5b3UgbG9vayBhdCBjb25maWcuc3FsLCB5b3Ugd2lsbCBzZWUgZm9s bG93aW5nIGVudHJpZXMgPGJyPgogICAgICBzZWxlY3QKICAgICAgZm5fZGJfYWRkX2NvbmZpZ192 YWx1ZSgnU3VwcG9ydEZvcmNlQ3JlYXRlVkcnLCdmYWxzZScsJzMuMCcpOyA8YnI+CiAgICAgIHNl bGVjdAogICAgICBmbl9kYl9hZGRfY29uZmlnX3ZhbHVlKCdTdXBwb3J0Rm9yY2VDcmVhdGVWRycs J3RydWUnLCczLjEnKTsgPGJyPgogICAgICBzZWxlY3QKICAgICAgZm5fZGJfYWRkX2NvbmZpZ192 YWx1ZSgnU3VwcG9ydEZvcmNlQ3JlYXRlVkcnLCd0cnVlJywnMy4yJyk7IDxicj4KICAgICAgc2Vs ZWN0CiAgICAgIGZuX2RiX2FkZF9jb25maWdfdmFsdWUoJ1N1cHBvcnRGb3JjZUNyZWF0ZVZHJywn dHJ1ZScsJzMuMycpOzxicj4KICAgICAgPGJyPgogICAgICBBbmQgaW4gQ29uZmlnVmFsdWVzLmph dmE8YnI+CiAgICAgIDxicj4KICAgICAgJm5ic3A7Jm5ic3A7Jm5ic3A7IEBUeXBlQ29udmVydGVy QXR0cmlidXRlKEJvb2xlYW4uY2xhc3MpPGJyPgogICAgICAmbmJzcDsmbmJzcDsmbmJzcDsgQERl ZmF1bHRWYWx1ZUF0dHJpYnV0ZSgiZmFsc2UiKTxicj4KICAgICAgJm5ic3A7Jm5ic3A7Jm5ic3A7 IFN1cHBvcnRGb3JjZUNyZWF0ZVZHLDxicj4KICAgICAgPGJyPgogICAgICBOb3cgaWYgdGhlcmUg aXMgMy40IGFuZCAzLjUsIHRoZSB1c2VyIG5lZWRzIHRvIGFkZCAyIG1vcmUgZW50cmllcywKICAg ICAgd2hpY2ggaSBmZWVsIGlzIHJlZHVuZGFudC48YnI+CiAgICAgIDxicj4KICAgICAgSW5zdGVh ZCB3ZSBjYW4gbWFrZSA8YnI+CiAgICAgIDxicj4KICAgICAgJm5ic3A7Jm5ic3A7Jm5ic3A7IEBU eXBlQ29udmVydGVyQXR0cmlidXRlKEJvb2xlYW4uY2xhc3MpPGJyPgogICAgICAmbmJzcDsmbmJz cDsmbmJzcDsgQERlZmF1bHRWYWx1ZUF0dHJpYnV0ZSgidHJ1ZSIpPGJyPgogICAgICAmbmJzcDsm bmJzcDsmbmJzcDsgU3VwcG9ydEZvcmNlQ3JlYXRlVkcsPGJyPgogICAgICA8YnI+CiAgICAgIGFu ZCBoYXZlIG9ubHkgdGhlIGZvbGxvd2luZyBpbiBjb25maWcuc3FsPGJyPgogICAgICBzZWxlY3QK ICAgICAgZm5fZGJfYWRkX2NvbmZpZ192YWx1ZSgnU3VwcG9ydEZvcmNlQ3JlYXRlVkcnLCdmYWxz ZScsJzMuMCcpOzxicj4KICAgICAgPGJyPgogICAgICBpZiBhIHBhcnRpY3VsYXIgdmFsdWUoZm9y IGEgc3BlY2lmaWMgY2x1c3RlciBsZXZlbCkgaXMgbm90IGZvdW5kCiAgICAgIGluIENvbmZpZy5z cWwsIHRoZSBmYWxsYmFjayBpcyB0byB1c2UgdGhlIHZhbHVlIGF2YWlsYWJsZSBpbgogICAgICBD b25maWdWYWx1ZXMuamF2YS48YnI+CiAgICAgIDxicj4KICAgICAgUGxlYXNlIHNoYXJlIHlvdXIg dGhvdWdodHMgb24gdGhpcy48YnI+CiAgICAgIDxicj4KICAgICAgVGhhbmtzLDxicj4KICAgICAg S2FuYWdhcmFqPGJyPgogICAgICA8YnI+CiAgICAgIDxtZXRhIGh0dHAtZXF1aXY9ImNvbnRlbnQt dHlwZSIgY29udGVudD0idGV4dC9odG1sOwogICAgICAgIGNoYXJzZXQ9SVNPLTg4NTktMSI+CiAg ICAgIDxicj4KICAgICAgPGZpZWxkc2V0IGNsYXNzPSJtaW1lQXR0YWNobWVudEhlYWRlciI+PC9m aWVsZHNldD4KICAgICAgPGJyPgogICAgICA8cHJlIHdyYXA9IiI+X19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KRW5naW5lLWRldmVsIG1haWxpbmcgbGlzdAo8 YSBjbGFzcz0ibW96LXR4dC1saW5rLWFiYnJldmlhdGVkIiBocmVmPSJtYWlsdG86RW5naW5lLWRl dmVsQG92aXJ0Lm9yZyI+RW5naW5lLWRldmVsQG92aXJ0Lm9yZzwvYT4KPGEgY2xhc3M9Im1vei10 eHQtbGluay1mcmVldGV4dCIgaHJlZj0iaHR0cDovL2xpc3RzLm92aXJ0Lm9yZy9tYWlsbWFuL2xp c3RpbmZvL2VuZ2luZS1kZXZlbCI+aHR0cDovL2xpc3RzLm92aXJ0Lm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2VuZ2luZS1kZXZlbDwvYT4KPC9wcmU+CiAgICA8L2Jsb2NrcXVvdGU+CiAgICBJIHRoaW5r LCB0aGlzIGlzIGEgZ29vZCBzdWdnZXN0aW9uLi4uPGJyPgogICAgPGJyPgogIDwvYm9keT4KPC9o dG1sPgoKLS0tLS0tLS0tLS0tLS0wMTAzMDkwNzA3MDgwOTA5MDQwMDAwMDEtLQo= --===============9026436894380994739==--