From deepakcs at linux.vnet.ibm.com Fri Mar 1 02:09:46 2013 Content-Type: multipart/mixed; boundary="===============2083100973409367359==" MIME-Version: 1.0 From: Deepak C Shetty To: devel at ovirt.org Subject: [Engine-devel] DC Compat Version Vs Storage Format Version Date: Fri, 01 Mar 2013 12:34:45 +0530 Message-ID: <5130530D.6030408@linux.vnet.ibm.com> --===============2083100973409367359== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable This is a multi-part message in MIME format. --------------040803040800070702000706 Content-Type: text/plain; charset=3DISO-8859-1; format=3Dflowed Content-Transfer-Encoding: 7bit Hi All, I am seeing an error while testing the WIP engine patches for = supporting GLUSTERFS_DOMAIN @ http://gerrit.ovirt.org/#/q/project:ovirt-engine+branch:master+topic:gluste= rfs,n,z (Copyign Sharad, who is the author for the patch series) Note my VDSM host has VDSM running which has support for = GLUSTERFS_DOMAIN (its already upstream in VDSM) I get the below error in GUI while trying to create a new Storage Domain = of type Data/GlusterFS *Error: Cannot add Storage. Storage format V3 is not supported on the = selected host version." * I cannot change storgae format in the GUI, its fixed at V3 DC is of type GlusterFS and so is cluster, compat version is 3.3 I have few questions ... 1) How are compat version and storage format related ? 2) What does 'host version' in the above error msg mean. It doesn't tell = clearly why/what the incompatibility is about 3) What needs to be done in the engine to make this work ? thanx, deepak --------------040803040800070702000706 Content-Type: text/html; charset=3DISO-8859-1 Content-Transfer-Encoding: 7bit Hi All,
   I am seeing an error while testing the WIP engine patche= s  for supporting GLUSTERFS_DOMAIN @

http://gerrit.ovirt.org/#/q/project:ovirt-engine+branch:ma= ster+topic:glusterfs,n,z

(Copyign Sharad, who is the author for the patch series)
Note my VDSM host has VDSM running which  has support for GLUSTERFS_DOMAIN (its already upstream in VDSM)

I get the below error in GUI while trying to create a new Storage Domain of type Data/GlusterFS
Error: Cannot add Storage. Storage format V3 is not supported on the selected host version."

I cannot change storgae format in the GUI, its fixed at V3
DC is of type GlusterFS and so is cluster, compat version is 3.3

I have few questions ...

1) How are compat version and storage format related ?

2) What does 'host version' in the above error msg mean. It doesn't tell clearly why/what the incompatibility is about

3) What needs to be done in the engine to make this work ?

thanx,
deepak

--------------040803040800070702000706-- --===============2083100973409367359== Content-Type: multipart/alternative MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.bin" VGhpcyBpcyBhIG11bHRpLXBhcnQgbWVzc2FnZSBpbiBNSU1FIGZvcm1hdC4KLS0tLS0tLS0tLS0t LS0wNDA4MDMwNDA4MDAwNzA3MDIwMDA3MDYKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFy c2V0PUlTTy04ODU5LTE7IGZvcm1hdD1mbG93ZWQKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzog N2JpdAoKSGkgQWxsLAogICAgSSBhbSBzZWVpbmcgYW4gZXJyb3Igd2hpbGUgdGVzdGluZyB0aGUg V0lQIGVuZ2luZSBwYXRjaGVzICBmb3IgCnN1cHBvcnRpbmcgR0xVU1RFUkZTX0RPTUFJTiBACgpo dHRwOi8vZ2Vycml0Lm92aXJ0Lm9yZy8jL3EvcHJvamVjdDpvdmlydC1lbmdpbmUrYnJhbmNoOm1h c3Rlcit0b3BpYzpnbHVzdGVyZnMsbix6CgooQ29weWlnbiBTaGFyYWQsIHdobyBpcyB0aGUgYXV0 aG9yIGZvciB0aGUgcGF0Y2ggc2VyaWVzKQpOb3RlIG15IFZEU00gaG9zdCBoYXMgVkRTTSBydW5u aW5nIHdoaWNoICBoYXMgc3VwcG9ydCBmb3IgCkdMVVNURVJGU19ET01BSU4gKGl0cyBhbHJlYWR5 IHVwc3RyZWFtIGluIFZEU00pCgpJIGdldCB0aGUgYmVsb3cgZXJyb3IgaW4gR1VJIHdoaWxlIHRy eWluZyB0byBjcmVhdGUgYSBuZXcgU3RvcmFnZSBEb21haW4gCm9mIHR5cGUgRGF0YS9HbHVzdGVy RlMKKkVycm9yOiBDYW5ub3QgYWRkIFN0b3JhZ2UuIFN0b3JhZ2UgZm9ybWF0IFYzIGlzIG5vdCBz dXBwb3J0ZWQgb24gdGhlIApzZWxlY3RlZCBob3N0IHZlcnNpb24uIiAqCgpJIGNhbm5vdCBjaGFu Z2Ugc3RvcmdhZSBmb3JtYXQgaW4gdGhlIEdVSSwgaXRzIGZpeGVkIGF0IFYzCkRDIGlzIG9mIHR5 cGUgR2x1c3RlckZTIGFuZCBzbyBpcyBjbHVzdGVyLCBjb21wYXQgdmVyc2lvbiBpcyAzLjMKCkkg aGF2ZSBmZXcgcXVlc3Rpb25zIC4uLgoKMSkgSG93IGFyZSBjb21wYXQgdmVyc2lvbiBhbmQgc3Rv cmFnZSBmb3JtYXQgcmVsYXRlZCA/CgoyKSBXaGF0IGRvZXMgJ2hvc3QgdmVyc2lvbicgaW4gdGhl IGFib3ZlIGVycm9yIG1zZyBtZWFuLiBJdCBkb2Vzbid0IHRlbGwgCmNsZWFybHkgd2h5L3doYXQg dGhlIGluY29tcGF0aWJpbGl0eSBpcyBhYm91dAoKMykgV2hhdCBuZWVkcyB0byBiZSBkb25lIGlu IHRoZSBlbmdpbmUgdG8gbWFrZSB0aGlzIHdvcmsgPwoKdGhhbngsCmRlZXBhawoKCi0tLS0tLS0t LS0tLS0tMDQwODAzMDQwODAwMDcwNzAyMDAwNzA2CkNvbnRlbnQtVHlwZTogdGV4dC9odG1sOyBj aGFyc2V0PUlTTy04ODU5LTEKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogN2JpdAoKPGh0bWw+ CiAgPGhlYWQ+CgogICAgPG1ldGEgaHR0cC1lcXVpdj0iY29udGVudC10eXBlIiBjb250ZW50PSJ0 ZXh0L2h0bWw7IGNoYXJzZXQ9SVNPLTg4NTktMSI+CiAgPC9oZWFkPgogIDxib2R5IGJnY29sb3I9 IiNGRkZGRkYiIHRleHQ9IiMwMDAwMDAiPgogICAgPHR0PkhpIEFsbCw8YnI+CiAgICAgICZuYnNw OyZuYnNwOyBJIGFtIHNlZWluZyBhbiBlcnJvciB3aGlsZSB0ZXN0aW5nIHRoZSBXSVAgZW5naW5l IHBhdGNoZXMmbmJzcDsgZm9yCiAgICAgIHN1cHBvcnRpbmcgR0xVU1RFUkZTX0RPTUFJTiBAPGJy PgogICAgPC90dD48YnI+CiAgICA8YSBjbGFzcz0ibW96LXR4dC1saW5rLWZyZWV0ZXh0IgpocmVm PSJodHRwOi8vZ2Vycml0Lm92aXJ0Lm9yZy8jL3EvcHJvamVjdDpvdmlydC1lbmdpbmUrYnJhbmNo Om1hc3Rlcit0b3BpYzpnbHVzdGVyZnMsbix6Ij5odHRwOi8vZ2Vycml0Lm92aXJ0Lm9yZy8jL3Ev cHJvamVjdDpvdmlydC1lbmdpbmUrYnJhbmNoOm1hc3Rlcit0b3BpYzpnbHVzdGVyZnMsbix6PC9h Pjxicj4KICAgIDxicj4KICAgIChDb3B5aWduIFNoYXJhZCwgd2hvIGlzIHRoZSBhdXRob3IgZm9y IHRoZSBwYXRjaCBzZXJpZXMpPGJyPgogICAgTm90ZSBteSBWRFNNIGhvc3QgaGFzIFZEU00gcnVu bmluZyB3aGljaCZuYnNwOyBoYXMgc3VwcG9ydCBmb3IKICAgIEdMVVNURVJGU19ET01BSU4gKGl0 cyBhbHJlYWR5IHVwc3RyZWFtIGluIFZEU00pPGJyPgogICAgPGJyPgogICAgSSBnZXQgdGhlIGJl bG93IGVycm9yIGluIEdVSSB3aGlsZSB0cnlpbmcgdG8gY3JlYXRlIGEgbmV3IFN0b3JhZ2UKICAg IERvbWFpbiBvZiB0eXBlIERhdGEvR2x1c3RlckZTPGJyPgogICAgPGI+RXJyb3I6IENhbm5vdCBh ZGQgU3RvcmFnZS4gU3RvcmFnZSBmb3JtYXQgVjMgaXMgbm90IHN1cHBvcnRlZCBvbgogICAgICB0 aGUgc2VsZWN0ZWQgaG9zdCB2ZXJzaW9uLiIgPC9iPjxicj4KICAgIDxicj4KICAgIEkgY2Fubm90 IGNoYW5nZSBzdG9yZ2FlIGZvcm1hdCBpbiB0aGUgR1VJLCBpdHMgZml4ZWQgYXQgVjM8YnI+CiAg ICBEQyBpcyBvZiB0eXBlIEdsdXN0ZXJGUyBhbmQgc28gaXMgY2x1c3RlciwgY29tcGF0IHZlcnNp b24gaXMgMy4zPGJyPgogICAgPGJyPgogICAgSSBoYXZlIGZldyBxdWVzdGlvbnMgLi4uPGJyPgog ICAgPGJyPgogICAgMSkgSG93IGFyZSBjb21wYXQgdmVyc2lvbiBhbmQgc3RvcmFnZSBmb3JtYXQg cmVsYXRlZCA/PGJyPgogICAgPGJyPgogICAgMikgV2hhdCBkb2VzICdob3N0IHZlcnNpb24nIGlu IHRoZSBhYm92ZSBlcnJvciBtc2cgbWVhbi4gSXQgZG9lc24ndAogICAgdGVsbCBjbGVhcmx5IHdo eS93aGF0IHRoZSBpbmNvbXBhdGliaWxpdHkgaXMgYWJvdXQ8YnI+CiAgICA8YnI+CiAgICAzKSBX aGF0IG5lZWRzIHRvIGJlIGRvbmUgaW4gdGhlIGVuZ2luZSB0byBtYWtlIHRoaXMgd29yayA/PGJy PgogICAgPGJyPgogICAgdGhhbngsPGJyPgogICAgZGVlcGFrPGJyPgogICAgPGJyPgogIDwvYm9k eT4KPC9odG1sPgoKLS0tLS0tLS0tLS0tLS0wNDA4MDMwNDA4MDAwNzA3MDIwMDA3MDYtLQoK --===============2083100973409367359==-- From iheim at redhat.com Fri Mar 1 03:28:15 2013 Content-Type: multipart/mixed; boundary="===============5431091448124164136==" MIME-Version: 1.0 From: Itamar Heim To: devel at ovirt.org Subject: Re: [Engine-devel] DC Compat Version Vs Storage Format Version Date: Fri, 01 Mar 2013 10:28:51 +0200 Message-ID: <513066C3.9060700@redhat.com> In-Reply-To: 5130530D.6030408@linux.vnet.ibm.com --===============5431091448124164136== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 01/03/2013 09:04, Deepak C Shetty wrote: > Hi All, > I am seeing an error while testing the WIP engine patches for > supporting GLUSTERFS_DOMAIN @ > > http://gerrit.ovirt.org/#/q/project:ovirt-engine+branch:master+topic:glus= terfs,n,z > > (Copyign Sharad, who is the author for the patch series) > Note my VDSM host has VDSM running which has support for > GLUSTERFS_DOMAIN (its already upstream in VDSM) > > I get the below error in GUI while trying to create a new Storage Domain > of type Data/GlusterFS > *Error: Cannot add Storage. Storage format V3 is not supported on the > selected host version." * > > I cannot change storgae format in the GUI, its fixed at V3 > DC is of type GlusterFS and so is cluster, compat version is 3.3 > > I have few questions ... > > 1) How are compat version and storage format related ? storage formats are supported for specific compat version. > > 2) What does 'host version' in the above error msg mean. It doesn't tell > clearly why/what the incompatibility is about host version is probably the supported cluster levels it has. > > 3) What needs to be done in the engine to make this work ? it seems while 3.3 cluster version was added, not all config keys are = available for it yet (yair/eli?) for example: backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql:select = fn_db_add_config_value('SupportedStorageFormats','0,2,3','3.2'); is missing for 3.3 cluster level. Also, specifcially, need to review the logic of this method when adding = a new type of storage domain. NFS is V0/V1 for backward compatibility = and V3. but GlusterFS should probably only be V3: in AddStorageDomainCommand: private boolean isStorageFormatCompatibleWithDomain() { StorageFormatType storageFormat =3D = getStorageDomain().getStorageFormat(); StorageType storageType =3D getStorageDomain().getStorageType(); StorageDomainType storageDomainFunction =3D = getStorageDomain().getStorageDomainType(); boolean isBlockStorage =3D storageType =3D=3D StorageType.ISCSI |= | = storageType =3D=3D StorageType.FCP; boolean isDataStorageDomain =3D storageDomainFunction =3D=3D = StorageDomainType.Data; // V2 is applicable only for block data storage domains if (storageFormat =3D=3D StorageFormatType.V2 && (!isBlockStorage = || !isDataStorageDomain)) { return false; } // V3 is applicable only for data storage domains if (storageFormat =3D=3D StorageFormatType.V3 && = !isDataStorageDomain) { return false; } return true; } --===============5431091448124164136==--