From sabose at redhat.com Fri Nov 29 04:06:36 2013 Content-Type: multipart/mixed; boundary="===============8415757116208460904==" MIME-Version: 1.0 From: Sahina Bose To: devel at ovirt.org Subject: Re: [Engine-devel] Using config values Date: Fri, 29 Nov 2013 14:36:33 +0530 Message-ID: <52985919.2050109@redhat.com> In-Reply-To: 52984D48.1070009@redhat.com --===============8415757116208460904== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable This is a multi-part message in MIME format. --------------060202090604020609010600 Content-Type: text/plain; charset=3DISO-8859-1; format=3Dflowed Content-Transfer-Encoding: 7bit On 11/29/2013 01:46 PM, Kanagaraj wrote: > Hi All, > > The are some issues arising in configurations whenever we move up on = > the versions(3.3 =3D> 3.4), because of the way we store and interpret the= m. > > Whenever there is a new cluster level, you will need to add a new = > entry for all(most) of the configuration. Mostly a copy paste if you = > see from 3.2 to 3.3, except some CPU/PM type related configurations. > Better option would be to have the defaul config value in = > ConfigValues.java and the overrides will go to config.sql. In this = > approach you don't need a new entries to config.sql when there is a = > new cluster level. > > Lets take an exmaple, "SupportForceCreateVG" - This is supported from = > 3.1 onwards, > > If you look at config.sql, you will see following entries > select fn_db_add_config_value('SupportForceCreateVG','false','3.0'); > select fn_db_add_config_value('SupportForceCreateVG','true','3.1'); > select fn_db_add_config_value('SupportForceCreateVG','true','3.2'); > select fn_db_add_config_value('SupportForceCreateVG','true','3.3'); > > And in ConfigValues.java > > @TypeConverterAttribute(Boolean.class) > @DefaultValueAttribute("false") > SupportForceCreateVG, > > Now if there is 3.4 and 3.5, the user needs to add 2 more entries, = > which i feel is redundant. > > Instead we can make > > @TypeConverterAttribute(Boolean.class) > @DefaultValueAttribute("true") > SupportForceCreateVG, > > and have only the following in config.sql > select fn_db_add_config_value('SupportForceCreateVG','false','3.0'); > > if a particular value(for a specific cluster level) is not found in = > Config.sql, the fallback is to use the value available in = > ConfigValues.java. > > Please share your thoughts on this. +1 > > Thanks, > Kanagaraj > > > > _______________________________________________ > Engine-devel mailing list > Engine-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel --------------060202090604020609010600 Content-Type: text/html; charset=3DISO-8859-1 Content-Transfer-Encoding: 7bit

On 11/29/2013 01:46 PM, Kanagaraj wrote:

Hi All,

The are some issues arising in configurations whenever we move up on the versions(3.3 =3D> 3.4), because of the way we store and interpret them.

Whenever there is a new cluster level, you will need to add a new entry for all(most) of the configuration. Mostly a copy paste if you see from 3.2 to 3.3, except some CPU/PM type related configurations.
Better option would be to have the defaul config value in ConfigValues.java and the overrides will go to config.sql. In this approach you don't need a new entries to config.sql when there is a new cluster level.

Lets take an exmaple, "SupportForceCreateVG" - This is supported from 3.1 onwards,

If you look at config.sql, you will see following entries
select fn_db_add_config_value('SupportForceCreateVG','false','3.0');
select fn_db_add_config_value('SupportForceCreateVG','true','3.1');
select fn_db_add_config_value('SupportForceCreateVG','true','3.2');
select fn_db_add_config_value('SupportForceCreateVG','true','3.3');

And in ConfigValues.java

    @TypeConverterAttribute(Boolean.class)
    @DefaultValueAttribute("false")
    SupportForceCreateVG,

Now if there is 3.4 and 3.5, the user needs to add 2 more entries, which i feel is redundant.

Instead we can make

    @TypeConverterAttribute(Boolean.class)
    @DefaultValueAttribute("true")
    SupportForceCreateVG,

and have only the following in config.sql
select fn_db_add_config_value('SupportForceCreateVG','false','3.0');

if a particular value(for a specific cluster level) is not found in Config.sql, the fallback is to use the value available in ConfigValues.java.

Please share your thoughts on this.

<= br> Thanks,
Kanagaraj

_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel<=
/a>

--------------060202090604020609010600-- --===============8415757116208460904== Content-Type: multipart/alternative MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.bin" VGhpcyBpcyBhIG11bHRpLXBhcnQgbWVzc2FnZSBpbiBNSU1FIGZvcm1hdC4KLS0tLS0tLS0tLS0t LS0wNjAyMDIwOTA2MDQwMjA2MDkwMTA2MDAKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFy c2V0PUlTTy04ODU5LTE7IGZvcm1hdD1mbG93ZWQKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzog N2JpdAoKCk9uIDExLzI5LzIwMTMgMDE6NDYgUE0sIEthbmFnYXJhaiB3cm90ZToKPiBIaSBBbGws Cj4KPiBUaGUgYXJlIHNvbWUgaXNzdWVzIGFyaXNpbmcgaW4gY29uZmlndXJhdGlvbnMgd2hlbmV2 ZXIgd2UgbW92ZSB1cCBvbiAKPiB0aGUgdmVyc2lvbnMoMy4zID0+IDMuNCksIGJlY2F1c2Ugb2Yg dGhlIHdheSB3ZSBzdG9yZSBhbmQgaW50ZXJwcmV0IHRoZW0uCj4KPiBXaGVuZXZlciB0aGVyZSBp cyBhIG5ldyBjbHVzdGVyIGxldmVsLCB5b3Ugd2lsbCBuZWVkIHRvIGFkZCBhIG5ldyAKPiBlbnRy eSBmb3IgYWxsKG1vc3QpIG9mIHRoZSBjb25maWd1cmF0aW9uLiBNb3N0bHkgYSBjb3B5IHBhc3Rl IGlmIHlvdSAKPiBzZWUgZnJvbSAzLjIgdG8gMy4zLCBleGNlcHQgc29tZSBDUFUvUE0gdHlwZSBy ZWxhdGVkIGNvbmZpZ3VyYXRpb25zLgo+IEJldHRlciBvcHRpb24gd291bGQgYmUgdG8gaGF2ZSB0 aGUgZGVmYXVsIGNvbmZpZyB2YWx1ZSBpbiAKPiBDb25maWdWYWx1ZXMuamF2YSBhbmQgdGhlIG92 ZXJyaWRlcyB3aWxsIGdvIHRvIGNvbmZpZy5zcWwuIEluIHRoaXMgCj4gYXBwcm9hY2ggeW91IGRv bid0IG5lZWQgYSBuZXcgZW50cmllcyB0byBjb25maWcuc3FsIHdoZW4gdGhlcmUgaXMgYSAKPiBu ZXcgY2x1c3RlciBsZXZlbC4KPgo+IExldHMgdGFrZSBhbiBleG1hcGxlLCAiU3VwcG9ydEZvcmNl Q3JlYXRlVkciIC0gVGhpcyBpcyBzdXBwb3J0ZWQgZnJvbSAKPiAzLjEgb253YXJkcywKPgo+IElm IHlvdSBsb29rIGF0IGNvbmZpZy5zcWwsIHlvdSB3aWxsIHNlZSBmb2xsb3dpbmcgZW50cmllcwo+ IHNlbGVjdCBmbl9kYl9hZGRfY29uZmlnX3ZhbHVlKCdTdXBwb3J0Rm9yY2VDcmVhdGVWRycsJ2Zh bHNlJywnMy4wJyk7Cj4gc2VsZWN0IGZuX2RiX2FkZF9jb25maWdfdmFsdWUoJ1N1cHBvcnRGb3Jj ZUNyZWF0ZVZHJywndHJ1ZScsJzMuMScpOwo+IHNlbGVjdCBmbl9kYl9hZGRfY29uZmlnX3ZhbHVl KCdTdXBwb3J0Rm9yY2VDcmVhdGVWRycsJ3RydWUnLCczLjInKTsKPiBzZWxlY3QgZm5fZGJfYWRk X2NvbmZpZ192YWx1ZSgnU3VwcG9ydEZvcmNlQ3JlYXRlVkcnLCd0cnVlJywnMy4zJyk7Cj4KPiBB bmQgaW4gQ29uZmlnVmFsdWVzLmphdmEKPgo+ICAgICBAVHlwZUNvbnZlcnRlckF0dHJpYnV0ZShC b29sZWFuLmNsYXNzKQo+ICAgICBARGVmYXVsdFZhbHVlQXR0cmlidXRlKCJmYWxzZSIpCj4gICAg IFN1cHBvcnRGb3JjZUNyZWF0ZVZHLAo+Cj4gTm93IGlmIHRoZXJlIGlzIDMuNCBhbmQgMy41LCB0 aGUgdXNlciBuZWVkcyB0byBhZGQgMiBtb3JlIGVudHJpZXMsIAo+IHdoaWNoIGkgZmVlbCBpcyBy ZWR1bmRhbnQuCj4KPiBJbnN0ZWFkIHdlIGNhbiBtYWtlCj4KPiAgICAgQFR5cGVDb252ZXJ0ZXJB dHRyaWJ1dGUoQm9vbGVhbi5jbGFzcykKPiAgICAgQERlZmF1bHRWYWx1ZUF0dHJpYnV0ZSgidHJ1 ZSIpCj4gICAgIFN1cHBvcnRGb3JjZUNyZWF0ZVZHLAo+Cj4gYW5kIGhhdmUgb25seSB0aGUgZm9s bG93aW5nIGluIGNvbmZpZy5zcWwKPiBzZWxlY3QgZm5fZGJfYWRkX2NvbmZpZ192YWx1ZSgnU3Vw cG9ydEZvcmNlQ3JlYXRlVkcnLCdmYWxzZScsJzMuMCcpOwo+Cj4gaWYgYSBwYXJ0aWN1bGFyIHZh bHVlKGZvciBhIHNwZWNpZmljIGNsdXN0ZXIgbGV2ZWwpIGlzIG5vdCBmb3VuZCBpbiAKPiBDb25m aWcuc3FsLCB0aGUgZmFsbGJhY2sgaXMgdG8gdXNlIHRoZSB2YWx1ZSBhdmFpbGFibGUgaW4gCj4g Q29uZmlnVmFsdWVzLmphdmEuCj4KPiBQbGVhc2Ugc2hhcmUgeW91ciB0aG91Z2h0cyBvbiB0aGlz LgoKKzEKCj4KPiBUaGFua3MsCj4gS2FuYWdhcmFqCj4KPgo+Cj4gX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBFbmdpbmUtZGV2ZWwgbWFpbGluZyBsaXN0 Cj4gRW5naW5lLWRldmVsQG92aXJ0Lm9yZwo+IGh0dHA6Ly9saXN0cy5vdmlydC5vcmcvbWFpbG1h bi9saXN0aW5mby9lbmdpbmUtZGV2ZWwKCgotLS0tLS0tLS0tLS0tLTA2MDIwMjA5MDYwNDAyMDYw OTAxMDYwMApDb250ZW50LVR5cGU6IHRleHQvaHRtbDsgY2hhcnNldD1JU08tODg1OS0xCkNvbnRl bnQtVHJhbnNmZXItRW5jb2Rpbmc6IDdiaXQKCjxodG1sPgogIDxoZWFkPgogICAgPG1ldGEgY29u dGVudD0idGV4dC9odG1sOyBjaGFyc2V0PUlTTy04ODU5LTEiCiAgICAgIGh0dHAtZXF1aXY9IkNv bnRlbnQtVHlwZSI+CiAgPC9oZWFkPgogIDxib2R5IGJnY29sb3I9IiNGRkZGRkYiIHRleHQ9IiMw MDAwMDAiPgogICAgPGJyPgogICAgPGRpdiBjbGFzcz0ibW96LWNpdGUtcHJlZml4Ij5PbiAxMS8y OS8yMDEzIDAxOjQ2IFBNLCBLYW5hZ2FyYWoKICAgICAgd3JvdGU6PGJyPgogICAgPC9kaXY+CiAg ICA8YmxvY2txdW90ZSBjaXRlPSJtaWQ6NTI5ODRENDguMTA3MDAwOUByZWRoYXQuY29tIiB0eXBl PSJjaXRlIj4KICAgICAgPG1ldGEgaHR0cC1lcXVpdj0iY29udGVudC10eXBlIiBjb250ZW50PSJ0 ZXh0L2h0bWw7CiAgICAgICAgY2hhcnNldD1JU08tODg1OS0xIj4KICAgICAgSGkgQWxsLDxicj4K ICAgICAgPGJyPgogICAgICBUaGUgYXJlIHNvbWUgaXNzdWVzIGFyaXNpbmcgaW4gY29uZmlndXJh dGlvbnMgd2hlbmV2ZXIgd2UgbW92ZSB1cAogICAgICBvbiB0aGUgdmVyc2lvbnMoMy4zID0mZ3Q7 IDMuNCksIGJlY2F1c2Ugb2YgdGhlIHdheSB3ZSBzdG9yZSBhbmQKICAgICAgaW50ZXJwcmV0IHRo ZW0uPGJyPgogICAgICA8YnI+CiAgICAgIFdoZW5ldmVyIHRoZXJlIGlzIGEgbmV3IGNsdXN0ZXIg bGV2ZWwsIHlvdSB3aWxsIG5lZWQgdG8gYWRkIGEgbmV3CiAgICAgIGVudHJ5IGZvciBhbGwobW9z dCkgb2YgdGhlIGNvbmZpZ3VyYXRpb24uIE1vc3RseSBhIGNvcHkgcGFzdGUgaWYKICAgICAgeW91 IHNlZSBmcm9tIDMuMiB0byAzLjMsIGV4Y2VwdCBzb21lIENQVS9QTSB0eXBlIHJlbGF0ZWQKICAg ICAgY29uZmlndXJhdGlvbnMuPGJyPgogICAgICBCZXR0ZXIgb3B0aW9uIHdvdWxkIGJlIHRvIGhh dmUgdGhlIGRlZmF1bCBjb25maWcgdmFsdWUgaW4KICAgICAgQ29uZmlnVmFsdWVzLmphdmEgYW5k IHRoZSBvdmVycmlkZXMgd2lsbCBnbyB0byBjb25maWcuc3FsLiBJbiB0aGlzCiAgICAgIGFwcHJv YWNoIHlvdSBkb24ndCBuZWVkIGEgbmV3IGVudHJpZXMgdG8gY29uZmlnLnNxbCB3aGVuIHRoZXJl IGlzCiAgICAgIGEgbmV3IGNsdXN0ZXIgbGV2ZWwuPGJyPgogICAgICA8YnI+CiAgICAgIExldHMg dGFrZSBhbiBleG1hcGxlLCAiU3VwcG9ydEZvcmNlQ3JlYXRlVkciIC0gVGhpcyBpcyBzdXBwb3J0 ZWQKICAgICAgZnJvbSAzLjEgb253YXJkcyw8YnI+CiAgICAgIDxicj4KICAgICAgSWYgeW91IGxv b2sgYXQgY29uZmlnLnNxbCwgeW91IHdpbGwgc2VlIGZvbGxvd2luZyBlbnRyaWVzIDxicj4KICAg ICAgc2VsZWN0CiAgICAgIGZuX2RiX2FkZF9jb25maWdfdmFsdWUoJ1N1cHBvcnRGb3JjZUNyZWF0 ZVZHJywnZmFsc2UnLCczLjAnKTsgPGJyPgogICAgICBzZWxlY3QKICAgICAgZm5fZGJfYWRkX2Nv bmZpZ192YWx1ZSgnU3VwcG9ydEZvcmNlQ3JlYXRlVkcnLCd0cnVlJywnMy4xJyk7IDxicj4KICAg ICAgc2VsZWN0CiAgICAgIGZuX2RiX2FkZF9jb25maWdfdmFsdWUoJ1N1cHBvcnRGb3JjZUNyZWF0 ZVZHJywndHJ1ZScsJzMuMicpOyA8YnI+CiAgICAgIHNlbGVjdAogICAgICBmbl9kYl9hZGRfY29u ZmlnX3ZhbHVlKCdTdXBwb3J0Rm9yY2VDcmVhdGVWRycsJ3RydWUnLCczLjMnKTs8YnI+CiAgICAg IDxicj4KICAgICAgQW5kIGluIENvbmZpZ1ZhbHVlcy5qYXZhPGJyPgogICAgICA8YnI+CiAgICAg ICZuYnNwOyZuYnNwOyZuYnNwOyBAVHlwZUNvbnZlcnRlckF0dHJpYnV0ZShCb29sZWFuLmNsYXNz KTxicj4KICAgICAgJm5ic3A7Jm5ic3A7Jm5ic3A7IEBEZWZhdWx0VmFsdWVBdHRyaWJ1dGUoImZh bHNlIik8YnI+CiAgICAgICZuYnNwOyZuYnNwOyZuYnNwOyBTdXBwb3J0Rm9yY2VDcmVhdGVWRyw8 YnI+CiAgICAgIDxicj4KICAgICAgTm93IGlmIHRoZXJlIGlzIDMuNCBhbmQgMy41LCB0aGUgdXNl ciBuZWVkcyB0byBhZGQgMiBtb3JlIGVudHJpZXMsCiAgICAgIHdoaWNoIGkgZmVlbCBpcyByZWR1 bmRhbnQuPGJyPgogICAgICA8YnI+CiAgICAgIEluc3RlYWQgd2UgY2FuIG1ha2UgPGJyPgogICAg ICA8YnI+CiAgICAgICZuYnNwOyZuYnNwOyZuYnNwOyBAVHlwZUNvbnZlcnRlckF0dHJpYnV0ZShC b29sZWFuLmNsYXNzKTxicj4KICAgICAgJm5ic3A7Jm5ic3A7Jm5ic3A7IEBEZWZhdWx0VmFsdWVB dHRyaWJ1dGUoInRydWUiKTxicj4KICAgICAgJm5ic3A7Jm5ic3A7Jm5ic3A7IFN1cHBvcnRGb3Jj ZUNyZWF0ZVZHLDxicj4KICAgICAgPGJyPgogICAgICBhbmQgaGF2ZSBvbmx5IHRoZSBmb2xsb3dp bmcgaW4gY29uZmlnLnNxbDxicj4KICAgICAgc2VsZWN0CiAgICAgIGZuX2RiX2FkZF9jb25maWdf dmFsdWUoJ1N1cHBvcnRGb3JjZUNyZWF0ZVZHJywnZmFsc2UnLCczLjAnKTs8YnI+CiAgICAgIDxi cj4KICAgICAgaWYgYSBwYXJ0aWN1bGFyIHZhbHVlKGZvciBhIHNwZWNpZmljIGNsdXN0ZXIgbGV2 ZWwpIGlzIG5vdCBmb3VuZAogICAgICBpbiBDb25maWcuc3FsLCB0aGUgZmFsbGJhY2sgaXMgdG8g dXNlIHRoZSB2YWx1ZSBhdmFpbGFibGUgaW4KICAgICAgQ29uZmlnVmFsdWVzLmphdmEuPGJyPgog ICAgICA8YnI+CiAgICAgIFBsZWFzZSBzaGFyZSB5b3VyIHRob3VnaHRzIG9uIHRoaXMuPGJyPgog ICAgPC9ibG9ja3F1b3RlPgogICAgPGJyPgogICAgKzE8YnI+CiAgICA8YnI+CiAgICA8YmxvY2tx dW90ZSBjaXRlPSJtaWQ6NTI5ODRENDguMTA3MDAwOUByZWRoYXQuY29tIiB0eXBlPSJjaXRlIj4g PGJyPgogICAgICBUaGFua3MsPGJyPgogICAgICBLYW5hZ2FyYWo8YnI+CiAgICAgIDxicj4KICAg ICAgPG1ldGEgaHR0cC1lcXVpdj0iY29udGVudC10eXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7CiAg ICAgICAgY2hhcnNldD1JU08tODg1OS0xIj4KICAgICAgPGJyPgogICAgICA8ZmllbGRzZXQgY2xh c3M9Im1pbWVBdHRhY2htZW50SGVhZGVyIj48L2ZpZWxkc2V0PgogICAgICA8YnI+CiAgICAgIDxw cmUgd3JhcD0iIj5fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpFbmdpbmUtZGV2ZWwgbWFpbGluZyBsaXN0CjxhIGNsYXNzPSJtb3otdHh0LWxpbmstYWJicmV2 aWF0ZWQiIGhyZWY9Im1haWx0bzpFbmdpbmUtZGV2ZWxAb3ZpcnQub3JnIj5FbmdpbmUtZGV2ZWxA b3ZpcnQub3JnPC9hPgo8YSBjbGFzcz0ibW96LXR4dC1saW5rLWZyZWV0ZXh0IiBocmVmPSJodHRw Oi8vbGlzdHMub3ZpcnQub3JnL21haWxtYW4vbGlzdGluZm8vZW5naW5lLWRldmVsIj5odHRwOi8v bGlzdHMub3ZpcnQub3JnL21haWxtYW4vbGlzdGluZm8vZW5naW5lLWRldmVsPC9hPgo8L3ByZT4K ICAgIDwvYmxvY2txdW90ZT4KICAgIDxicj4KICA8L2JvZHk+CjwvaHRtbD4KCi0tLS0tLS0tLS0t LS0tMDYwMjAyMDkwNjA0MDIwNjA5MDEwNjAwLS0K --===============8415757116208460904==--