Any update? 
If we can't solve it soon, I suggest to revert the patch for running log collector in the meantime, because we risk of having new regression coming it,
and its our only way to verifying if master is broken or not.

Another option is to move master to work with API V4, which we should do soon probably, but I don't know how long that can take and who can do it.

e/

On Mon, Sep 5, 2016 at 9:43 PM, Rafael Martins <rmartins@redhat.com> wrote:
----- Original Message -----
> From: "Juan Hernández" <jhernand@redhat.com>
> To: "Yaniv Kaul" <ykaul@redhat.com>
> Cc: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Rafael Martins" <rmartins@redhat.com>, "Ondra Machacek"
> <omachace@redhat.com>, "devel" <devel@ovirt.org>
> Sent: Friday, September 2, 2016 2:31:42 PM
> Subject: Re: [ovirt-devel] Failure in log collector on master: Failure fetching information about hypervisors from
> API. Error (ValueError): legacy is not a valid RngSource
>
> On 09/02/2016 02:24 PM, Yaniv Kaul wrote:
> > On Fri, Sep 2, 2016 at 3:14 PM, Juan Hernández <jhernand@redhat.com
> > <mailto:jhernand@redhat.com>> wrote:
> >
> >     On 09/02/2016 02:00 PM, Sandro Bonazzola wrote:
> >     >
> >     >
> >     > On Fri, Sep 2, 2016 at 1:38 PM, Yaniv Kaul <ykaul@redhat.com
> >     > <mailto:ykaul@redhat.com>
> >     > <mailto:ykaul@redhat.com <mailto:ykaul@redhat.com>>> wrote:
> >     >
> >     >     Log:
> >     >
> >     >     2016-09-02 07:26:52::ERROR::hypervisors::197::root:: Failure
> >     >     fetching information about hypervisors from API.
> >     >     Error (ValueError): legacy is not a valid RngSource
> >     >     2016-09-02 07:26:52::ERROR::__main__::1147::root::
> >     >     _get_hypervisors_from_api: legacy is not a valid RngSource
> >     >     2016-09-02 07:26:52::INFO::__main__::1424::root:: Gathering oVirt
> >     >     Engine information...
> >     >     2016-09-02 07:27:03::INFO::__main__::1398::root:: Gathering
> >     >     PostgreSQL the oVirt Engine database and log files from
> >     >     localhost...
> >     >     2016-09-02 07:27:05::INFO::__main__::1859::root:: No hypervisors
> >     >     were selected, therefore no hypervisor data will be collected.
> >     >     2016-09-02 07:27:08::INFO::__main__::1862::root:: Log files have
> >     >     been collected and placed in
> >     >     /tmp/sosreport-LogCollector-20160902072705.tar.xz.
> >     >
> >     >
> >     >     I am not familiar with this error - first time I've seen it,
> >     >     while
> >     >     running on Master, on Lago (with a patch I'm working on - that
> >     >     adds
> >     >     DNS and IPv6 support to Lago, nothing more - doesn't seem
> >     >     relevant).
> >     >     Any idea?
> >     >
> >     >
> >     >
> >     > Probably a change in the API.
> >     > Rafael can you reproduce?
> >     >
> >     > Juan, Ondra, any insight?
> >     >
> >
> >     That means that the API is returning "legacy" as the value for
> >     something
> >     that is declared of type "RngSource", and the valid values for that are
> >     "random" and "hwrng". But the API can't return that, at least not
> >     version 4 of the API. Are you using engine 4? Can you share the output
> >     of the clusters resource?
> >
> >       https://.../ovirt-engine/api/clusters
> >
> >
> > Lago is still using the v3 API.
> > I'm not sure what the log collector is using. I assume[1] it's v4.
> >
> > Y.
> > [1]
> > https://github.com/oVirt/ovirt-log-collector/blob/dfaf35675bee3da1c53b4fd74b816efafa13d070/src/helper/hypervisors.py#L8
> >
>
> But the version of the engine should be 4, if I understand correctly,
> and SDK 4 should work correctly with that version of the engine. In
> addition, if it the engine is version 3 the SDK connection should have
> failed much earlier, during authentication.

Hi Juan,

I managed to reproduce this with "basic_suite_master" test from ovirt-system-tests, that uses everything from master branch. This means that engine version is 4, not 3. It seems to be an issue with engine/sdk, as the value is actually stored on engine as "legacy". Here you can find the xml output of the endpoints you asked: https://gist.github.com/rafaelmartins/60c21e158a9e6453c14a673f77693d61

Please let me know if you need anything else.

Thanks,
Rafael


> >
> >
> >     >
> >     >
> >     >
> >     >
> >     >     Y.
> >     >
> >     >
> >     >
> >     >
> >     > --
> >     > Sandro Bonazzola
> >     > Better technology. Faster innovation. Powered by community
> >     > collaboration.
> >     > See how it works at redhat.com <http://redhat.com>
> >     > <http://redhat.com>
> >     >
> >     <https://www.redhat.com/it/about/events/red-hat-open-source-day-2016
> >     <https://www.redhat.com/it/about/events/red-hat-open-source-day-2016>>
> >     >
> >     >
> >     > _______________________________________________
> >     > Devel mailing list
> >     > Devel@ovirt.org <mailto:Devel@ovirt.org>
> >     > http://lists.ovirt.org/mailman/listinfo/devel
> >     <http://lists.ovirt.org/mailman/listinfo/devel>
> >     >
> >
> >
> >     --
> >     Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta
> >     3ºD, 28016 Madrid, Spain
> >     Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat
> >     S.L.
> >
> >
>
>
> --
> Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta
> 3ºD, 28016 Madrid, Spain
> Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
>
_______________________________________________
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel





--
Eyal Edri
Associate Manager
RHV DevOps
EMEA ENG Virtualization R&D
Red Hat Israel

phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)