On Mon, Jul 16, 2018 at 8:59 AM Barak Korren <bkorren@redhat.com> wrote:On 15 July 2018 at 20:11, Nir Soffer <nsoffer@redhat.com> wrote:On Sun, Jul 15, 2018 at 6:51 PM Dan Kenigsberg <danken@redhat.com> wrote:May I repeat Nir's question: does it fail consistently?And are you rebased on master?Undefined command: "py-bt"Is a known xfail for FedoraOn Sun, Jul 15, 2018, 17:49 Eyal Shenitzky <eshenitz@redhat.com> wrote:According to the build log:make[1]: Leaving directory `/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/ vdsm' + debuginfo-install -y python Could not find debuginfo for main pkg: python-2.7.5-69.el7_5.x86_64 Could not find debuginfo pkg for dependency package python-libs-2.7.5-69.el7_5.x86_64 ============================================================ ==================== Package Arch Version Repository Size ============================================================ ==================== Installing: glibc-debuginfo x86_64 2.17-222.el7 centos-debuginfo 9.5 M yum-plugin-auto-update-debug-info noarch 1.1.31-45.el7 centos-base-el7 27 k Installing for dependencies: glibc-debuginfo-common x86_64 2.17-222.el7 centos-debuginfo 9.6 M Transaction Summary ============================================================ ==================== Install 2 Packages (+1 Dependent package)We could not find python debuginfo package, which explains why py-btwas missing.The build should fail in this case, but "yum install -y" does not fail when a packageis missing.Barak, can you suggest a way to fail the build if a package is missing?I suppose adding something like the following to the script would do the trick:
rpm -q $PACKAGE || exit 1Right, but we don't want to abort the build because python-debuginfo is missing.This is an issue only for pywatch_test.py, so we need to skip the relevant testswhen the package is not installed. We can use rpm -q to detect this situation.This is also an issue for the build, because we would not be able to providea backtrace when the build get stuck, but this practically never happens, sothere is no reason to fail the build.The real issue is why python-debuginfo is not available? is this a repo issue?issue with the way we try to install it?
On Sun, Jul 15, 2018 at 4:36 PM, Nir Soffer <nsoffer@redhat.com> wrote:On Sun, Jul 15, 2018 at 3:43 PM Eyal Shenitzky <eshenitz@redhat.com> wrote:Did someone encounter this failure?0.00s teardown tests/pywatch_test.py::TestPyWatch::test_kill_ grandkids =================================== FAILURES ============================== ===== ______________________ TestPyWatch.test_timeout_backtrace ______________________ self = <pywatch_test.TestPyWatch object at 0x7f0f730219d0> @pytest.mark.xfail(on_fedora(), reason="py-bt is broken on Fedora 27") def test_timeout_backtrace(self): script = ''' import time def outer(): inner() def inner(): time.sleep(10) outer() ''' rc, out, err = exec_cmd(['./py-watch', '0.1', 'python', '-c', script]) > assert b'in inner ()' in out E AssertionError: assert 'in inner ()' in '=========================================================== ==\n= Watched process timed out ... Terminating watched process =\n=========================== ============================== ====\n' pywatch_test.py:68: AssertionError ------------------------------ Captured log call ------------------------------- cmdutils.py 151 DEBUG ./py-watch 0.1 python -c ' import time def outer(): inner() def inner(): time.sleep(10) outer() ' (cwd None) cmdutils.py 159 DEBUG FAILED: <err> = 'Missing separate debuginfo for /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/ vdsm/.tox/lib-py27/bin/ python2.7\nTry: yum --enablerepo=\'*debug*\' install /usr/lib/debug/.build-id/db/ 43afedf61f35fbdf896c13894b501c b8bf1dad.debug\nUndefined command: "py-bt". Try "help".\n'; <rc> = 143 This used to work on el7. Does it fail in a consistent way now?Moving the discussion to devel, this is not storage specific.Nir--Regards,Eyal Shenitzky
--Barak Korren
RHV DevOps team , RHCE, RHCi
Red Hat EMEA
redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted