On Thu, Jun 28, 2018 at 2:17 PM Dan Kenigsberg <danken@redhat.com> wrote:
On Thu, Jun 28, 2018 at 12:52 PM, Nir Soffer <nsoffer@redhat.com> wrote:
> Trying to update vdsm master, my update script fail with:
>
> installing...
> error: Failed dependencies:
> vdsm = 4.30.0-429.git05bfb8731.fc28 is needed by (installed)
> vdsm-hook-fcoe-4.30.0-429.git05bfb8731.fc28.noarch
> vdsm = 4.30.0-429.git05bfb8731.fc28 is needed by (installed)
> vdsm-hook-ethtool-options-4.30.0-429.git05bfb8731.fc28.noarch
>
> I tried to remove these hooks, since I'm not interested in any of them, but
> removing them try to remove 136 packages including libvirt.
>
> Why do we have these dependencies? hook should be optional.
>
> Who owns these hooks?

git log can tell you the usual answer: I'm to blame.

These hooks implement documented features. I suspect that something
very basic - such as the ovirt-host package - requires them to ensure
that they exist on each host.

If the these hooks are required, we need to include them in the build
always - without using --enable-hooks. I think we did this with vmfex
hook.
 
We need an easy way to build vdsm from git and install it
on any decent platfrom. We can start by documenting the process.

Nir