On Thu, Aug 31, 2017 at 11:09 AM, Barak Korren <bkorren@redhat.com> wrote:

On 31 August 2017 at 11:54, Martin Perina <mperina@redhat.com> wrote:
> So with ovirt-ansible-roles-1.1.0 (which is the last offically relased
> version) everything runs fine and host is added properly (tested several
> times on CentOS 7.3)
>
> But we need to fix executing builds from github otherwise we cannot continue
> working with ovirt-ansible-roles in github:
>
> 1. If you add comment 'ci build please' to github PR, then build will be
> executed and the result will be a repo with RPM to be used in OST (but this
> build will not be passed to queue to be added to tested repo)
>
> 2. When PR is merged, then either automatically or by some other
> comment/action (available to maintainers only) build will be executed and if
> build is OK, it can be queued to be added to tested repo
>
> Without above we just cannot continue working on ovirt-ansible-roles on
> github.

We are working on that, but given that GitHub triggering work's quite
differently then Gerrit's, we need to rewrite some significant chunks
of code.

Tracker ticket is [1] or more specifically [2], [3] and [4]. We've
some pending patches for this, but we've not finished implementing all
required functionality yet.

[1]: https://ovirt-jira.atlassian.net/browse/OVIRT-1548
[2]: https://ovirt-jira.atlassian.net/browse/OVIRT-1547
[3]: https://ovirt-jira.atlassian.net/browse/OVIRT-1522
[4]: https://ovirt-jira.atlassian.net/browse/OVIRT-1486

As a temporary measure, we can disable the automated deployment from
jobs that run on PR messages. But this means that we will need to do
the deployment manually when needed.

Seems like good idea, as we really need to add to tested queue only merged PRs. How exactly will we be able to perform that manually?

--
Barak Korren
RHV DevOps team , RHCE, RHCi
Red Hat EMEA
redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted