On Tue, Mar 15, 2022 at 7:02 PM Nir Soffer <nsoffer@redhat.com> wrote:
>
> On Tue, Mar 15, 2022 at 6:10 PM Milan Zamazal <mzamazal@redhat.com> wrote:
> >
> > Hi,
> >
> > SonarClouds checks are run on the Vdsm GitHub repo, with occasional
> > failures, see for example https://github.com/oVirt/vdsm/pull/94 (I'm
> > pretty sure I've seen other similar failures recently, probably hidden
> > by later, successful runs). The failures report too many duplicate
> > lines in places completely unrelated to a given patch. This disturbs
> > CI reports.
> >
> > Does anybody know why SonarClouds checks are run on the Vdsm repo (they
> > don't seem to be run on other repos, e.g. ovirt-engine)? Are the checks
> > useful for anybody? If not, is it possible to disable them?
>
> I find these reports unhelpful.
>
> We don't have any control on the checks done, and we cannot disable them.
> Even when we had admin rights on the vdsm project, there was no way to disable
> this unwanted integration.
>
> We already use pylint and flake8 checks are part of vdsm CI workflow,
> and for these
> checks we have full control on what is checked, for example:
> https://github.com/oVirt/vdsm/blob/master/pylintrc
>
> +1 to remove this integration.
Sandro, do you know why SonarClouds is integrated in the vdsm project
and how to remove it?
Sandro Bonazzola
MANAGER, SOFTWARE ENGINEERING, EMEA R&D RHV