On Thu, 27 Sep 2018 15:28:02 +0100
Dafna Ron <dron@redhat.com> wrote:

> Hi,
>
> we are failing on ovirt-engine 4.1 on the upgrade suite.
>
> The issue seems to be related to this change:
> https://gerrit.ovirt.org/#/c/94551/ - packaging: Generate random MAC pool
> instead of hardcoded one
>
> Can you please have a look and issue a fix?
>
> Build log:
>
> https://jenkins.ovirt.org/job/ovirt-4.2_change-queue-tester/3234/testReport/junit/(root)/001_upgrade_engine/running_tests___upgrade_from_prevrelease_suite_el7_x86_64___test_initialize_engine/
>
> error:
>
> [ INFO  ] Yum Verify: 100/100: ovirt-engine-tools.noarch
> 0:4.1.9.1-1.el7.centos - ud
> [ INFO  ] Stage: Misc configuration
> [ INFO  ] Upgrading CA
> [ INFO  ] Installing PostgreSQL uuid-ossp extension into database
> [ INFO  ] Creating/refreshing DWH database schema
> [ INFO  ] Configuring WebSocket Proxy
> [ INFO  ] Creating/refreshing Engine database schema
> [ INFO  ] Creating/refreshing Engine 'internal' domain database schema
>           Unregistering existing client registration info.
> [ INFO  ] Creating default mac pool
> [ ERROR ] Failed to execute stage 'Misc configuration': insert or
> update on table "mac_pool_ranges" violates foreign key constraint
> "mac_pool_ranges_mac_pool_id_fkey"
>          DETAIL:  Key
> (mac_pool_id)=(58ca604b-017d-0374-0220-00000000014e) is not present in
> table "mac_pools".
>          CONTEXT:  SQL statement "INSERT INTO mac_pool_ranges (
>                  mac_pool_id,
>                  from_mac,
>                  to_mac
>                  )
>              VALUES (
>                  v_mac_pool_id,
>                  v_from_mac,
>                  v_to_mac
>                  )"
>          PL/pgSQL function insertmacpoolrange(uuid,character
> varying,character varying) line 3 at SQL statement
>
> [ INFO  ] Rolling back to the previous PostgreSQL instance (postgresql).
> [ INFO  ] Stage: Clean up
>           Log file is located at
> /var/log/ovirt-engine/setup/ovirt-engine-setup-20180927090017-97fd5u.log
> [ INFO  ] Generating answer file
> '/var/lib/ovirt-engine/setup/answers/20180927090149-setup.conf'
> [ INFO  ] Stage: Pre-termination
> [ INFO  ] Stage: Termination
> [ ERROR ] Execution of setup failed
> ('FATAL Internal error (main): insert or update on table
> "mac_pool_ranges" violates foreign key constraint
> "mac_pool_ranges_mac_pool_id_fkey"\nDETAIL:  Key
> (mac_pool_id)=(58ca604b-017d-0374-0220-00000000014e) is not present in
> table "mac_pools".\nCONTEXT:  SQL statement "INSERT INTO
> mac_pool_ranges (\n        mac_pool_id,\n        from_mac,\n
> to_mac\n        )\n    VALUES (\n        v_mac_pool_id,\n
> v_from_mac,\n        v_to_mac\n        )"\nPL/pgSQL function
> insertmacpoolrange(uuid,character varying,character varying) line 3 at
> SQL statement\n',)
>
> lago.ssh: DEBUG: Command 483aadd2 on
> lago-upgrade-from-prevrelease-suite-4-2-engine  errors:
>  Traceback (most recent call last):
>   File "/usr/lib/python2.7/site-packages/otopi/__main__.py", line 88, in main
>     installer.execute()
>   File "/usr/lib/python2.7/site-packages/otopi/main.py", line 157, in execute
>     self.context.runSequence()
>   File "/usr/lib/python2.7/site-packages/otopi/context.py", line 771,
> in runSequence
>     util.raiseExceptionInformation(infos[0])
>   File "/usr/lib/python2.7/site-packages/otopi/util.py", line 81, in
> raiseExceptionInformation
>     exec('raise info[1], None, info[2]')
>   File "/usr/lib/python2.7/site-packages/otopi/context.py", line 133,
> in _executeMethod
>     method['method']()
>   File "/usr/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-setup/ovirt-engine/network/macpools.py",
> line 98, in _misc_db_entries
>     self._create_new_mac_pool_range(range_prefix)
>   File "/usr/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-setup/ovirt-engine/network/macpools.py",
> line 73, in _create_new_mac_pool_range
>     to_mac=range_prefix + ':ff:ff',
>   File "/usr/share/ovirt-engine/setup/ovirt_engine_setup/engine_common/database.py",
> line 266, in execute
>     args,
> IntegrityError: insert or update on table "mac_pool_ranges" violates
> foreign key constraint "mac_pool_ranges_mac_pool_id_fkey"
> DETAIL:  Key (mac_pool_id)=(58ca604b-017d-0374-0220-00000000014e) is
> not present in table "mac_pools".
> CONTEXT:  SQL statement "INSERT INTO mac_pool_ranges (
>         mac_pool_id,
>         from_mac,
>         to_mac
>         )
>     VALUES (
>         v_mac_pool_id,
>         v_from_mac,
>         v_to_mac
>         )"
> PL/pgSQL function insertmacpoolrange(uuid,character varying,character
> varying) line 3 at SQL statement
>
>
> Thanks,
>
> Dafna

I will have a look.