On Mon, Oct 16, 2017 at 10:24 AM, Yedidyah Bar David <email@example.com> wrote:On Mon, Oct 16, 2017 at 10:21 AM, Yedidyah Bar David <firstname.lastname@example.org> wrote:On Mon, Oct 16, 2017 at 9:28 AM, Daniel Belenky <email@example.com> wrote:can someone address this issue? every patch to ovirt-engine that is based on top of this patch is failing OST and won't deploy to the tested repo.On Sun, Oct 15, 2017 at 9:33 AM, Daniel Belenky <firstname.lastname@example.org> wrote:Hi all,The following tests are failing both of the upgrade suites in OST (upgrade_from_release and upgrade_from_prevrelease).Link to console: ovirt-master_change-q
ueue-tester/3146/consoleLink to test logs:Suspected patch: https://gerrit.ovirt.or g/#/c/82615/5Please note that every patch that is based on top of the patch above was not deployed to the tested repo.Error snippet from engine setup log:Please add a direct link next time, if possible. This is it:
virt-master_change-queue-teste r/3146/artifact/exported-artif acts/upgrade-from-release-suit -master-el7/test_logs/upgrade- from-release-suite-master/ post-001_upgrade_engine.py/ lago-upgrade-from-release-suit e-master-engine/_var_log/ovirt -engine/setup/ovirt-engine- setup-20171013222617-73f0df. logAnd a bit above the snippet below, there is:
2017-10-13 22:26:24,274-0400 DEBUG otopi.plugins.ovirt_engine_set
up.ovirt_engine.upgrade.asynct asks plugin.execute:926 execute-output: ('/usr/share/ovirt-engine/setu p/dbutils/taskcleaner.sh', '-l', '/var/log/ovirt-engine/setup/o virt-engine-setup-201710132226 17-73f0df.log', '-u', 'engine', '-s', 'localhost', '-p', '5432', '-d', 'engine', '-q', '-r', '-Z') stderr:/usr/share/ovirt-engine/bin/ge nerate-pgpass.sh: line 3: /usr/share/ovirt-engine/setup/ dbutils/engine-prolog.sh: No such file or directory2017-10-13 22:26:24,274-0400 DEBUG otopi.context context._executeMethod:143 method exception Traceback (most recent call last): File "/usr/lib/python2.7/site-packa ges/otopi/context.py", line 133, in _executeMethod method['method']() File "/usr/share/ovirt-engine/setup /bin/../plugins/ovirt-engine-s etup/ovirt-engine/upgrade/asyn ctasks.py", line 470, in _validateZombies self._clearZombies() File "/usr/share/ovirt-engine/setup /bin/../plugins/ovirt-engine-s etup/ovirt-engine/upgrade/asyn ctasks.py", line 135, in _clearZombies 'Failed to clear zombie commands. ' RuntimeError: Failed to clear zombie commands. Please access support in attempt to resolve the problem 2017-10-13 22:26:24,275-0400 ERROR otopi.context context._executeMethod:152 Failed to execute stage 'Setup validation': Failed to clear zombie commands. Please access support in attempt to resolve the problemWith , taskcleaner.sh sources generate-pgpass.sh .
generate-pgpass.sh is in ovirt-engine-tools, which in upgrade flows, is notyet upgraded (at the point of above failure).
generate-pgpass.sh in 4.1 used to source engine-prolog.sh , using a pathrelative to "$0". In master it does not, but we now upgrade and it does.
This, in principle, is the core of the bug:A file, such as generate-pgpass.sh, that's supposed to be sourcedfrom some other files, should not by itself source other filesthat are relative to "$0", because it can't know what "$0" is - it'sthe path of the script sourcing it, not of itself.It seems like luckily we were not affected by this in 4.1, becauseall of the files that sourced generate-pgpass.sh were together withit in the same directory. But with , taskcleaner does too now,and is in a different directory.Not sure what's the best solution:
- revert  (and introduce it later on, in 4.3)
- patch 4.1's generate-pgpass.sh and require the fixed 4.1 version
in 4.2 setup- Somehow trick everything to work together? Not sure. Seems likeyou can't set $0.The same bug exists with unlock_entity:
https://gerrit.ovirt.org/82615So we should probably revert both.I tend to agree.Doesn't mean we cannot fix this for 4.2, but let's revert for the meantime.Y.
Devel mailing list