Patch on master merged , patch on 4.2 is waiting for CI and then will be merged

On Tue, Jun 12, 2018 at 1:00 PM, Dafna Ron <dron@redhat.com> wrote:
Hi Martin, Eli and Arik.

can you please give an update on this?

Is there a bug reported for this?

Thanks,
Danfa


On Fri, Jun 8, 2018 at 1:26 PM, Martin Perina <mperina@redhat.com> wrote:


On Fri, Jun 8, 2018 at 12:56 PM, Dafna Ron <dron@redhat.com> wrote:
can you please have a look?

​It's strange, because Eli manually verified upgrade OST for master and it worked.

But yeah, we know that provided fix didn't solve all cpu_name related issues and Eli is working on complete fix with Arik: https://gerrit.ovirt.org/#/c/92049/
Eli, please try to put maximum priority on it during Sunday and merge the fix if acked by Arik.
​
Thanks

Martin


Thanks,
Dafna


On Wed, Jun 6, 2018 at 11:03 AM, Dafna Ron <dron@redhat.com> wrote:
Thanks Eli.

On Wed, Jun 6, 2018 at 10:49 AM, Eli Mesika <emesika@redhat.com> wrote:
Hi Dafna

We are aware of that, the patch will be merged upstream ASAP and I sent a 4.2 patch as well , hope to have both merge soon

On Wed, Jun 6, 2018 at 11:45 AM, Dafna Ron <dron@redhat.com> wrote:
any idea when the fix will be merged? for now, ovirt-engine is broken.

On Tue, Jun 5, 2018 at 9:37 PM, Eli Mesika <emesika@redhat.com> wrote:
Yes I do

On Tue, Jun 5, 2018 at 7:20 PM, Martin Perina <mperina@redhat.com> wrote:


On Tue, Jun 5, 2018 at 5:08 PM, Dafna Ron <dron@redhat.com> wrote:
Eli, Martin,
Any updates?

​Eli, do you think that https://gerrit.ovirt.org/91968​ fixes also this OST failure?



On Tue, Jun 5, 2018 at 12:15 PM, Dafna Ron <dron@redhat.com> wrote:

Hi,


We have a failure in ovirt-engine on master on update cluster because of "cpu not found"

CQ reported the below as the most possible cause for the failure. I looked at the other changes that ran and I don't think any of them would be the cause of failure.

Can you please have a look at this issue?


Link and headline of suspected patches:

https://gerrit.ovirt.org/#/c/91888/ - db:fix upgrade issue on NULL values


Link to Job:


http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/8033/


Link to all logs:


http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/8033/artifact/exported-artifacts/basic-suit-master-el7/test_logs/basic-suite-master/post-002_bootstrap.py/


(Relevant) error snippet from the log:

<error>

2018-06-04 11:56:31,958-04 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (default task-13) [] EVENT_ID: USER_ADDED_CPU_PROFILE(10,130), CPU Profile test-cluster was successfully added (User: admin@internal-a
uthz).
2018-06-04 11:56:31,959-04 DEBUG [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor] (default task-13) [] method: runAction, params: [AddCpuProfile, CpuProfileParameters:{commandId='c76f8e59-c9a2-4601-964e-a92e9cb668ce',
 user='admin', commandType='Unknown'}], timeElapsed: 168ms
2018-06-04 11:56:31,974-04 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (default task-13) [] EVENT_ID: USER_ADD_CLUSTER(809), Cluster test-cluster was added by admin@internal-authz
2018-06-04 11:56:31,975-04 DEBUG [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor] (default task-13) [] method: runAction, params: [AddCluster, ManagementNetworkOnClusterOperationParameters:{commandId='3e0bf24c-4c49-40
94-928d-7c15ef50ff62', user='null', commandType='Unknown'}], timeElapsed: 272ms
2018-06-04 11:56:31,980-04 DEBUG [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor] (default task-13) [8ef59a69-020e-407c-9766-fbd3a6cc9381] method: runQuery, params: [GetClusterById, IdQueryParameters:{refresh='false',
 filtered='false'}], timeElapsed: 5ms


2018-06-04 11:57:19,857-04 DEBUG [org.ovirt.engine.core.dal.dbbroker.PostgresDbEngineDialect$PostgresSimpleJdbcCall] (default task-6) [72cc0877-c16d-4539-a3d0-90cd3c4a7a84] Compiled stored procedure. Call string is [{call getvdsbyclusteri
d(?, ?, ?)}]
2018-06-04 11:57:19,857-04 DEBUG [org.ovirt.engine.core.dal.dbbroker.PostgresDbEngineDialect$PostgresSimpleJdbcCall] (default task-6) [72cc0877-c16d-4539-a3d0-90cd3c4a7a84] SqlCall for procedure [GetVdsByClusterId] compiled
2018-06-04 11:57:19,878-04 DEBUG [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor] (default task-6) [72cc0877-c16d-4539-a3d0-90cd3c4a7a84] method: getAllForCluster, params: [9cbb05e6-680f-11e8-b07e-5452c0a8c904], timeE
lapsed: 25ms
2018-06-04 11:57:19,879-04 WARN [org.ovirt.engine.core.bll.UpdateClusterCommand] (default task-6) [72cc0877-c16d-4539-a3d0-90cd3c4a7a84] Validation of action 'UpdateCluster' failed for user admin@internal-authz. Reasons: VAR__TYPE__CLUST
ER,VAR__ACTION__UPDATE,VAR__TYPE__CLUSTER,ACTION_TYPE_FAILED_CPU_NOT_FOUND
2018-06-04 11:57:19,881-04 INFO [org.ovirt.engine.core.bll.UpdateClusterCommand] (default task-6) [72cc0877-c16d-4539-a3d0-90cd3c4a7a84] Lock freed to object 'EngineLock:{exclusiveLocks='[]', sharedLocks='[]'}'
2018-06-04 11:57:19,881-04 DEBUG [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor] (default task-6) [72cc0877-c16d-4539-a3d0-90cd3c4a7a84] method: runAction, params: [UpdateCluster, ManagementNetworkOnClusterOperationP
arameters:{commandId='36bf82e7-eec8-4b36-99af-db5ade902593', user='null', commandType='Unknown'}], timeElapsed: 58ms
2018-06-04 11:57:19,886-04 ERROR [org.ovirt.engine.api.restapi.resource.AbstractBackendResource] (default task-6) [] Operation Failed: [Cannot edit Cluster. The chosen CPU is not supported.]


</error>


Thanks,
Dafna





--
Martin Perina
Associate Manager, Software Engineering
Red Hat Czech s.r.o.








--
Martin Perina
Associate Manager, Software Engineering
Red Hat Czech s.r.o.