On Wed, Aug 17, 2016 at 2:25 PM, Nir Soffer <nsoffer@redhat.com> wrote:
On Wed, Aug 17, 2016 at 1:45 PM, Eyal Edri <eedri@redhat.com> wrote:
> I still thinks its a very valuable hook and we are aware of the fact it has
> bugs,  especially with patches on master branch and 4.0.
> Shlomi from the infra team is working on a solution for it as we speak and
> we hope to have a solution in the next few days,  however it's not trival to
> test and requires setting up a staging env and improve loga for the hooks
> system.

How do you plan to solve this?

Only the owner of the bug knows if the all the required patches are merged

The authors should use Bug-Url on the main bug and related-to: on other patches that are related.
and backported to the correct repositories.

This is done with logic according to the bug target milestone.

for e.g - a patch on branch 'ovirt-engine-4.0' was merged to bug targeted to ovirt-4.0.2.
The hook should check if branch 4.0.2 exists or not, if it exists then the bug should NOT move to MODIFIED, 
since it needs still backporting to ovirt-engine-4.0.2 branch. 

> On Aug 17, 2016 12:06 PM, "Eli Mesika" <emesika@redhat.com> wrote:
>> I also got this, especially when bugs should be back-ported
>> +1 for option #1
>> On Wed, Aug 17, 2016 at 10:10 AM, Yedidyah Bar David <didi@redhat.com>
>> wrote:
>>> Hi all,
>>> We currently have a bot that automatically moves bugs from POST to
>>> if all linked patches on gerrit are merged.
>>> It happened to me personally several times that this was a wrong thing to
>>> do,
>>> either because a new patch was still needed but not pushed yet, or
>>> because
>>> an existing patch should have been back-ported to another branch and
>>> wasn't
>>> yet. Since I usually pay more attention to my bug in POST, I sometimes
>>> missed
>>> this and handled the missing patches (backports, usually) later than I
>>> could
>>> if left on POST.
>>> I have a feeling I am not the only one. So I suggest to stop doing this.
>>> I can think of several alternatives:
>>> 1. Do nothing. I think that's reasonable - I think most people pay more
>>> attention to POST bugs anyway.
>>> 2. Set needinfo on bug owner.
>>> 3. Send some alert email to relevant people (bug owner, existing patches
>>> owners,
>>> perhaps others - e.g. reviewers of existing patches, perhaps those
>>> that actually reviewed, etc.). Need to think how to make it not too
>>> annoying for others but
>>> still effective also if owner is on long PTO or something like that. New
>>> flag
>>> doesn't have to be very specific - can be called something like
>>> 'attention
>>> needed' or something like that.
>>> 4. Add a new flag for that and set it. This will allow easier
>>> filtering/reporting.
>>> What do you think?
>>> --
>>> Didi
>>> _______________________________________________
>>> Devel mailing list
>>> Devel@ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/devel
>> _______________________________________________
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
> _______________________________________________
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel

Eyal Edri
Associate Manager
RHV DevOps
EMEA ENG Virtualization R&D
Red Hat Israel

phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)