It's most definitely not THAT patch.
Could be one of the earlier patches in the series, though.

Looking.

On Mon, Nov 13, 2017 at 10:54 AM, Barak Korren <bkorren@redhat.com> wrote:
On 13 November 2017 at 10:08, Nir Soffer <nsoffer@redhat.com> wrote:
>
>
> On Mon, Nov 13, 2017 at 9:56 AM Barak Korren <bkorren@redhat.com> wrote:
>>
>> Test failed: [ add_master_storage_domain ]
>>
>> Link to suspected patches:
>> - https://gerrit.ovirt.org/#/c/83849/4
>
>
> This fixes grammar in few error messages, I don't see how this can cause
> failures unless someone is depending on the error text...
>
Previous test with engine patches before it was successful:
http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/3769
This one included the following patches which were the two commits
leading up to the failing one:
- https://gerrit.ovirt.org/#/c/83920/4
- https://gerrit.ovirt.org/#/c/83918/2

Also following tests with no engine patches were also successful:
http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/3780/
so this eliminates suspicion for unrelated infra issues.

I think that is sufficient grounds for suspicion.

>>
>> This seems to be a fairly consistent regression as all patches that
>> follow the patch above exhibit the same issue when tested, this list
>> of similarly failing patches includes:
>> - https://gerrit.ovirt.org/#/c/83940/2
>> - https://gerrit.ovirt.org/#/c/83608/7
>> - https://gerrit.ovirt.org/#/c/83815/3
>> The following patch is an exception because it simply failed to build:
>> - https://gerrit.ovirt.org/#/c/83370/9
>>
>> Link to Job:
>> http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/3770/
>>
>> Link to all logs:
>>
>> http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/3770/artifact/exported-artifacts/basic-suit-master-el7/test_logs/basic-suite-master/post-002_bootstrap.py/
>>
>> Error snippet from log:
>>
>> <error>
>>
>> Fault reason is "Operation Failed". Fault detail is "[Failed to attach
>> Storage due to an error on the Data Center master Storage Domain.
>> -Please activate the master Storage Domain first.]". HTTP response code is
>> 409.
>>
>> </error>
>>
>>
>>
>> --
>> Barak Korren
>> RHV DevOps team , RHCE, RHCi
>> Red Hat EMEA
>> redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted
>> _______________________________________________
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel



--
Barak Korren
RHV DevOps team , RHCE, RHCi
Red Hat EMEA
redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted
_______________________________________________
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel