On 11/04/18 12:27 +0000, Nir Soffer wrote:
>On Wed, Apr 11, 2018 at 12:38 PM Eyal Edri <eedri@redhat.com> wrote:
>
>> On Wed, Apr 11, 2018 at 12:34 PM, Nir Soffer <nsoffer@redhat.com> wrote:
>>
>>> On Wed, Apr 11, 2018 at 12:31 PM Eyal Edri <eedri@redhat.com> wrote:
>>>
>>>> Please make sure to run as much OST suites on this patch as possible
>>>> before merging ( using 'ci please build' )
>>>>
>>>
>>> But note that OST is not a way to verify the patch.
>>>
>>> Such changes require testing with all storage types we support.
>>>
>>
>> Well, we already have HE suite that runs on ISCSI, so at least we have
>> NFS+ISCSI on nested,
>> for real storage testing, you'll have to do it manually
>>
>
>We need glusterfs (both native and fuse based), and cinder/ceph storage.
>
>But we cannot practically test all flows with all types of storage for
>every patch.

That leads to a question - how do I go around verifying such patch
without sufficient environment? Is there someone from storage QA that
could assist with this?

>Nir
>
>
>>
>>
>>>
>>> Nir
>>>
>>> On Tue, Apr 10, 2018 at 4:09 PM, Martin Polednik <mpolednik@redhat.com>
>>>> wrote:
>>>>
>>>>> Hey,
>>>>>
>>>>> I've created a patch[0] that is finally able to activate libvirt's
>>>>> dynamic_ownership for VDSM while not negatively affecting
>>>>> functionality of our storage code.
>>>>>
>>>>> That of course comes with quite a bit of code removal, mostly in the
>>>>> area of host devices, hwrng and anything that touches devices; bunch
>>>>> of test changes and one XML generation caveat (storage is handled by
>>>>> VDSM, therefore disk relabelling needs to be disabled on the VDSM
>>>>> level).
>>>>>
>>>>> Because of the scope of the patch, I welcome storage/virt/network
>>>>> people to review the code and consider the implication this change has
>>>>> on current/future features.
>>>>>
>>>>> [0] https://gerrit.ovirt.org/#/c/89830/
>>>>>
>>>>> mpolednik
>>>>> _______________________________________________
>>>>> Devel mailing list
>>>>> Devel@ovirt.org
>>>>> http://lists.ovirt.org/mailman/listinfo/devel
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> Eyal edri
>>>>
>>>>
>>>> MANAGER
>>>>
>>>> RHV DevOps
>>>>
>>>> EMEA VIRTUALIZATION R&D
>>>>
>>>>
>>>> Red Hat EMEA <https://www.redhat.com/>
>>>> <https://red.ht/sig> TRIED. TESTED. TRUSTED.
>>>> <https://redhat.com/trusted>
>>>> phone: +972-9-7692018 <+972%209-769-2018>
>>>> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>>>> _______________________________________________
>>>> Devel mailing list
>>>> Devel@ovirt.org
>>>> http://lists.ovirt.org/mailman/listinfo/devel
>>>
>>>
>>
>>
>> --
>>
>> Eyal edri
>>
>>
>> MANAGER
>>
>> RHV DevOps
>>
>> EMEA VIRTUALIZATION R&D
>>
>>
>> Red Hat EMEA <https://www.redhat.com/>
>> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
>> phone: +972-9-7692018 <+972%209-769-2018>
>> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>>