On Thu, Mar 26, 2020 at 12:26 PM Shmuel Melamud <smelamud@redhat.com> wrote:

Hi!

On Thu, Mar 26, 2020 at 12:24 PM Steven Rosenberg <srosenbe@redhat.com> wrote:
> Michal Skrivanek would like to remove the function from the AddClusterCommand altogether and leave it null until the first Host is up on a cluster.

But cluster's biosType is needed for creating and configuring VMs that
have CLUSTER_DEFAULT biosType. And VMs may be added to a cluster that
has no hosts.

Here is where we call AddCluster [0] and this code worked before mentioned patch.

[0] https://github.com/oVirt/ovirt-engine/blob/master/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/cluster/KubevirtProviderProxy.java#L189

Shmuel