On Wed, Jun 9, 2021 at 4:10 PM Martin Perina <mperina@redhat.com> wrote:

On Wed, Jun 9, 2021 at 2:44 PM Milan Zamazal <mzamazal@redhat.com> wrote:

Hi Scott,

ovirt-engine CI is failing, see
https://jenkins.ovirt.org/blue/organizations/jenkins/ovirt-engine_standard-check-patch/detail/ovirt-engine_standard-check-patch/12582/pipeline

The error is:

  UIMessagesTest.doTest:15 approveCertificateTrust does not match the number of parameters in UIMessages_cs_CZ.properties

Here is the fix, which restores new functionality:

https://gerrit.ovirt.org/c/ovirt-engine/+/115170

Thanks Martin!

I commented in the translation patch as it did pass CI:

Building UI Utils Compatibility (for UICommon)

...

[INFO] --- maven-surefire-plugin:2.22.0:test (default-test) @ uicompat --- [INFO] Tests are skipped.

IMO related to the flags we use in CI: 

make -j1 BUILD_GWT=1 BUILD_ALL_USER_AGENTS=0 BUILD_LOCALES=0 BUILD_UT=0 BUILD_VALIDATION=0 

Should we change the make flags in the CI?

  ...

Indeed, it seems the recently merged translation patch has dropped "{3}"
from approveCertificateTrust.  Could you please fix it so that
ovirt-engine CI works again?

Thanks,
Milan
_______________________________________________
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-leave@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/
List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/VVSEVCSWSBMVEASPHZBGIVF3EAPQ2KSJ/

--

Martin Perina
Manager, Software Engineering
Red Hat Czech s.r.o.

_______________________________________________
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-leave@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/
List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/C4YMU4PWCIMJRLRFOJYN3KSKQDCXU4RO/