On Thu, Apr 14, 2016 at 10:45 AM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
> I don't think this package is available in epel. if not, just remove it from
> py3 list
>
> about why we didn't catch it in jenkins - its because I don't run "make
> check" anymore over el7 to save resources. we just build the rpm there to
> see that we don't miss any dependencies.
> maybe we should bring back the make check there ... what do you think?
We should, make check takes about 1.5 minutes, typical build time is
about 10 minutes
fc23 build, with make check: 10:19
http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/5210/console
el7 build, no make check: 11:53
http://jenkins.ovirt.org/job/vdsm_master_check-patch-el7-x86_64/747/console
travis build: 3-4 minutes
https://travis-ci.org/nirs/vdsm/builds
The time of the tests does not make a real difference, and we know
that the (some) code
works on both platforms.
We should work on reducing the build time, 10 minutes for running
tests that take
1.5 minutes is crazy overhead.
Nir
>
> On Thu, Apr 14, 2016 at 10:26 AM, Francesco Romani <fromani@redhat.com>
> wrote:
>>
>>
>> ________________________________
>>
>> From: "Sandro Bonazzola" <sbonazzo@redhat.com>
>> To: "Francesco Romani" <fromani@redhat.com>
>> Cc: "Eyal Edri" <eedri@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>,
>> "devel" <devel@ovirt.org>, "Yaniv Bronheim" <ybronhei@redhat.com>, "Nir
>> Soffer" <nsoffer@redhat.com>
>> Sent: Thursday, April 14, 2016 9:13:04 AM
>>
>> Subject: Re: [ovirt-devel] [ACTION REQUIRED]
>> vdsm_master_build-artifacts-fc23-x86_64 is failing due to missing dep on
>> fc23 .packages
>>
>>
>>
>> On Thu, Apr 14, 2016 at 9:12 AM, Sandro Bonazzola <sbonazzo@redhat.com>
>> wrote:
>>>
>>>
>>>
>>> On Thu, Apr 14, 2016 at 9:01 AM, Francesco Romani <fromani@redhat.com>
>>> wrote:
>>>>
>>>>
>>>>
>>>> ________________________________
>>>>
>>>> From: "Eyal Edri" <eedri@redhat.com>
>>>> To: "Sandro Bonazzola" <sbonazzo@redhat.com>
>>>> Cc: "Dan Kenigsberg" <danken@redhat.com>, "devel" <devel@ovirt.org>,
>>>> "Yaniv Bronheim" <ybronhei@redhat.com>, "Nir Soffer" <nsoffer@redhat.com>,
>>>> "Francesco Romani" <fromani@redhat.com>
>>>> Sent: Thursday, April 14, 2016 8:54:50 AM
>>>> Subject: Re: [ovirt-devel] [ACTION REQUIRED]
>>>> vdsm_master_build-artifacts-fc23-x86_64 is failing due to missing dep on
>>>> fc23 .packages
>>>>
>>>>
>>>> Don't we run it per patch as well?
>>>> How did it got merged?
>>>>
>>>> On Apr 14, 2016 9:42 AM, "Sandro Bonazzola" <sbonazzo@redhat.com> wrote:
>>>>>
>>>>>
>>>>> http://jenkins.ovirt.org/job/vdsm_master_build-artifacts-fc23-x86_64/823/console
>>>>>
>>>>> 00:05:46.751
>>>>> ======================================================================
>>>>> 00:05:46.751 ERROR: Failure: ImportError (No module named 'netaddr')
>>>>> 00:05:46.751
>>>>> ----------------------------------------------------------------------
>>>>> 00:05:46.752 Traceback (most recent call last):
>>>>> 00:05:46.752 File "/usr/lib/python3.4/site-packages/nose/failure.py",
>>>>> line 39, in runTest
>>>>> 00:05:46.752 raise self.exc_val.with_traceback(self.tb)
>>>>> 00:05:46.752 File "/usr/lib/python3.4/site-packages/nose/loader.py",
>>>>> line 418, in loadTestsFromName
>>>>> 00:05:46.752 addr.filename, addr.module)
>>>>> 00:05:46.752 File
>>>>> "/usr/lib/python3.4/site-packages/nose/importer.py", line 47, in
>>>>> importFromPath
>>>>> 00:05:46.752 return self.importFromDir(dir_path, fqname)
>>>>> 00:05:46.752 File
>>>>> "/usr/lib/python3.4/site-packages/nose/importer.py", line 94, in
>>>>> importFromDir
>>>>> 00:05:46.753 mod = load_module(part_fqname, fh, filename, desc)
>>>>> 00:05:46.753 File "/usr/lib64/python3.4/imp.py", line 235, in
>>>>> load_module
>>>>> 00:05:46.753 return load_source(name, filename, file)
>>>>> 00:05:46.753 File "/usr/lib64/python3.4/imp.py", line 171, in
>>>>> load_source
>>>>> 00:05:46.753 module = methods.load()
>>>>> 00:05:46.753 File "<frozen importlib._bootstrap>", line 1220, in load
>>>>> 00:05:46.753 File "<frozen importlib._bootstrap>", line 1200, in
>>>>> _load_unlocked
>>>>> 00:05:46.753 File "<frozen importlib._bootstrap>", line 1129, in
>>>>> _exec
>>>>> 00:05:46.753 File "<frozen importlib._bootstrap>", line 1471, in
>>>>> exec_module
>>>>> 00:05:46.754 File "<frozen importlib._bootstrap>", line 321, in
>>>>> _call_with_frames_removed
>>>>> 00:05:46.754 File
>>>>> "/home/jenkins/workspace/vdsm_master_build-artifacts-fc23-x86_64/vdsm/rpmbuild/BUILD/vdsm-4.17.999/tests/network/models_test.py",
>>>>> line 27, in <module>
>>>>> 00:05:46.754 from vdsm.netinfo import bonding, mtus
>>>>> 00:05:46.754 File
>>>>> "/home/jenkins/workspace/vdsm_master_build-artifacts-fc23-x86_64/vdsm/rpmbuild/BUILD/vdsm-4.17.999/lib/vdsm/netinfo/__init__.py",
>>>>> line 26, in <module>
>>>>> 00:05:46.754 from .ipwrapper import DUMMY_BRIDGE
>>>>> 00:05:46.755 File
>>>>> "/home/jenkins/workspace/vdsm_master_build-artifacts-fc23-x86_64/vdsm/rpmbuild/BUILD/vdsm-4.17.999/lib/vdsm/ipwrapper.py",
>>>>> line 30, in <module>
>>>>> 00:05:46.755 from netaddr.core import AddrFormatError
>>>>> 00:05:46.755 ImportError: No module named 'netaddr'
>>>>>
>>>>>
>>>>>
>>>>> Please fix ASAP.
>>>>
>>>>
>>>> I think this a jenkins failure, because this seems to come from (lack
>>>> of) netaddr package, which is an external package Vdsm depends on since ages
>>>> (late 2013!)
>>>
>>>
>>> I think it's a missing dep in build-artifacts.packages
>>
>>
>> forgot to mention, please note it's the python3 package missing.
>>
>>
>> yep, I think you are right. Most likely broken by
>> https://gerrit.ovirt.org/#/c/55896/
>>
>> Let me quickly post a patch for this.
>>
>> Bests,
>>
>>
>> --
>> Francesco Romani
>> RedHat Engineering Virtualization R & D
>> Phone: 8261328
>> IRC: fromani
>
>
>
>
> --
> Yaniv Bronhaim.