On Wed, Nov 28, 2018 at 12:03 PM Edward Haas <edwardh@redhat.com> wrote:

On Wed, Nov 28, 2018 at 11:28 AM Marcin Sobczyk <msobczyk@redhat.com> wrote:

How much value does it add comparing to check-patch?

If we can hold for a while with pulling the plug, I can try to split it into substages in stdci v2 and see if things stabilize a bit.

I would prefer we first work with stdci v2 in order to move the functional tests there (or at least play with it).
Then we can remove it.

Turns out that this worth with stdci v2 - if check-merged fail, the change queue

will reject the patch.

See this mail from infra@ovirt.org mailing list:

Change 95559,13 (vdsm) is probably the reason behind recent system test
failures in the "ovirt-master" change queue and needs to be fixed.

This change had been removed from the testing queue. Artifacts build from this
change will not be released until it is fixed.

For further details about the change see:
https://gerrit.ovirt.org/#/c/95559/13

According to Dafna and Barak, change queue require that all jobs pass, so we cannot

have flaky job in the build.

I hopefully removed it from stdci v2 here:

https://gerrit.ovirt.org/c/95845/

I don't think we should even enable check-merged again. All tests must run *before* we

merge. When cannot work with a job that will randomly fail after merge.

Nir