On Wed, 12 Dec 2018, 22:42 Marcin Sobczyk <msobczyk@redhat.com wrote:

Hi,

I've been working on adding coverage report for VDSM in OST

recently, and I'm happy to announce, that the first batch of patches is merged!

To run a suite with coverage, look for 'COVERAGE' drop-down on OST's

build parameters page. If you run OST locally, pass a '--coverage' argument to 'run_suite.sh'.

Currently, coverage works only for VDSM in basic-suite-master, but adding

VDSM support for other suites is now a no-brainer. More patches are on the way!

Since the option is named 'COVERAGE', and not 'VDSM_COVERAGE', other projects

are welcome to implement their coverage reports on top of it.

Cheers, Marcin

Awesome indeed. I was not aware there's a way to add such parameters to suites. It could come up handy elsewhere (e.g. choosing ovs for cluster switchtype)

I think it is important to explain why it's so important.

Unfortunately, much of vdsm functionalily is not covered by proper vdsm unit tests. We depend on OST to define what is a "working" ovirt.

Here's a message for us vdsm developers: if you care for your code and the time you've invested into it, make sure that it shows up green on the likes of https://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/3754/artifact/exported-artifacts/coverage/vdsm/html/index.html

The total number - 59% - is not brilliant, but not as bad as I assumed.

Please go over the report. There are glaring missing pieces (e.g gluster, fencing) but also less obvious ones (almost half of vm.py).

It should give you ideas about tests you need to add, or code you can drop.