Why do we need to wait for a review and not revert the offending patch in the meantime? 

On Sun, Dec 25, 2016 at 4:26 PM, Dan Kenigsberg <danken@redhat.com> wrote:
On Sun, Dec 25, 2016 at 3:59 PM, Dan Kenigsberg <danken@redhat.com> wrote:
> On Sun, Dec 25, 2016 at 3:40 PM, Barak Korren <bkorren@redhat.com> wrote:
>>>
>>> Can you tell if /var/run/vdsm/svdsm.sock exists?
>>
>> # ls -l /var/run/vdsm/svdsm.sock
>> ls: cannot access /var/run/vdsm/svdsm.sock: No such file or directory
>>
>>> What's `ls -lZ /var/run/vdsm` ?
>>
>> # ls -lZ /var/run/vdsm
>> ls: cannot access /var/run/vdsm: No such file or directory
>>
>>> Can you manually run supervdsmServer --sockfile=/var/run/vdsm/svdsm.sock
>>> on that host?
>>
>> I get this:
>>
>> [2016-12-25 08:39:01,224 pyinotify ERROR] add_watch: cannot watch
>> /var/run/vdsm/sourceRoutes WD=-1, Errno=Not a directory (ENOTDIR)
>> Exception in thread sourceRoute:
>> Traceback (most recent call last):
>>   File "/usr/lib64/python2.7/threading.py", line 811, in __bootstrap_inner
>>     self.run()
>>   File "/usr/lib64/python2.7/threading.py", line 764, in run
>>     self.__target(*self.__args, **self.__kwargs)
>>   File "/usr/lib/python2.7/site-packages/vdsm/utils.py", line 368, in wrapper
>>     return f(*a, **kw)
>>   File "/usr/lib/python2.7/site-packages/vdsm/network/sourceroutethread.py",
>> line 90, in _subscribeToInotifyLoop
>>     for filePath in sorted(os.listdir(SOURCE_ROUTES_FOLDER)):
>> OSError: [Errno 20] Not a directory: '/var/run/vdsm/sourceRoutes'
>
> Now that's completely my fault.
>
> I probably did not verify https://gerrit.ovirt.org/#/c/68662/ on a
> clean installation.
>
> Barak, do you know if there's a standard way of triggering
> systemd-tmpfiles in %post ?
>
> https://gerrit.ovirt.org/#/c/69092/ would revert my offending patch.

But https://gerrit.ovirt.org/#/c/69093/1/vdsm.spec.in may be a proper
fix. Would you care to review?
_______________________________________________
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel





--
Eyal Edri
Associate Manager
RHV DevOps
EMEA ENG Virtualization R&D
Red Hat Israel

phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)