Thanks, I'll check it out. 

On Wed, May 15, 2019 at 6:02 PM Nir Soffer <nsoffer@redhat.com> wrote:
On Wed, May 15, 2019 at 4:28 PM Amit Bawer <abawer@redhat.com> wrote:
Hi,

I am trying to follow the basic procedure described here

This is not a good place to look for the instructions. The right place is:
 
to build vdsm rpm from source on my CentOS Linux release 7.6.1810 (Core) host.
had to add some dependencies on the way ofcourse, so at that point i am  able to make most of it except for python error described below resulting from the "make rpm" part of procedure.

Am I missing something?

This is a good topic for devel, adding.
 

Thanks

make[1]: Entering directory `/home/abawer/rpmbuild/BUILD/vdsm-4.40.0'
Makefile:1002: warning: overriding recipe for target `check-recursive'
Makefile:533: warning: ignoring old recipe for target `check-recursive'
Making all in contrib
make[2]: Entering directory `/home/abawer/rpmbuild/BUILD/vdsm-4.40.0/contrib'
make[2]: Nothing to be done for `all'.
make[2]: Leaving directory `/home/abawer/rpmbuild/BUILD/vdsm-4.40.0/contrib'
Making all in helpers
make[2]: Entering directory `/home/abawer/rpmbuild/BUILD/vdsm-4.40.0/helpers'
make[2]: Nothing to be done for `all'.
make[2]: Leaving directory `/home/abawer/rpmbuild/BUILD/vdsm-4.40.0/helpers'
Making all in init
make[2]: Entering directory `/home/abawer/rpmbuild/BUILD/vdsm-4.40.0/init'
Making all in systemd
make[3]: Entering directory `/home/abawer/rpmbuild/BUILD/vdsm-4.40.0/init/systemd'
  MKDIR_P ./
  SED vdsm-tmpfiles.d.conf
make[3]: Leaving directory `/home/abawer/rpmbuild/BUILD/vdsm-4.40.0/init/systemd'
make[3]: Entering directory `/home/abawer/rpmbuild/BUILD/vdsm-4.40.0/init'
  MKDIR_P ./
  SED vdsmd_init_common.sh
make[3]: Leaving directory `/home/abawer/rpmbuild/BUILD/vdsm-4.40.0/init'
make[2]: Leaving directory `/home/abawer/rpmbuild/BUILD/vdsm-4.40.0/init'
Making all in lib
make[2]: Entering directory `/home/abawer/rpmbuild/BUILD/vdsm-4.40.0/lib'
Making all in sos
make[3]: Entering directory `/home/abawer/rpmbuild/BUILD/vdsm-4.40.0/lib/sos'
  MKDIR_P ./
  SED vdsm.py
make[3]: Leaving directory `/home/abawer/rpmbuild/BUILD/vdsm-4.40.0/lib/sos'
Making all in vdsm
make[3]: Entering directory `/home/abawer/rpmbuild/BUILD/vdsm-4.40.0/lib/vdsm'
Making all in api
make[4]: Entering directory `/home/abawer/rpmbuild/BUILD/vdsm-4.40.0/lib/vdsm/api'
  Generate vdsm-api.html
chmod u+w .
PYTHONPATH=./../../:./../../vdsm \
    python2.7 ./schema_to_html.py vdsm-api ./vdsm-api.html
Traceback (most recent call last):
  File "./schema_to_html.py", line 250, in <module>
    main()
  File "./schema_to_html.py", line 240, in main
    choices=[st.value for st in vdsmapi.SchemaType])
TypeError: 'type' object is not iterable

Never had this error.

After you prepare the host as described in:

is to install latest release of vdsm:

    yum install vdsm vdsm-client

Otherwise you will have to painfully install some of the packages or install lot of packages you
don't need (e.g. mostly lot of hooks).

When your host is ready, you can build vdsm from source and upgrade the installed packages:

    git clean -dxf
    ./autogen.sh --system --enable-timestamp
    make
    rm -rf ~/rpmbuild
    make rpm
    (cd ~/rpmbuild/RPMS && sudo yum upgrade */*.rpm)

I think we should drop instructions in vdsm README, and point to the page on ovirt.org,
or replace them with short version that works and easier to maintain.

Nir