Il giorno lun 27 apr 2020 alle ore 17:33 Vojtech Juranek <vjuranek@redhat.com> ha scritto:
> > I'll, but need to look more into it, replacing $(PREFIX) with
> > $(SYSCONF_DIR)
> > doesn't seem to work as SYSCONF_DIR=$(PREFIX)/etc (see https://github.com/
> > oVirt/ovirt-engine/blob/master/Makefile#L41
> > <https://github.com/oVirt/ovirt-engine/blob/master/Makefile#L41>), so we
> > will end up again with /
> > usr/etc. We will probably have to do it as VMCONSOLE_* variable - hardcode
> > config file and define new just install-dev environment (and do the proper
> > testing before merge)
>
> No. SYSCONF_DIR=$(PREFIX)/etc allow you to set PREFIX for developer work.

isn't it overwritten here:
https://github.com/oVirt/ovirt-engine/blob/master/Makefile#L37
?

parameters passed to make command are overriding those included in Makefile so no, it's not overwritten.
 

I posted https://gerrit.ovirt.org//c/108672/ which does it in the same way as
ovirt-vmconsole, but if you prefer using SYSCONFIG_DIR and it work in all
cases, no problem to change it this way

No strong preference, if this works I'm fine keeping it.
 

> But then in spec file it's overridden:
> SYSCONF_DIR=%{_sysconfdir}
> $ rpm --eval "%{_sysconfdir}"
> /etc


--