Hello All.

I have checked the hooks code. And it indeed just extracts all the links pointing to bugzilla. This is not correct and fails when somebody just mentions a bug in commit message.

We are about to fix this and adjust the regexp used to explicitly check for "Bug-Url" keyword. I think this is the expected behavior for everybody. 

But just in case I am sending this pre-announcement about the change. Let me know if you anticipate any problems.

Thanks. 

On Tue, Feb 5, 2019 at 10:16 AM Nir Soffer <nsoffer@redhat.com> wrote:
If a commit message mention another bug, the CI script try to add the patch
to the bug in the commit message, and change the bug to POST.

Mentioning another bug in a commit message is good practice, making it
easier to follow, and avoiding unclear forms like "bug 1000000" or "BZ#1000000",
or even worse shortened urls like https://goo.gl/bPuFGo.

Does it make sense that we cannot link to Red Hat bugzilla like god
intended?

Here is a proof:

    gerrit-hooks
    Patch Set 1:

    Check Bug-Url::10000000::WARN, failed to get bug info (private bug or bug doesn't exist
    Check Product::IGNORE, not relevant for branch: master
    Check TM::IGNORE, not relevant for branch: master
    Check Backport::IGNORE, not relevant for branch: master
    Set POST::#10000000::WARN, failed to get bug info (private bug or bug doesn't exist)
    Update Tracker::#10000000::WARN, failed to get bug info (private bug or bug doesn't exist)
    CI scripts should process urls only inside Bug-Url: tag.

Expected behavior:
Extract bug urls *only* from Bug-Url: label.

The same issue exists with Related-To: label.

This is not a new bug. I reported it few years ago but for some reason the issue
was not understood.

Nir
_______________________________________________
Infra mailing list -- infra@ovirt.org
To unsubscribe send an email to infra-leave@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/
List Archives: https://lists.ovirt.org/archives/list/infra@ovirt.org/message/YZKHQTISCF6W3GNXOTWWO3IE4T24SZQQ/


--
Anton Marchukov
Team Lead - Release Management - RHV DevOps - Red Hat