On Tue, Jun 4, 2019, 08:57 Sandro Bonazzola <sbonazzo@redhat.com> wrote:


Il giorno mar 4 giu 2019 alle ore 06:44 Dan Kenigsberg <danken@redhat.com> ha scritto:


On Tue, 4 Jun 2019, 1:14 Nir Soffer, <nsoffer@redhat.com> wrote:


On Tue, Jun 4, 2019 at 12:56 AM Nir Soffer <nsoffer@redhat.com> wrote:
On Mon, Jun 3, 2019 at 8:04 PM Nir Soffer <nsoffer@redhat.com> wrote:


On Mon, Jun 3, 2019, 18:12 Sandro Bonazzola <sbonazzo@redhat.com> wrote:
Hi,
just to let you know that vdsm jsut broke hosted engine on fedora.
Reason is that hosted engine is still building for python2 whiile vdsm is now being shipped for python3 only.

Thats a bug, vdsm should build for both 2 and 3 on Fedora 28. We should switch theses builds to Fedora 29 soon.

Vdsm is built for both python 2 and 3 on Fedora 28 - here is build from master
(with 2 unelated patches):

Maybe this is an issue in the code publishing builds to the repo?

The issue is that we create packages with the same name for both python 2.7 and 3.6.

When we publish both packages to the repo, one of the versions overwrite the other, so
we are left only python 2.7 or 3.6 or some random mix :-)

We need to name all packages with python2 or python3 prefix. Until this is fixed we should
disable the python 3.6 builds since they cannot work anyway at this point.

Renaming is a real pain. Can we simply place the py3 rpms in a different directory of build artifacts?

Renaming is still mandatory for Fedora inclusion of vdsm package.
You can limit python3 build to Fedora 30 and keep python2 to older Fedoras

We can rename only the python 3 packages to limit the pain.

 

 


hosted engine build is currently broken on missing yajsonrpc being:

$ rpm -ql https://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/fc28/noarch/vdsm-yajsonrpc-4.40.0-309.git0371e7531.fc28.noarch.rpm
/usr/lib/python3.6/site-packages/yajsonrpc/__pycache__/betterAsyncore.cpython-36.opt-1.pyc
/usr/lib/python3.6/site-packages/yajsonrpc/__pycache__/betterAsyncore.cpython-36.pyc
/usr/lib/python3.6/site-packages/yajsonrpc/__pycache__/exception.cpython-36.opt-1.pyc
/usr/lib/python3.6/site-packages/yajsonrpc/__pycache__/exception.cpython-36.pyc
/usr/lib/python3.6/site-packages/yajsonrpc/__pycache__/stomp.cpython-36.opt-1.pyc
/usr/lib/python3.6/site-packages/yajsonrpc/__pycache__/stomp.cpython-36.pyc
/usr/lib/python3.6/site-packages/yajsonrpc/__pycache__/stompclient.cpython-36.opt-1.pyc
/usr/lib/python3.6/site-packages/yajsonrpc/__pycache__/stompclient.cpython-36.pyc
/usr/lib/python3.6/site-packages/yajsonrpc/__pycache__/stompserver.cpython-36.opt-1.pyc
/usr/lib/python3.6/site-packages/yajsonrpc/__pycache__/stompserver.cpython-36.pyc
/usr/lib/python3.6/site-packages/yajsonrpc/betterAsyncore.py
/usr/lib/python3.6/site-packages/yajsonrpc/exception.py
/usr/lib/python3.6/site-packages/yajsonrpc/stomp.py
/usr/lib/python3.6/site-packages/yajsonrpc/stompclient.py
/usr/lib/python3.6/site-packages/yajsonrpc/stompserver.py

please note that package naming for this package is not following Fedora guidelines. It should be prefixed with "python3-" according to https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming
Rule doesn't apply to applications but yajsonrpc subpackage is a library package.

--

Sandro Bonazzola

MANAGER, SOFTWARE ENGINEERING, EMEA R&D RHV

Red Hat EMEA

sbonazzo@redhat.com   

_______________________________________________
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-leave@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/
List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/334BHJFEYEODVO6D3FSYI7CPZUGS2S7I/


--

Sandro Bonazzola

MANAGER, SOFTWARE ENGINEERING, EMEA R&D RHV

Red Hat EMEA

sbonazzo@redhat.com