On Wed, Mar 20, 2019 at 5:17 PM Sandro Bonazzola <sbonazzo@redhat.com> wrote:
Il giorno lun 18 mar 2019 alle ore 09:42 Sandro Bonazzola <sbonazzo@redhat.com> ha scritto:Hi, didn't got a reply to this, raising again.Il giorno ven 8 mar 2019 alle ore 14:54 Sandro Bonazzola <sbonazzo@redhat.com> ha scritto:Hi,just noticed today we are building on master a package named ovirt-jboss-modules-maven-plugin.The package is not required by any other package at spec file / rpm level and it has never been shipped in an official release as far as I can tell.Grep says we are using a java package through maven called ovirt-jboss-modules-maven-plugin in:- ovirt-engine- ovirt-engine-api-metamodelIt doesn't seem we are bundling the library so it looks like a build time dependency only. Am I correct?
Yes, build time only
Why aren't we adding it as BuildRequires to ovirt-engine spec file and keeping downloading it from maven central at every build instead of using system installed library?Pushed a patch for requiring it https://gerrit.ovirt.org/#/c/98720/
I'm very surprise it's actually packaged. I remember mentioned lack of packaging to Juan long time ago and he said it's not worth ...
Patch looks good, but I'm sure if we have ever built it on downstream . Ondro, do you know?
Thanks,------
