2012/11/27 <engine-devel-request@ovirt.org>

Send Engine-devel mailing list submissions to
engine-devel@ovirt.org

To subscribe or unsubscribe via the World Wide Web, visit
http://lists.ovirt.org/mailman/listinfo/engine-devel
or, via email, send a message with subject or body 'help' to
engine-devel-request@ovirt.org

You can reach the person managing the list at
engine-devel-owner@ovirt.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Engine-devel digest..."

Today's Topics:

1. maven settings.xml in building ovirt engine wiki (Alissa Bonas)
2. Re: maven settings.xml in building ovirt engine wiki
(Alon Bar-Lev)
3. Re: maven settings.xml in building ovirt engine wiki
(Laszlo Hornyak)

----------------------------------------------------------------------

Message: 1
Date: Mon, 26 Nov 2012 04:15:14 -0500 (EST)
From: Alissa Bonas <abonas@redhat.com>
To: engine-devel@ovirt.org
Subject: [Engine-devel] maven settings.xml in building ovirt engine
wiki
Message-ID:
<1007139143.6796345.1353921314570.JavaMail.root@redhat.com>
Content-Type: text/plain; charset=utf-8

Hi,

In this wiki http://wiki.ovirt.org/wiki/Building_oVirt_engine

The suggested maven settings.xml contains hardcoded paths to jboss_home and java_home.
IMHO it's better to use environment variables to take the above settings from there, instead of managing those settings twice in 2 different places.

The current settings look like this (note that java path is incorrect anyway, including /bin/java)

<jbossHome>/usr/share/jboss-as</jbossHome>
<JAVA_HOME>/usr/lib/jvm/java-1.7.0-openjdk-1.7.0.0.x86_64/bin/java</JAVA_HOME>

How about changing settings.xml to something like:

<jbossHome>${env.JBOSS_HOME}</jbossHome>
<JAVA_HOME>${env.JAVA_HOME}</JAVA_HOME>

Does anyone see a problem with the suggested approach?

Thanks

Alissa

------------------------------

Message: 2
Date: Mon, 26 Nov 2012 04:18:57 -0500 (EST)
From: Alon Bar-Lev <alonbl@redhat.com>
To: Alissa Bonas <abonas@redhat.com>
Cc: engine-devel@ovirt.org
Subject: Re: [Engine-devel] maven settings.xml in building ovirt
engine wiki
Message-ID:
<1686367332.1388894.1353921537535.JavaMail.root@redhat.com>
Content-Type: text/plain; charset=utf-8

----- Original Message -----
> From: "Alissa Bonas" <abonas@redhat.com>
> To: engine-devel@ovirt.org
> Sent: Monday, November 26, 2012 11:15:14 AM
> Subject: [Engine-devel] maven settings.xml in building ovirt engine wiki
>
> Hi,
>
> In this wiki http://wiki.ovirt.org/wiki/Building_oVirt_engine
>
> The suggested maven settings.xml contains hardcoded paths to
> jboss_home and java_home.
> IMHO it's better to use environment variables to take the above
> settings from there, instead of managing those settings twice in 2
> different places.
>
> The current settings look like this (note that java path is incorrect
> anyway, including /bin/java)
>
> <jbossHome>/usr/share/jboss-as</jbossHome>
> <JAVA_HOME>/usr/lib/jvm/java-1.7.0-openjdk-1.7.0.0.x86_64/bin/java</JAVA_HOME>
>
> How about changing settings.xml to something like:
>
> <jbossHome>${env.JBOSS_HOME}</jbossHome>
> <JAVA_HOME>${env.JAVA_HOME}</JAVA_HOME>
>
>
> Does anyone see a problem with the suggested approach?

Well, I did not use this either... just pass -DjbossHome=... to maven.

>
> Thanks
>
> Alissa
>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>

------------------------------

Message: 3
Date: Mon, 26 Nov 2012 11:52:52 -0500 (EST)
From: Laszlo Hornyak <lhornyak@redhat.com>
To: Alissa Bonas <abonas@redhat.com>
Cc: engine-devel@ovirt.org
Subject: Re: [Engine-devel] maven settings.xml in building ovirt
engine wiki
Message-ID: <110546079.728955.1353948772248.JavaMail.root@redhat.com>
Content-Type: text/plain; charset=utf-8

Hi,

That too could work, but once it already needs to be in the settings.xml, why would you want another configuration file (like .bashrc)?

----- Original Message -----
> From: "Alissa Bonas" <abonas@redhat.com>
> To: engine-devel@ovirt.org
> Sent: Monday, November 26, 2012 10:15:14 AM
> Subject: [Engine-devel] maven settings.xml in building ovirt engine wiki
>
> Hi,
>
> In this wiki http://wiki.ovirt.org/wiki/Building_oVirt_engine
>
> The suggested maven settings.xml contains hardcoded paths to
> jboss_home and java_home.
> IMHO it's better to use environment variables to take the above
> settings from there, instead of managing those settings twice in 2
> different places.
>
> The current settings look like this (note that java path is incorrect
> anyway, including /bin/java)
>
> <jbossHome>/usr/share/jboss-as</jbossHome>
> <JAVA_HOME>/usr/lib/jvm/java-1.7.0-openjdk-1.7.0.0.x86_64/bin/java</JAVA_HOME>
>
> How about changing settings.xml to something like:
>
> <jbossHome>${env.JBOSS_HOME}</jbossHome>
> <JAVA_HOME>${env.JAVA_HOME}</JAVA_HOME>
>
>
> Does anyone see a problem with the suggested approach?
>
> Thanks
>
> Alissa
>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>

------------------------------

_______________________________________________
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel

End of Engine-devel Digest, Vol 14, Issue 70
********************************************