On Tue, Mar 13, 2018 at 8:00 PM, Yaniv Kaul <ykaul@redhat.com> wrote:
On Mar 13, 2018 6:27 PM, "Sandro Bonazzola" <sbonazzo@redhat.com> wrote:4 people accepted calendar invite:- Devin A. Bougie- Francesco Romani- Jiri Belka- suporte, logicworks4 people tentatively accepted calendar invite:- Amnon Maimon- Andreas Bleischwitz- Arnaud Lauriou- Stephen Pesini2 mailing lists accepted calendar invite: users@ovirt.org, devel@ovirt.org (don't ask me how) so I may have missed someone in above list4 patches got merged:13 patches has been pushed / reviewed / rebasedNice list of patches!Feedback from the event:- "if we want to add many more tests to OST, and I think we do, we need to do some change there to allow that. Current framework is simply not scalable enough"More specific and constructive ideas are welcome. We know we want to move to pytest, for example.
+1, there is a lot of things we need to improve in OST, the network suite is a good example of going forward with PyTest, we have other idea for improvements like splitting the suites into multiple projects using a new feature in std-ci,
dropping the reposync file or making it optional ( actually ovirt-demo-tool is already doing that, using release rpms ).
If there are more ideas, we can consider doing an infra hackathon where we can focus in improving infrastructure and moving to PyTest most of the tests ( at least in master ) .
- not joining the hackathon because "I'd be like an elephant in a porcelain shop"- "I'm not sure I'm OK with the flood of suites that we have - the more we have, the harder it is to sync and maintain but more importantly - to run."- "We can't keep adding new suite for each parameter we want to test, it adds overhead to monitoring, resources and maintenance."I tend to agree, but not sure how to elegantly solve it.
We need to think on a new design for it which includes scalability and multiple maintainers, the requirements and usage has changed significantly over the years,
I also don't have an easy solution for it, yet at least.
- invite wasn't clear enough. I found people on #ovirt on Freenode and on Red Hat IRC servers and redirected them to OFTC IRC server (my fault, hopefully managed to workaround it by talking to people)Lessons learned:- Calendar invites to mailing lists doesn't work well, need a different way to track mailing list members joining the events.- Invites needs to be pedantic on how to join the event, not leaving space for interpretation and misunderstanding.- We need a contribution guide to ovirt-system-test: we need to make people comfortable in trying to add a new test and we need to ensure that we won't reject a day of work because the patch doesn't match core contributors plannings on number of suites, resources and so on
This could have been better if the single OST maintainer could be part of the planning and also participate and give feedback and assistance, unfourtunately it was decided to do the hackhaton without him present.
I agree we need to improve our contribution guide, and work has started towards it, but any specific feedback or tickets on what can be improved will surely help.
Agree.Y.- The ovirt-system-tests check patch script is not good enough. It triggers too many sequential suites on every single patch pushed, and fails due to timeout taking more than 6 hours to complete.
This is very close to be much better, we're 1-2 weeks away from implemeting a new feature in STD CI V2 which will allow us to replace the existing 'change resolver' and eventually run all suites in check-patch in parallel, dramatically reducing runtime.
- The way ovirt-system-test collects rpms from defined repos is not smart enough: it doesn't take the latest version of a given package, just the first found in sequential order of the repos,
Its not that its not smart, its by design, repoman uses "only-latest" option to get the first RPM he finds from the repos, I'm pretty sure there was a good reason behind it when it was written a few years ago, I'll try to remember and update.
In any case, the relevant patch where this was needed had a different problem with dynamic replacement of repos which we need to think on a solution for.
Thanks everyone who participated to the event! if you have time please continue improving ovirt-system-test even if today event is almost completed!--SANDRO BONAZZOLA
ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D
_______________________________________________
Users mailing list
Users@ovirt.org
http://lists.ovirt.org/mailman/listinfo/users
_______________________________________________
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra
phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)
irc: eedri (on #tlv #rhev-dev #rhev-integ)