Right, there is no python2 firewalld module on fedora, and since ansible renders the role on a python2 machine, the resulting script will not be able to import firewalld.  I think there are bugs on both issues.  

On Tue, Oct 2, 2018, 21:32 Nir Soffer <nsoffer@redhat.com> wrote:
On Tue, Oct 2, 2018 at 8:48 PM Nir Soffer <nsoffer@redhat.com> wrote:
On Tue, Oct 2, 2018 at 8:46 PM Yuval Turgeman <yturgema@redhat.com> wrote:
IIRC you need python-dnf for this (2 or 3 depending on the python version otopi uses)

Installing python-dnf fixes this issue.
Do we have a bug for this issue?

However install fail later in ovirt-host-deploy-ansible:

2018-10-02 21:18:20,611 p=2294 u=nsoffer |  TASK [ovirt-host-deploy-firewalld : Enable SSH port] ***************************
2018-10-02 21:18:21,063 p=2294 u=nsoffer |  fatal: [voodoo1.tlv.redhat.com]: FAILED! => {
    "changed": false
}

MSG:

Python Module not found: firewalld and its python module are required for this module,                         version 0.2.11 or newer required (0.3.9 or newer for offline operations)

2018-10-02 21:18:21,065 p=2294 u=nsoffer |  PLAY RECAP *********************************************************************
2018-10-02 21:18:21,065 p=2294 u=nsoffer |  voodoo1.tlv.redhat.com     : ok=8    changed=2    unreachable=0    failed=1   

I have:

$ rpm -qa | grep firewall
firewalld-0.5.5-1.fc28.noarch
python3-firewall-0.5.5-1.fc28.noarch
firewalld-filesystem-0.5.5-1.fc28.noarch

Do we have a bug for this? 


Maybe, but this should be installed by the system when a user add a host.
 

On Tue, Oct 2, 2018, 20:43 Nir Soffer <nsoffer@redhat.com> wrote:
Trying to add Fedora 28 host to engine master, host installation fails immediately with:

2018-10-02 20:34:45,440+0300 DEBUG otopi.plugins.otopi.dialog.machine dialog.__logString:204 DIALOG:SEND       **%EventStart STAGE internal_packages METHOD otopi.plugins.ovirt_host_deploy.vd
sm.vdsmid.Plugin._packages (None)
2018-10-02 20:34:45,443+0300 DEBUG otopi.context context._executeMethod:143 method exception
Traceback (most recent call last):
  File "/tmp/ovirt-qh2D5sbRmG/pythonlib/otopi/context.py", line 133, in _executeMethod
    method['method']()
  File "/tmp/ovirt-qh2D5sbRmG/otopi-plugins/ovirt-host-deploy/vdsm/vdsmid.py", line 84, in _packages
    self.packager.install(('dmidecode',))
  File "/tmp/ovirt-qh2D5sbRmG/pythonlib/otopi/packager.py", line 102, in install
    raise NotImplementedError(_('Packager install not implemented'))
NotImplementedError: Packager install not implemented
2018-10-02 20:34:45,444+0300 ERROR otopi.context context._executeMethod:152 Failed to execute stage 'Environment packages setup': Packager install not implemented

engine version:
4.3.0_master (efabde5a36cbf85b43a60ead37e42943c35c2741)

Is this a known issue? any workaround?

Nir

_______________________________________________
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-leave@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/
List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/PFTNHRIYORWSADDE7ZVSNMD3IX5P6VT3/