This patch failed also findbugs [1] but was merged regardless.
Also failed dao tests on our ci [2]

[1] http://jenkins-old.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/45846/
[2] http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/7/

On Wed, Jun 8, 2016 at 9:51 PM, Roman Mohr <rmohr@redhat.com> wrote:
Hi we have failing DAO tests becaus of:

https://gerrit.ovirt.org/#/c/56192/

Seems like the cluster can't be saved anymore:

testSave(org.ovirt.engine.core.dao.ClusterDaoTest)  Time elapsed: 9
sec  <<< ERROR!
java.lang.NullPointerException
    at org.ovirt.engine.core.dao.ClusterDaoImpl.getClusterParamSource(ClusterDaoImpl.java:255)
    at org.ovirt.engine.core.dao.ClusterDaoImpl.save(ClusterDaoImpl.java:136)
    at org.ovirt.engine.core.dao.ClusterDaoTest.testSave(ClusterDaoTest.java:318)

ClusterDaoImpl.java:255 is

    .addValue("switch_type",
cluster.getRequiredSwitchTypeForCluster().getOptionValue());

Seems like the the requiredSwitchType is not set for all tests and
when trying to access the getOptionValue() we have a nullpointer
exception.

Fails on my local machine and on travis:
https://s3.amazonaws.com/archive.travis-ci.org/jobs/136184841/log.txt

Best Regards,
Roman
_______________________________________________
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel





--
Eyal Edri
Associate Manager
RHEV DevOps
EMEA ENG Virtualization R&D
Red Hat Israel

phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)