On Mon, Jun 25, 2018 at 8:38 AM Yedidyah Bar David <didi@redhat.com> wrote:
On Sun, Jun 24, 2018 at 8:11 PM, Nir Soffer <nsoffer@redhat.com> wrote:
> On Sun, Jun 24, 2018 at 12:52 PM Yedidyah Bar David <didi@redhat.com> wrote:
>>
>> >> > Adding Fedora 28 host fails with (in host deploy log):
>> >> >
>> >> > AttributeError: 'str' object has no attribute 'decode'
>> >> > 2018-06-21 02:12:18,864+0300 ERROR otopi.context
>> >> > context._executeMethod:152 Failed to execute stage 'Initializing':
>> >> > 'str' object has no attribute 'decode'
>> >> >
>> >> > After fixing this we fail with (in host deploy log):
>> >> >
>> >> > TypeError: a bytes-like object is required, not 'str'
>> >> > 2018-06-21 02:21:50,148+0300 ERROR otopi.context
>> >> > context._executeMethod:152 Failed to execute stage 'Setup
>> >> > validation': a bytes-like object is required, not 'str'
>> >> >
>> >> > Both issues fixed in https://gerrit.ovirt.org/#/c/92437/
>> >> >
>> >> > With this patch we reach the next failure in otopi, fixed in
>> >> > https://gerrit.ovirt.org/#/c/92435/
>> >> >
>> >> >
>> >> Thanks for the patches, Didi can you please review / merge if good?
>>
>> Reviewed and merged both of above patches. Thanks.
>
>
> The fix should be available now if using ovirt-release-master repo, right?

By now, I hope it should. I replied almost immediately after merging,
and propagation through build-artifacts and the change-queue does take
some time. If it's still missing, you can use the build from jenkins -
it's linked from your patch:

https://gerrit.ovirt.org/92435
https://jenkins.ovirt.org/job/otopi_master_build-artifacts-fc28-x86_64/6/

I updated engine today, and added another fc28 host, there was 
no failure during install.

I reproduce again the issue of host no having the ovirtmgmt
bridge after installing. Configuring host network in engine fixes
this issue.

Attaching the host-deploy logs.

And update for block storage - lvm2 was fixed, it works now
we will require this lvm version once it is available in updates.