On 28 Jun 2019, at 17:24, Dan Kenigsberg <danken@redhat.com> wrote:



On Fri, 28 Jun 2019, 18:18 Michal Skrivanek, <michal.skrivanek@redhat.com> wrote:


On 28 Jun 2019, at 16:14, Dan Kenigsberg <danken@redhat.com> wrote:



On Fri, 28 Jun 2019, 17:11 Michal Skrivanek, <michal.skrivanek@redhat.com> wrote:
> On 26 Jun 2019, at 14:53, Milan Zamazal <mzamazal@redhat.com> wrote:
>
> Marcin Sobczyk <msobczyk@redhat.com> writes:
>
>> Hi,
>>
>> I'm currently working on making yajsonrpc/stomp implementation
>> py3-compatible so we can have basic communication with vdsm running on py3.
>> Today for the first time I was able to run vdsm [1] with py3 on fc29 and do
>> a successful 'vdsm-client Host getStats' call.
>
> I can add this also works for me on el8 with your patches, with both TLS
> and non-TLS configuration.  Good work!

Today I got pretty far with top of Milan’s series (including Marcin’s)
on RHEL8.
Capabilities work, and after fixing up network manually (ovirtmgmt
bridge) 

What was the fix, and why was it needed?

Didn’t really try setupNetworks. I can install ifcfg and give it a shot

I believe it is called network-scripts.rpm, thanks.

2019-06-28 18:18:51,471+0200 INFO  (jsonrpc/5) [api.network] START setupNetworks(networks={'ovirtmgmt': {'netmask': '255.255.255.0', 'ipv6autoconf': True, 'n
ic': 'ens3', 'bridged': 'true', 'ipaddr': '10.37.160.184', 'defaultRoute': True, 'dhcpv6': False, 'STP': 'no', 'gateway': '10.37.160.254', 'mtu': 1500, 'swit
ch': 'legacy'}}, bondings={}, options={'connectivityTimeout': 120, 'commitOnSuccess': True, 'connectivityCheck': 'true'}) from=::ffff:10.37.136.87,47578, flo
w_id=aba7df0f-4c9a-41b9-abbd-1c98e8d85616 (api:48)
2019-06-28 18:18:51,515+0200 INFO  (jsonrpc/6) [jsonrpc.JsonRpcServer] RPC call Host.confirmConnectivity succeeded in 0.00 seconds (__init__:314)
2019-06-28 18:19:51,498+0200 WARN  (vdsm.Scheduler) [Executor] Worker blocked: <Worker name=jsonrpc/5 running <Task <JsonRpcTask {'jsonrpc': '2.0', 'method':
 'Host.setupNetworks', 'params': {'networks': {'ovirtmgmt': {'netmask': '255.255.255.0', 'ipv6autoconf': True, 'nic': 'ens3', 'bridged': 'true', 'ipaddr': '1
0.37.160.184', 'defaultRoute': True, 'dhcpv6': False, 'STP': 'no', 'gateway': '10.37.160.254', 'mtu': 1500, 'switch': 'legacy'}}, 'bondings': {}, 'options':
{'connectivityTimeout': 120, 'commitOnSuccess': True, 'connectivityCheck': 'true'}}, 'id': '40c529e3-6377-4d92-890a-e91dbbc88397'} at 0x7f32fc054a58> timeout
=60, duration=60.03 at 0x7f32fc054400> task#=1 at 0x7f32fc0cd390>, traceback:
File: "/usr/lib64/python3.6/threading.py", line 884, in _bootstrap
  self._bootstrap_inner()
File: "/usr/lib64/python3.6/threading.py", line 916, in _bootstrap_inner
  self.run()
File: "/usr/lib64/python3.6/threading.py", line 864, in run
  self._target(*self._args, **self._kwargs)
File: "/usr/lib/python3.6/site-packages/vdsm/common/concurrent.py", line 195, in run
  ret = func(*args, **kwargs)
File: "/usr/lib/python3.6/site-packages/vdsm/executor.py", line 301, in _run
  self._execute_task()
File: "/usr/lib/python3.6/site-packages/vdsm/executor.py", line 315, in _execute_task
  task()
File: "/usr/lib/python3.6/site-packages/vdsm/executor.py", line 391, in __call__
  self._callable()
File: "/usr/lib/python3.6/site-packages/yajsonrpc/__init__.py", line 264, in __call__
  self._handler(self._ctx, self._req)
File: "/usr/lib/python3.6/site-packages/yajsonrpc/__init__.py", line 307, in _serveRequest
  response = self._handle_request(req, ctx)
File: "/usr/lib/python3.6/site-packages/yajsonrpc/__init__.py", line 347, in _handle_request
  res = method(**params)
File: "/usr/lib/python3.6/site-packages/vdsm/rpc/Bridge.py", line 198, in _dynamicMethod
  result = fn(*methodArgs)
File: "<decorator-gen-470>", line 2, in setupNetworks
File: "/usr/lib/python3.6/site-packages/vdsm/common/api.py", line 50, in method
  ret = func(*args, **kwargs)
File: "/usr/lib/python3.6/site-packages/vdsm/API.py", line 1517, in setupNetworks
  supervdsm.getProxy().setupNetworks(networks, bondings, options)
File: "/usr/lib/python3.6/site-packages/vdsm/common/supervdsm.py", line 56, in __call__
  return callMethod()
File: "/usr/lib/python3.6/site-packages/vdsm/common/supervdsm.py", line 54, in <lambda>
  **kwargs)
File: "<string>", line 2, in setupNetworks
File: "/usr/lib64/python3.6/multiprocessing/managers.py", line 757, in _callmethod
  kind, result = conn.recv()
File: "/usr/lib64/python3.6/multiprocessing/connection.py", line 250, in recv
  buf = self._recv_bytes()
File: "/usr/lib64/python3.6/multiprocessing/connection.py", line 407, in _recv_bytes
  buf = self._recv(4)
File: "/usr/lib64/python3.6/multiprocessing/connection.py", line 379, in _recv
  chunk = read(handle, remaining) (executor:363)
2019-06-28 18:19:52,014+0200 ERROR (jsonrpc/5) [vds]  (API:1520)
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/vdsm/API.py", line 1517, in setupNetworks
    supervdsm.getProxy().setupNetworks(networks, bondings, options)
  File "/usr/lib/python3.6/site-packages/vdsm/common/supervdsm.py", line 56, in __call__
    return callMethod()
  File "/usr/lib/python3.6/site-packages/vdsm/common/supervdsm.py", line 54, in <lambda>
    **kwargs)
  File "<string>", line 2, in setupNetworks
  File "/usr/lib64/python3.6/multiprocessing/managers.py", line 772, in _callmethod
    raise convert_to_error(kind, result)
vdsm.network.errors.ConfigNetworkError: (29, '')
2019-06-28 18:19:52,014+0200 INFO  (jsonrpc/5) [api.network] FINISH setupNetworks return={'status': {'code': 29, 'message': ''}} from=::ffff:10.37.136.87,47578, flow_id=aba7df0f-4c9a-41b9-abbd-1c98e8d85616 (api:54)
2019-06-28 18:19:52,015+0200 INFO  (jsonrpc/5) [jsonrpc.JsonRpcServer] RPC call Host.setupNetworks failed (error 29) in 60.55 seconds (__init__:314)