Doesn't seem related; the patch does nothing but move pieces around.

Judging by the title I guess you're referring to https://gerrit.ovirt.org/#/c/67787/ ?

On Thu, Dec 22, 2016 at 5:14 PM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
Hi guys and Leon,

https://gerrit.ovirt.org/#/c/68078/ broke the check-merged job with really tough exception:

15:23:34 sh: [17766: 1 (255)] tcsetattr: Inappropriate ioctl for device
15:23:34 Took 2586 seconds
15:23:34 Slave went offline during the build
15:23:34 ERROR: Connection was broken: java.io.IOException: Unexpected termination of the channel
15:23:34 	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:50)
15:23:34 Caused by: java.io.EOFException
15:23:34 	at java.io.ObjectInputStream$PeekInputStream.readFully(ObjectInputStream.java:2353)
15:23:34 	at java.io.ObjectInputStream$BlockDataInputStream.readShort(ObjectInputStream.java:2822)
15:23:34 	at java.io.ObjectInputStream.readStreamHeader(ObjectInputStream.java:804)
15:23:34 	at java.io.ObjectInputStream.<init>(ObjectInputStream.java:301)
15:23:34 	at hudson.remoting.ObjectInputStreamEx.<init>(ObjectInputStreamEx.java:48)
15:23:34 	at hudson.remoting.AbstractSynchronousByteArrayCommandTransport.read(AbstractSynchronousByteArrayCommandTransport.java:34)
15:23:34 	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:48)
15:23:34 
15:23:34 Build step 'Execute shell' marked build as failure
15:23:34 Performing Post build task...

I have no clue what causes it.. we need to investigate in the tests code.

you can see it in http://jenkins.ovirt.org/job/vdsm_master_check-merged-el7-x86_64/772/consoleFull

and this for a job run just before it got in, which worked well - http://jenkins.ovirt.org/job/vdsm_master_check-merged-el7-x86_64/688/console

I suggest to revert this patch (and backport the revert to ovirt-4.1 branch as well) until figuring what causes it

--
Yaniv Bronhaim.