Hi,

I agree with Michal. The Thread is very important for the debugging. Obviously you can highlight what you need, but still the thread is jumping there and back which make is less readable. It would be ok if that would be on the third place as the log level is aligned. It makes huge difference if you look to the logs the entire day.

A part of that I do not see any issues. The spaces are Ok as long as it is parsable. It looks like it should not be a problem.

Roman

On Wed, Sep 21, 2016 at 12:12 PM, Peter Portante <pportant@redhat.com> wrote:


On Wed, Sep 21, 2016 at 2:54 AM, Michal Skrivanek <michal.skrivanek@redhat.com> wrote:

> On 20 Sep 2016, at 19:52, Nir Soffer <nsoffer@redhat.com> wrote:
>
> Hi all,
>
> We are reviewing patches for improving vdsm log format.
>
> The goal is to have more standard logging format, similar to engine
> logs and other logs in the ovirt project, to make it easier to debug
> and support the system.
>
> We know that this change will break tools people wrote to parse vdsm
> logs (I wrote couple), but we find vdsm log format too painful to work
> with, and we hope this is be useful in the long term.
>
> Please review.
> https://gerrit.ovirt.org/#/q/topic:log-format

Hi Nir,
typically for concise changes reviewing a single patch is way easier than whole topic. I know vdsm developers prefer it that way, but please do realize it is harder for “external” people to comprehend and you get less feedback.
I see example of the new format mentioned in one commit message as a link to pastebin. I suppose including a single line example in the commit message itself is a bit more persistent

Just two notes - big -1 on moving the thread id further down the line. Typically this is the only thing with some continuity, making it the most important thing to see. Putting it at a fixed aligned position somewhere at the beginning of the line would help a lot.
Do we switch to UTC timestamp or still want to use local time? It does make it a bit hard to correlate with libvirt and qemu.

Lurker chiming in here ...

Using UTC is really important when correlating across multiple systems.  All of the boxes we run in production we have placed in UTC to help us correlate events across our environment. We had no end of frustrations when we could not find ANY logs to debug a problem due to a timezone shift.

And keep in mind, the one reviewing events in time may not be in the same timezone as well, so the original timezone information will often get converted to the local timezone of that reviewer.

Thanks for considering,

-peter
 

Thanks for the improvements!
michal

>
> Thanks,
> Nir
> _______________________________________________
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel

_______________________________________________
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel




--
Roman Hodain
Software Maintenance Engineer
Brno, The Czech Republic
Phone: +420.532294924
IRC: rhodain