I'm trying to enable copr builds for vdsm ( https://gerrit.ovirt.org/c/vdsm/+/117368 )

And it's currently failing to rebuild src.rpm (generated on Fedora 34) for el8 with the following error:
(https://download.copr.fedorainfracloud.org/results/ovirt/ovirt-master-snapshot/centos-stream-8-x86_64/02912480-vdsm/build.log.gz )

make[2]: Entering directory '/builddir/build/BUILD/vdsm-4.50.0.1/lib/vdsm'
Making all in api
make[3]: Entering directory '/builddir/build/BUILD/vdsm-4.50.0.1/lib/vdsm/api'
  Generate vdsm-api.html
chmod u+w .
PYTHONPATH=./../../:./../../vdsm \
	./schema_to_html.py vdsm-api ./vdsm-api.html
Traceback (most recent call last):
  File "./schema_to_html.py", line 250, in <module>
    main()
  File "./schema_to_html.py", line 245, in main
    api_schema = vdsmapi.Schema((schema_type,), strict_mode=False)
  File "/builddir/build/BUILD/vdsm-4.50.0.1/lib/vdsm/api/vdsmapi.py", line 145, in __init__
    loaded_schema = pickle.loads(f.read())
ValueError: unsupported pickle protocol: 5
make[3]: *** [Makefile:697: vdsm-api.html] Error 1
make[3]: Leaving directory '/builddir/build/BUILD/vdsm-4.50.0.1/lib/vdsm/api'
make[2]: *** [Makefile:644: all-recursive] Error 1
make[2]: Leaving directory '/builddir/build/BUILD/vdsm-4.50.0.1/lib/vdsm'
make[1]: *** [Makefile:466: all-recursive] Error 1
make[1]: Leaving directory '/builddir/build/BUILD/vdsm-4.50.0.1/lib'
make: *** [Makefile:539: all-recursive] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.nDfLzv (%build)

Sounds like the make dist process ran on Fedora 34 brings a source file used at build time on el8 in a cpickle format which is not backward compatible.

Seems to be a bug, the cpickle shouldn't be included in the tar.gz, it should be generated at build time.

Comments?

--