Il giorno lun 10 dic 2018 alle ore 19:42 Dan Kenigsberg <danken@redhat.com> ha scritto:

On Mon, 10 Dec 2018, 19:17 Dominik Holler <dholler@redhat.com wrote:

On Mon, 10 Dec 2018 12:02:21 -0500
Greg Sheremeta <gshereme@redhat.com> wrote:

> On Mon, Dec 10, 2018 at 11:53 AM Sandro Bonazzola <sbonazzo@redhat.com>
> wrote:
>
> > hi, ovirt-system-tests_compat-4.2-suite-master is failing since November
> > 27 with following error:
> >
> > Error: Fault reason is "Operation Failed". Fault detail is "[Bond name 'bond_fancy0' does not follow naming criteria. For host compatibility version 4.3 or greater, custom bond names must begin with the prefix 'bond'  followed by 'a-z', 'A-Z', '0-9', or '_' characters. For host compatibility version 4.2 and lower, custom bond names must begin with the prefix 'bond' followed by a number.]". HTTP response code is 400.
> >
> >
> > I think that if the scope of the test is to check that 4.2 still works
> > with 4.3 engine, bond_fancy0 works for 4.3 but it's clearly not good for
> > 4.2 and the test needs a fix.
> > 
>

Gal, what is the most correct way to fix this?
Should the BOND_NAME derived from the versioning.cluster_version()?

as https://gerrit.ovirt.org/#/c/95866/ suggested for another reason

Is this covering engine 4.3 with cluster 4.2?

 

Or should we add an extra test which require_version(4,3) with the
fancy bond name?

> Not sure about the test, but yes, it needs to be bond[\d+] for 4.2.
> https://gerrit.ovirt.org/#/c/95163/
>

Yes.

>
> >
> > --
> >
> > SANDRO BONAZZOLA
> >
> > MANAGER, SOFTWARE ENGINEERING, EMEA R&D RHV
> >
> > Red Hat EMEA <https://www.redhat.com/>
> >
> > sbonazzo@redhat.com
> > <https://red.ht/sig>
> > _______________________________________________
> > Devel mailing list -- devel@ovirt.org
> > To unsubscribe send an email to devel-leave@ovirt.org
> > Privacy Statement: https://www.ovirt.org/site/privacy-policy/
> > oVirt Code of Conduct:
> > https://www.ovirt.org/community/about/community-guidelines/
> > List Archives:
> > https://lists.ovirt.org/archives/list/devel@ovirt.org/message/PFJ2Y2PD4SIGLV4BSYLXOQANO5OJTQGT/
> > 
>
>

--

SANDRO BONAZZOLA

MANAGER, SOFTWARE ENGINEERING, EMEA R&D RHV

Red Hat EMEA

sbonazzo@redhat.com